From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF6F9C433FE for ; Fri, 7 Oct 2022 07:06:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229747AbiJGHGn (ORCPT ); Fri, 7 Oct 2022 03:06:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbiJGHGm (ORCPT ); Fri, 7 Oct 2022 03:06:42 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 176DBA5992 for ; Fri, 7 Oct 2022 00:06:40 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id q17so4663849lji.11 for ; Fri, 07 Oct 2022 00:06:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=FSmGNYPsHl9Ro1MJ7SK0qxA2b0opEEGQTUXyGcDbh9o=; b=foHGxaipVhE4g1J2J3AKimMGWlMyYJ94BYSHus4iZXvHzycxZHOaxVIcx75vQhOkhM RUVn3+LF8DvwQqMfdRMsxSMAJQngOWfZ6Svfr2JJ+G/4EvJx4bwVbjnmBY4t8CWfPni/ aOR68VVLHTz7M7lPiPwoxWld9aXAT2/zkWVus3Zvn8q61bqVvRZ33+lRHBUNJTqjTFbs 7XOGhE0fGA7qyBmXMZYY+mSQ5mFW34rU2W0UDjJGmxSIG+Y43UQsQLQ/lMx7EWFebWB4 /P3j0y4pT6ICbE7mbZW5+cWBwZvsuC95D1CrY8tVaGHo0rW8nIQJiv1qvS6CfpB+hnHJ 9lwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=FSmGNYPsHl9Ro1MJ7SK0qxA2b0opEEGQTUXyGcDbh9o=; b=4tu0sdObQdZBBMZ9fCojfCEcZn3WwEAeSLhyT5XhahUXnYF1enVgwW0eRnWS68KI1o yFIDK421h6go9Ls0DyeMQq70i10KIozmp34oRaGIARfftUXyaibkIgjWtNraWaVYdGhj j+St+UsNHsDvsDl+W9gyToaH+qvosGQpj1fI3JmmQJE5ctFUtvSCJp6ZPChTGo95zLKR nZ6oXBLYB0MtRsCrgB9zkVEsbTTPGJsMatNLIw6TOuGQnC/bVRO9s7muuMGP8wTbXI+w PxgoqaYepvW14Tv7IllB5T/3xUjmPMKWOLoFaOdI1/WadqZau6Zz+XWqSKe3PBIVmR8/ pdFA== X-Gm-Message-State: ACrzQf2argbGGJHblsO0H+DBt6MNvofYoG0vPVf+YBiAq6W/fH4Q+U/t qbg7JCOLuuHpvAYBJpeB0gFERg== X-Google-Smtp-Source: AMsMyM7eIvv5GKIgDiCZIjDDnCooaDnHvZD7wBLGQTTRpllEwxZlb9pUXT4af4QcZRMvuZKVS512JA== X-Received: by 2002:a2e:92c8:0:b0:25d:6ddf:e71d with SMTP id k8-20020a2e92c8000000b0025d6ddfe71dmr1129408ljh.170.1665126398407; Fri, 07 Oct 2022 00:06:38 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id a17-20020a056512201100b004a27bb1ad62sm173557lfb.205.2022.10.07.00.06.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Oct 2022 00:06:38 -0700 (PDT) Message-ID: <4b861177-df32-ab9c-c746-f32f0ee6438d@linaro.org> Date: Fri, 7 Oct 2022 09:06:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v3] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC Content-Language: en-US To: Delphine CC Chiu , krzysztof.kozlowski@linaro.or Cc: patrick@stwcx.xyz, garnermic@fb.com, Bonnie Lo , Arnd Bergmann , Olof Johansson , soc@kernel.org, Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org References: <20221007055346.3484180-1-Delphine_CC_Chiu@Wiwynn.com> From: Krzysztof Kozlowski In-Reply-To: <20221007055346.3484180-1-Delphine_CC_Chiu@Wiwynn.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/10/2022 07:53, Delphine CC Chiu wrote: > Add linux device tree entry related to > greatlakes specific devices connected to BMC SoC. > > --- > --- v3 - Add documentation of board compatible (bindings) > --- - Add board compatible > --- - Remove the bootargs > --- - Revise the DTS node name > --- > --- v2 - Add binding document > --- > --- v1 - Initial draft This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. > --- > > Signed-off-by: Bonnie Lo > --- > arch/arm/boot/dts/Makefile | 1 + > .../dts/aspeed-bmc-facebook-greatlakes.dts | 241 ++++++++++++++++++ You need to document the binding. I think you already did, but then submitted without it. Read the process: https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst Best regards, Krzysztof