From: Robin Murphy <robin.murphy@arm.com>
To: "Heiko Stübner" <heiko@sntech.de>,
devicetree@vger.kernel.org,
"Chris Morgan" <macroalpha82@gmail.com>
Cc: robh+dt@kernel.org, jon.lin@rock-chips.com,
linux-rockchip@lists.infradead.org,
Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH] arm64: dts: rockchip: Correct clock-output-names for rk817
Date: Wed, 16 Feb 2022 21:34:52 +0000 [thread overview]
Message-ID: <4b88f0f1-7422-7beb-2f7a-563f1f4b3360@arm.com> (raw)
In-Reply-To: <44462609.a43xROnmBz@diego>
On 2022-02-16 20:42, Heiko Stübner wrote:
> Hi,
>
> Am Mittwoch, 16. Februar 2022, 17:58:37 CET schrieb Chris Morgan:
>> From: Chris Morgan <macromorgan@hotmail.com>
>>
>> According to the datasheet for the rk817 there is only a single output
>> clock for the PMIC. I don't believe this is causing any harm though
>> and testing this change doesn't appear to have any noticeable effects.
>
> hmm, looking at the go2's schematics, I'd disagree:
>
> - yes, the rk817 has only one clock output
> - but no, it is used for the clkout_32k signal, which gets piped back into
> the SoC. As that clock dynamically appears at some unspecified point
> when the rk817 probes, the clock controller expects it to be named
> xin32k to bind into its clock-tree.
>
> The driver (drivers/clk/clk-rk808.c) really puts that rk817-clk32k at
> position 2 but I'm not sure if that simply papers over some implementation
Indeed it appears to be a hangover from RK808 where CLK32KOUT1 is
always-on and CLK32KOUT2 is the switchable one. It's even more obvious
on RK805 which still shares the original control register layout.
Robin.
>
>
> Heiko
>
>> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
>> ---
>> arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
>> index ea0695b51ecd..5b23e607876e 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
>> @@ -296,7 +296,7 @@ rk817: pmic@20 {
>> reg = <0x20>;
>> interrupt-parent = <&gpio0>;
>> interrupts = <RK_PB2 IRQ_TYPE_LEVEL_LOW>;
>> - clock-output-names = "rk808-clkout1", "xin32k";
>> + clock-output-names = "rk808-clkout1";
>> clock-names = "mclk";
>> clocks = <&cru SCLK_I2S1_OUT>;
>> pinctrl-names = "default";
>>
>
>
>
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2022-02-16 21:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 16:58 [PATCH] arm64: dts: rockchip: Correct clock-output-names for rk817 Chris Morgan
2022-02-16 20:42 ` Heiko Stübner
2022-02-16 21:34 ` Robin Murphy [this message]
2022-02-22 19:14 ` Chris Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b88f0f1-7422-7beb-2f7a-563f1f4b3360@arm.com \
--to=robin.murphy@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jon.lin@rock-chips.com \
--cc=linux-rockchip@lists.infradead.org \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox