devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: neil.armstrong@linaro.org
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/12] arm64: dts: qcom: sm8650-mtp: connect USB-C SS port to QMP PHY
Date: Mon, 29 Apr 2024 14:48:04 +0200	[thread overview]
Message-ID: <4ba02a4e-705c-469d-96db-0077749fc25d@linaro.org> (raw)
In-Reply-To: <20240429-usb-link-dtsi-v1-10-87c341b55cdf@linaro.org>

On 29/04/2024 14:43, Dmitry Baryshkov wrote:
> The lanes from the USB-C SS port are connected to the combo USB+DP QMP
> PHY rather than the SS port of the USB controller. Move the connection
> endpoint to the QMP PHY out port.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>   arch/arm64/boot/dts/qcom/sm8650-mtp.dts | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
> index d04ceaa73c2b..819f6eadba07 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
> @@ -59,7 +59,7 @@ port@1 {
>   					reg = <1>;
>   
>   					pmic_glink_ss_in: endpoint {
> -						remote-endpoint = <&usb_1_dwc3_ss>;
> +						remote-endpoint = <&usb_dp_qmpphy_out>;
>   					};
>   				};
>   			};
> @@ -853,10 +853,6 @@ &usb_1_dwc3_hs {
>   	remote-endpoint = <&pmic_glink_hs_in>;
>   };
>   
> -&usb_1_dwc3_ss {
> -	remote-endpoint = <&pmic_glink_ss_in>;
> -};
> -
>   &usb_1_hsphy {
>   	vdd-supply = <&vreg_l1i_0p88>;
>   	vdda12-supply = <&vreg_l3i_1p2>;
> @@ -873,6 +869,10 @@ &usb_dp_qmpphy {
>   	status = "okay";
>   };
>   
> +&usb_dp_qmpphy_out {
> +	remote-endpoint = <&pmic_glink_ss_in>;
> +};
> +
>   &xo_board {
>   	clock-frequency = <76800000>;
>   };
> 

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

  reply	other threads:[~2024-04-29 12:48 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-29 12:43 [PATCH 00/12] arm64: dts: qcom: move common USB-related properties to SoC dtsi Dmitry Baryshkov
2024-04-29 12:43 ` [PATCH 01/12] arm64: dts: qcom: sm8150: move USB graph to the " Dmitry Baryshkov
2024-04-30  9:34   ` Konrad Dybcio
2024-04-29 12:43 ` [PATCH 02/12] arm64: dts: qcom: sm8350: " Dmitry Baryshkov
2024-04-30  9:35   ` Konrad Dybcio
2024-04-29 12:43 ` [PATCH 03/12] arm64: dts: qcom: sm8450: " Dmitry Baryshkov
2024-04-29 12:51   ` neil.armstrong
2024-04-30  9:35   ` Konrad Dybcio
2024-04-29 12:43 ` [PATCH 04/12] arm64: dts: qcom: sm8550: " Dmitry Baryshkov
2024-04-29 12:52   ` neil.armstrong
2024-04-30  9:35   ` Konrad Dybcio
2024-04-29 12:43 ` [PATCH 05/12] arm64: dts: qcom: sm8650: " Dmitry Baryshkov
2024-04-29 12:52   ` neil.armstrong
2024-04-30  9:35   ` Konrad Dybcio
2024-04-29 12:43 ` [PATCH 06/12] arm64: dts: qcom: sm8350: move PHY's orientation-switch to " Dmitry Baryshkov
2024-04-30  9:35   ` Konrad Dybcio
2024-04-29 12:43 ` [PATCH 07/12] arm64: dts: qcom: sm8450: " Dmitry Baryshkov
2024-04-29 12:51   ` neil.armstrong
2024-04-30  9:35   ` Konrad Dybcio
2024-04-29 12:43 ` [PATCH 08/12] arm64: dts: qcom: sm8550: " Dmitry Baryshkov
2024-04-29 12:51   ` neil.armstrong
2024-04-30  9:35   ` Konrad Dybcio
2024-04-29 12:43 ` [PATCH 09/12] arm64: dts: qcom: sm8650: " Dmitry Baryshkov
2024-04-29 12:50   ` neil.armstrong
2024-04-30  9:36   ` Konrad Dybcio
2024-04-29 12:43 ` [PATCH 10/12] arm64: dts: qcom: sm8650-mtp: connect USB-C SS port to QMP PHY Dmitry Baryshkov
2024-04-29 12:48   ` neil.armstrong [this message]
2024-04-30  9:36   ` Konrad Dybcio
2024-04-29 12:43 ` [PATCH 11/12] arm64: dts: qcom: delete wrong usb-role-switch properties Dmitry Baryshkov
2024-04-30  9:34   ` Konrad Dybcio
2024-04-30 10:06     ` Dmitry Baryshkov
2024-04-29 12:43 ` [PATCH 12/12] arm64: dts: qcom: x1e80100: drop " Dmitry Baryshkov
2024-05-27  3:00 ` [PATCH 00/12] arm64: dts: qcom: move common USB-related properties to SoC dtsi Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ba02a4e-705c-469d-96db-0077749fc25d@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).