From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4311C001B3 for ; Tue, 27 Jun 2023 20:45:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229777AbjF0UpY (ORCPT ); Tue, 27 Jun 2023 16:45:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230152AbjF0UpX (ORCPT ); Tue, 27 Jun 2023 16:45:23 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A248219A9 for ; Tue, 27 Jun 2023 13:45:20 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-4f86dbce369so6877570e87.0 for ; Tue, 27 Jun 2023 13:45:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687898719; x=1690490719; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=D9ru+T8nqazYLMXoRwumR/NEoX/XtATe6EB1G8ho0j8=; b=I1sqwLXpbcEnd1wwXIyCuZmDCkWngc0WHqtkEX7lhATSOCkzGZPyXXudHbRlj6S4Tm dgqboRx9azvvaCgIhKJO7CSJ9rKiKRNSOt1WoSgyxgpMBOzlFvuFP7uU7FmyKbrAW0e8 3iAwaZ7l+Wf7tPHmP50bHVOcEdoFfUrlIgaidJ5Q/eQI/PK7ZheDATT77ObZPIYMSEeG afk86XXovYzh7fxatbtNUKRJKaIMDEM/94X4FTpNfq/pHPHJX0UkZX8Zaw1ahP9jcl+O Kfrm1hggGP/Obj41qCM6qxK7MmTdXR/lSNjgsrdm7pH50GwWRwT1nA2dS/9nVO3SUxzF hJTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687898719; x=1690490719; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=D9ru+T8nqazYLMXoRwumR/NEoX/XtATe6EB1G8ho0j8=; b=UpqnK0HuHptXTQUzFgevbjyJugPrPp7Bb80mEqG0nvyR6uJkepaWUnPGs7uhqUiVuc 1c5mw7e3ReavgU5+dISgpBf9ecTocaIcdh+BvmvaqCc8yEiqE57q07dKowlsfr5eeWRx xlkt/gx8Feeo5Z1kb+Oaf8njX18YFmAPmqXKpmlpmteoAolzN/Ed9Kt5WMI4p8K4QrpH NHfCt1cUi1o2vannLVShglPu/blyqScJ0MeIYXE8GD8Hr5SCc45xcx9E7qpnBsVDtBTq Vyl8hO6e64YSidnBTF7vUCchnntEdesI8+Fiwn3NPmpXkr4lmTuX6PCR0afQG1fKXJR6 VUhg== X-Gm-Message-State: AC+VfDxCJLyNNuV6dNOhvtJHNbpqZly4+FLe+ONMfMW3dczOZmlVmCBs eUWnqgqlfhxzbR04MLqfbiFvcw== X-Google-Smtp-Source: ACHHUZ6qN2iNek8NXD76EZBE61ieXN9cwzO56UAAW6jMnswfTYAqk4dn5HUYqWPvmwhAL5P3u7hIAw== X-Received: by 2002:a05:6512:4029:b0:4f9:6b94:3cb9 with SMTP id br41-20020a056512402900b004f96b943cb9mr10197467lfb.16.1687898718760; Tue, 27 Jun 2023 13:45:18 -0700 (PDT) Received: from [192.168.1.101] (abxj103.neoplus.adsl.tpnet.pl. [83.9.3.103]) by smtp.gmail.com with ESMTPSA id eo27-20020a056512481b00b004f874e12e72sm1663888lfb.224.2023.06.27.13.45.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jun 2023 13:45:17 -0700 (PDT) Message-ID: <4ba0cd62-e629-581c-e332-01c068901ca4@linaro.org> Date: Tue, 27 Jun 2023 22:45:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 01/15] drm/msm/dsi: Drop unused regulators from QCM2290 14nm DSI PHY config Content-Language: en-US To: Marijn Suijten , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Krishna Manikandan , Loic Poulain , Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Martin Botka , Jami Kettunen , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Lux Aliaga References: <20230627-sm6125-dpu-v2-0-03e430a2078c@somainline.org> <20230627-sm6125-dpu-v2-1-03e430a2078c@somainline.org> From: Konrad Dybcio In-Reply-To: <20230627-sm6125-dpu-v2-1-03e430a2078c@somainline.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27.06.2023 22:14, Marijn Suijten wrote: > The regulator setup was likely copied from other SoCs by mistake. Just > like SM6125 the DSI PHY on this platform is not getting power from a > regulator but from the MX power domain. > > Fixes: 572e9fd6d14a ("drm/msm/dsi: Add phy configuration for QCM2290") > Signed-off-by: Marijn Suijten > --- Reviewed-by: Konrad Dybcio Konrad > drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c > index 3ce45b023e63..31deda1c664a 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c > @@ -1087,8 +1087,6 @@ const struct msm_dsi_phy_cfg dsi_phy_14nm_8953_cfgs = { > > const struct msm_dsi_phy_cfg dsi_phy_14nm_2290_cfgs = { > .has_phy_lane = true, > - .regulator_data = dsi_phy_14nm_17mA_regulators, > - .num_regulators = ARRAY_SIZE(dsi_phy_14nm_17mA_regulators), > .ops = { > .enable = dsi_14nm_phy_enable, > .disable = dsi_14nm_phy_disable, >