Re: [PATCH v2 4/9] ARM: dts: rockchip: rv1126: Add i2c2 nodes

[Tim Lunn <tim@feathertop.org>]

Hi Krzysztof

On 11/22/23 23:29, Krzysztof Kozlowski wrote:
> On 22/11/2023 13:22, Tim Lunn wrote:
>> Add i2c2 node and i2c2_xfer pinctrl for Rockchip RV1126
>>
>> Signed-off-by: Tim Lunn <tim@feathertop.org>
>> ---
>>
>> (no changes since v1)
>>
>>   arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi | 10 ++++++++++
>>   arch/arm/boot/dts/rockchip/rv1126.dtsi         | 15 +++++++++++++++
>>   2 files changed, 25 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi b/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi
>> index 4f85b7b3fc4c..167a48afa3a4 100644
>> --- a/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi
>> +++ b/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi
>> @@ -87,6 +87,16 @@ i2c0_xfer: i2c0-xfer {
>>   				<0 RK_PB5 1 &pcfg_pull_none_drv_level_0_smt>;
>>   		};
>>   	};
>> +	i2c2 {
>> +		/omit-if-no-ref/
>> +		i2c2_xfer: i2c2-xfer {
>> +			rockchip,pins =
>> +				/* i2c2_scl */
>> +				<0 RK_PC2 1 &pcfg_pull_none_drv_level_0_smt>,
>> +				/* i2c2_sda */
>> +				<0 RK_PC3 1 &pcfg_pull_none_drv_level_0_smt>;
>> +		};
>> +	};
>>   	pwm2 {
>>   		/omit-if-no-ref/
>>   		pwm2m0_pins: pwm2m0-pins {
>> diff --git a/arch/arm/boot/dts/rockchip/rv1126.dtsi b/arch/arm/boot/dts/rockchip/rv1126.dtsi
>> index 6c5c928f06c7..cf1df75df418 100644
>> --- a/arch/arm/boot/dts/rockchip/rv1126.dtsi
>> +++ b/arch/arm/boot/dts/rockchip/rv1126.dtsi
>> @@ -21,6 +21,7 @@ / {
>>   
>>   	aliases {
>>   		i2c0 = &i2c0;
>> +		i2c2 = &i2c2;
> No, this should be per-board to match board labeling/schematics.
>
I was just following what seemed to be done in some other Rockchip 
<SoC>.dtsi files. I will move this alias
and the other ones for serial and ethernet into the board file instead then.

Regards
   Tim
>
> Best regards,
> Krzysztof
>