From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=feathertop.org header.i=@feathertop.org header.b="wEXHfJxm"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="hyHO2FVM" Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2A0510C for ; Wed, 22 Nov 2023 05:09:55 -0800 (PST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 702F33200AFD; Wed, 22 Nov 2023 08:09:54 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 22 Nov 2023 08:09:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=feathertop.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to; s=fm3; t=1700658593; x=1700744993; bh=8JYFkWpBAJZ7oAK7axaEz4qpz 7gfYd54GwE6wk4IGMM=; b=wEXHfJxmZpXxMt+bflkLpJuZXa2+w5392/GKS3bK9 qzFFhucVp97QXwNuc2j59OCRTXBjK3+S22A6b7xJJUV0pXCV77/wo71QD9feJLK/ +FmdIw7/60gMCwrxc/WQHIVUjUgCfFkmjzJ57TRSBe4uXdrAZbWb/7JemNd5XOcd jWfyK5UHMoWj3bZHb+AtnexbzfLmxm9AUyU14XbL2DKyi9vx9HAEdPRNTKRiOj1O W8dkPF2KIMHnFbI3oP6dwW6RWHOrXC0xSNfSQstrg1GJumsE9fDyjpIoQXwSfM62 kn8OxAi+4CxFxP9JZ52o4dH3q6R4YcqKxAk6nBb5YKmeQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1700658593; x=1700744993; bh=8JYFkWpBAJZ7oAK7axaEz4qpz7gfYd54GwE 6wk4IGMM=; b=hyHO2FVMSr3vLZOUPe7MO844IQ9H+/AqUAgvMS/rFjKAdn0KRau oT2iW6iCqG+IslrvikVk8cq5d2aO3SmgGO0XTGdG0X/OOAv0d+5Of4J5ReUS2Qkr /SvmcuTXpK0s7SOTFoGEuhDCrlc5VLF50qWusxpfFbfeJKUzLntFewWnivFQoIat rqKUm0O+6M/KkrvLF+q4YLy9wwA/CF9jzo+lENfDswPs6XBn3rAl6oStWkF59uJT asC94VYaJUFpo8vHy1pXlBgF0H4CvvvA7Lh130fAXOG4jFkbCEgbUzS9t3ZzrXFY MGx7dAbBcCOm2T+wRstAluOXBKiCGUeOmhQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudehuddggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtvdejnecuhfhrohhmpefvihhm ucfnuhhnnhcuoehtihhmsehfvggrthhhvghrthhophdrohhrgheqnecuggftrfgrthhtvg hrnhepueegfefgveeuiedtheffgfefveejkeetiefhhfdvjeevlefhueekudeuleeghfek necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhimh esfhgvrghthhgvrhhtohhprdhorhhg X-ME-Proxy: Feedback-ID: i1f8241ce:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 22 Nov 2023 08:09:49 -0500 (EST) Message-ID: <4baa862c-3e05-46f4-a70e-aaa50ecd424a@feathertop.org> Date: Thu, 23 Nov 2023 00:09:46 +1100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/9] ARM: dts: rockchip: rv1126: Add i2c2 nodes Content-Language: en-US To: Krzysztof Kozlowski , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org Cc: Jagan Teki , Rob Herring , linux-arm-kernel@lists.infradead.org, Heiko Stuebner , Krzysztof Kozlowski , Conor Dooley References: <20231122122232.952696-1-tim@feathertop.org> <20231122122232.952696-5-tim@feathertop.org> <813224c2-398d-4c2d-8909-1839ce63be60@linaro.org> From: Tim Lunn In-Reply-To: <813224c2-398d-4c2d-8909-1839ce63be60@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Krzysztof On 11/22/23 23:29, Krzysztof Kozlowski wrote: > On 22/11/2023 13:22, Tim Lunn wrote: >> Add i2c2 node and i2c2_xfer pinctrl for Rockchip RV1126 >> >> Signed-off-by: Tim Lunn >> --- >> >> (no changes since v1) >> >> arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi | 10 ++++++++++ >> arch/arm/boot/dts/rockchip/rv1126.dtsi | 15 +++++++++++++++ >> 2 files changed, 25 insertions(+) >> >> diff --git a/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi b/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi >> index 4f85b7b3fc4c..167a48afa3a4 100644 >> --- a/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi >> +++ b/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi >> @@ -87,6 +87,16 @@ i2c0_xfer: i2c0-xfer { >> <0 RK_PB5 1 &pcfg_pull_none_drv_level_0_smt>; >> }; >> }; >> + i2c2 { >> + /omit-if-no-ref/ >> + i2c2_xfer: i2c2-xfer { >> + rockchip,pins = >> + /* i2c2_scl */ >> + <0 RK_PC2 1 &pcfg_pull_none_drv_level_0_smt>, >> + /* i2c2_sda */ >> + <0 RK_PC3 1 &pcfg_pull_none_drv_level_0_smt>; >> + }; >> + }; >> pwm2 { >> /omit-if-no-ref/ >> pwm2m0_pins: pwm2m0-pins { >> diff --git a/arch/arm/boot/dts/rockchip/rv1126.dtsi b/arch/arm/boot/dts/rockchip/rv1126.dtsi >> index 6c5c928f06c7..cf1df75df418 100644 >> --- a/arch/arm/boot/dts/rockchip/rv1126.dtsi >> +++ b/arch/arm/boot/dts/rockchip/rv1126.dtsi >> @@ -21,6 +21,7 @@ / { >> >> aliases { >> i2c0 = &i2c0; >> + i2c2 = &i2c2; > No, this should be per-board to match board labeling/schematics. > I was just following what seemed to be done in some other Rockchip .dtsi files. I will move this alias and the other ones for serial and ethernet into the board file instead then. Regards   Tim > > Best regards, > Krzysztof >