public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: "Crystal Guo (郭晶)" <Crystal.Guo@mediatek.com>
To: "robh@kernel.org" <robh@kernel.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	"krzk@kernel.org" <krzk@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [v3,1/2] dt-bindings: memory-controllers: Add MediaTek DRAM controller interface
Date: Wed, 2 Apr 2025 03:51:41 +0000	[thread overview]
Message-ID: <4bad42c867a838da413154fa0a779547d642642c.camel@mediatek.com> (raw)
In-Reply-To: <fb154077-e650-480e-a4d7-0a141b563dfc@collabora.com>

On Wed, 2025-03-26 at 11:18 +0100, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Il 26/03/25 07:30, Crystal Guo ha scritto:
> > A MediaTek DRAM controller interface to provide the current DDR
> > data rate.
> > 
> > Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
> > ---
> >   .../memory-controllers/mediatek,dramc.yaml    | 44
> > +++++++++++++++++++
> >   1 file changed, 44 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/memory-
> > controllers/mediatek,dramc.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/memory-
> > controllers/mediatek,dramc.yaml
> > b/Documentation/devicetree/bindings/memory-
> > controllers/mediatek,dramc.yaml
> > new file mode 100644
> > index 000000000000..8bdacfc36cb5
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/memory-
> > controllers/mediatek,dramc.yaml
> 
> The filename should be "mediatek,mt8196-dramc.yaml"
> 

For other MediaTek SOCs, the method of calculating current ddr data
rate is similar to that of MT8196. After changing "mediatek,dramc.yaml"
to "mediatek,mt8196-dramc.yaml", would future Mediatek SOCs need to add
a separate yaml file again? or could they reuse mediatek,mt8196-
dramc.yaml? Thank you for your guidance.

Best regards,
Crystal

> 
> > @@ -0,0 +1,44 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +# Copyright (c) 2025 MediaTek Inc.
> > +%YAML 1.2
> > +---
> > +$id: 
> > https://urldefense.com/v3/__http://devicetree.org/schemas/memory-controllers/mediatek,dramc.yaml*__;Iw!!CTRNKA9wMg0ARbw!gH5hMTJ34ZcYfNMfLUNL-dH9SMyQGr06kJ4jij1anezByF7IBOSbkYNdqysgHoz-rSRNwM9r6RaaTC1MO2882ojif26oaBzg$
> > +$schema: 
> > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!gH5hMTJ34ZcYfNMfLUNL-dH9SMyQGr06kJ4jij1anezByF7IBOSbkYNdqysgHoz-rSRNwM9r6RaaTC1MO2882ojifw8f6sUH$
> > +
> > +title: MediaTek DRAM Controller (DRAMC)
> > +
> > +maintainers:
> > +  - Crystal Guo <crystal.guo@mediatek.com>
> > +
> > +description:
> > +  A MediaTek DRAM controller interface to provide the current data
> > rate of DRAM.
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - mediatek,mt8196-dramc
> 
> P.S.: bindings maintainers: this driver is expected to get more
> compatibles soon.
> 
> Cheers,
> Angelo
> 
> 
> > +
> > +  reg:
> > +    items:
> > +      - description: anaphy registers
> > +      - description: ddrphy registers
> > +
> > +additionalProperties: false
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +examples:
> > +  - |
> > +    soc {
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> > +
> > +        memory-controller@10236000 {
> > +            compatible = "mediatek,mt8196-dramc";
> > +            reg = <0 0x10236000 0 0x2000>,
> > +                  <0 0x10238000 0 0x2000>;
> > +        };
> > +    };
> 
> 

  reply	other threads:[~2025-04-02  3:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-26  6:30 [v3,0/2] Add an interface to get current DDR data rate Crystal Guo
2025-03-26  6:30 ` [v3,1/2] dt-bindings: memory-controllers: Add MediaTek DRAM controller interface Crystal Guo
2025-03-26  7:56   ` Krzysztof Kozlowski
2025-03-26 10:17     ` AngeloGioacchino Del Regno
2025-03-26 10:27       ` Krzysztof Kozlowski
2025-03-26 10:18   ` AngeloGioacchino Del Regno
2025-04-02  3:51     ` Crystal Guo (郭晶) [this message]
2025-04-02  9:24       ` AngeloGioacchino Del Regno
2025-03-26  6:30 ` [v3,2/2] memory/mediatek: Add an interface to get current DDR data rate Crystal Guo
2025-03-26 10:27   ` AngeloGioacchino Del Regno
2025-04-02  3:36     ` Crystal Guo (郭晶)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4bad42c867a838da413154fa0a779547d642642c.camel@mediatek.com \
    --to=crystal.guo@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox