From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8084C001B0 for ; Sat, 22 Jul 2023 09:37:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230191AbjGVJhB (ORCPT ); Sat, 22 Jul 2023 05:37:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230048AbjGVJgf (ORCPT ); Sat, 22 Jul 2023 05:36:35 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B326E3C32 for ; Sat, 22 Jul 2023 02:35:55 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-992f15c36fcso437971666b.3 for ; Sat, 22 Jul 2023 02:35:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690018531; x=1690623331; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mCIS2uTebsocjvDgAv2fQsB5I/jrohTaosOQPFj6fGk=; b=UYIQ093u+tNZP3ENIS84pw8eRjfe3BPmLcHuHH8yM7JniqpE0VdIl84EyFzDtW6ojs G6tG9n5jqUQyWud/NT6bBpFI66fEMLpNU1SXPgssJeMO+a1cd6FBiGGXPTVGdETRSjpw 9WrYblC4bEqk7c0X2sVKE26GAm1VcqbnPLvMt4Cqc9ptd1vv7kBOteJTgzZhiGju33UK 6UMvswsZpVwkeiRfsNtFXc7ahlrPzifSNCUzQYJS0+GHtvEJp6jKiXl5pALzC6im2T/A meSLNHEjV+qK0GGoY/fSSPH/U2zGjlEyi8hz1GF95374GEYkGDZSzIfpzVMVVwDQxMn0 W/Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690018531; x=1690623331; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mCIS2uTebsocjvDgAv2fQsB5I/jrohTaosOQPFj6fGk=; b=MxmUjaylS3/0im2RaSx1ecH5zNCJSNpSSNZSOgZy7DMmY9r5j/+WBIy8BUbabWubiG YP4eWhHxaYy7wkGbjW722a7Mcs1Etto1gaQju9qxfhmm9m6lia4/5sOyxt8wH8IuJky4 OThFM7AOL/ni73jGjE5d5FDKugZ9jRh6VQkGLy/Hem5JZF86rQcCKlwca+NauKgGHwJA Knov197xRFrgEDbdafKJyXhdECZ7gtBCMoY7hWN6RpQdTCesgZuov+Er41aZ6GNGLwyg US8gZIvrf9F9QtGxgtMPNitdtPVv/N7zUFG1FwaIeFmRVZ7NWC38y4Sjnoa/FbpPVQv9 /xvg== X-Gm-Message-State: ABy/qLbkdlT8mlhcBBgBEUoYCCFvStIcBM+SLcz9Z27EigJKVE5KeLko F6+E/1+FlJBw0Gr4BN4iGVIeDjdBYiOtmkpXMSc= X-Google-Smtp-Source: APBJJlH4IBRWY62H6Zuudk2bWPiFDp43Bc9QkHMhORCXbREh/tTDGLk+BMjOhhehABKyOOgOHx9HVA== X-Received: by 2002:a17:907:2715:b0:993:e691:6dd5 with SMTP id w21-20020a170907271500b00993e6916dd5mr3848491ejk.7.1690018531272; Sat, 22 Jul 2023 02:35:31 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id mc13-20020a170906eb4d00b00988c0c175c6sm3272997ejb.189.2023.07.22.02.35.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Jul 2023 02:35:30 -0700 (PDT) Message-ID: <4bb6c559-2bf4-3bcd-c154-60ec6dd2d58b@linaro.org> Date: Sat, 22 Jul 2023 11:35:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/7] dt-bindings: interconnect: qcom: Introduce qcom,rpm-common Content-Language: en-US To: Konrad Dybcio , Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo Cc: Marijn Suijten , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230721-topic-icc_bindings-v1-0-93e2bc728fb7@linaro.org> <20230721-topic-icc_bindings-v1-1-93e2bc728fb7@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230721-topic-icc_bindings-v1-1-93e2bc728fb7@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/07/2023 15:54, Konrad Dybcio wrote: > The current RPM interconnect bindings are messy. Start cleaning them > up with a common include. > > Signed-off-by: Konrad Dybcio > --- > .../bindings/interconnect/qcom,qcm2290.yaml | 12 +++------ > .../bindings/interconnect/qcom,rpm-common.yaml | 31 ++++++++++++++++++++++ > 2 files changed, 35 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,qcm2290.yaml b/Documentation/devicetree/bindings/interconnect/qcom,qcm2290.yaml > index f65a2fe846de..edee78c456b7 100644 > --- a/Documentation/devicetree/bindings/interconnect/qcom,qcm2290.yaml > +++ b/Documentation/devicetree/bindings/interconnect/qcom,qcm2290.yaml > @@ -13,19 +13,16 @@ description: | > The Qualcomm QCM2290 interconnect providers support adjusting the > bandwidth requirements between the various NoC fabrics. > > -properties: > - reg: > - maxItems: 1 > +allOf: > + - $ref: qcom,rpm-common.yaml# > > +properties: > compatible: > enum: > - qcom,qcm2290-bimc > - qcom,qcm2290-cnoc > - qcom,qcm2290-snoc > > - '#interconnect-cells': > - const: 1 > - > clock-names: > items: > - const: bus What about the children? Aren't they also rpm-common? > @@ -75,11 +72,10 @@ patternProperties: > required: > - compatible > - reg > - - '#interconnect-cells' > - clock-names > - clocks > > -additionalProperties: false > +unevaluatedProperties: false > > examples: > - | > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpm-common.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpm-common.yaml > new file mode 100644 > index 000000000000..87995b40a856 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpm-common.yaml > @@ -0,0 +1,31 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interconnect/qcom,rpm-common.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm RPMh Network-On-Chip Interconnect > + > +maintainers: > + - Konrad Dybcio > + > +description: > + RPM interconnect providers support for managing system bandwidth requirements > + through manual requests based on either predefined values or as indicated by > + the bus monitor hardware. Each provider node represents a NoC bus master, > + driven by a dedicated clock source. > + > +properties: > + reg: > + maxItems: 1 I would drop the reg from common parts because some of the children here don't use it. Best regards, Krzysztof