Re: [PATCH 2/2] misc: tc9564: introduce base PCI driver

[Alex Elder <elder@riscstar.com>]

On 8/14/26 2:31 AM, Arnd Bergmann wrote:
> On Fri, Aug 14, 2026, at 03:11, Greg KH wrote:
>> On Thu, Aug 13, 2026 at 05:29:42PM -0500, Alex Elder wrote:
>>> +#define DRIVER_NAME "tc9564-pci"
>>
>> What about just using KBUILD_MODNAME?
>>
>>> +static int
>>> +tc9564_function_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>>
>> But wow, this is a tiny driver, feels odd to have it in misc/ but ok, if
>> you think it should be here...
> 
> We have drivers/misc/rp1/ and drivers/misc/lan966x_pci*.c with similar
> functionality, so at least there is precedence for putting them here.

Yes, exactly.

>  From the old days, we still have drivers/mfd/sm501.c, drivers/mfd/cs5535-mfd.c,
> and a few others that open-code the on-chip components as mfd cels
> instead of using devicetree description.
> 
> At some point, we should think about grouping them into a separate
> subdirectory.

You mean for systems modeled with PCI endpoint bus, right?

If there is consensus that now is a good time to do that I
don't mind doing that work, but won't unless it's clearly
requested.

					-Alex
> 
>       Arnd