From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Heiko Stübner" <heiko@sntech.de>, "Johan Jonker" <jbx6244@gmail.com>
Cc: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] dt-bindings: clock: rk3188-cru-common: remove CLK_NR_CLKS
Date: Fri, 28 Jun 2024 10:22:53 +0200 [thread overview]
Message-ID: <4bd9a2da-6ac8-40b3-ad50-01ae53caeef0@kernel.org> (raw)
In-Reply-To: <2016066.NnIJQXNAa5@diego>
On 28/06/2024 10:13, Heiko Stübner wrote:
> Hi Krzysztof,
>
> Am Freitag, 28. Juni 2024, 09:27:14 CEST schrieb Krzysztof Kozlowski:
>> On 27/06/2024 23:17, Johan Jonker wrote:
>>> CLK_NR_CLKS should not be part of the binding.
>>> Remove since the kernel code no longer uses it.
>>
>> Please wrap neither too early nor over the limit. Not one sentence per line.
>>
>>
>>
>>>
>>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
>>> ---
>>> include/dt-bindings/clock/rk3188-cru-common.h | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>> diff --git a/include/dt-bindings/clock/rk3188-cru-common.h b/include/dt-bindings/clock/rk3188-cru-common.h
>>> index afad90680fce..01e14ab252a7 100644
>>> --- a/include/dt-bindings/clock/rk3188-cru-common.h
>>> +++ b/include/dt-bindings/clock/rk3188-cru-common.h
>>> @@ -132,8 +132,6 @@
>>> #define HCLK_VDPU 472
>>> #define HCLK_HDMI 473
>>>
>>> -#define CLK_NR_CLKS (HCLK_HDMI + 1)
>>
>> I still see it as being used in linux-next. Some explanation is missing.
>
> I think me applying Johan's patch [0] removing the constant's usage, simply
> overlapped with yesterday's next-creation.
>
These should be sent in one patchset, which makes it obvious. Splitting
does not help...
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-28 8:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 21:17 [PATCH v1] dt-bindings: clock: rk3188-cru-common: remove CLK_NR_CLKS Johan Jonker
2024-06-28 7:27 ` Krzysztof Kozlowski
2024-06-28 8:13 ` Heiko Stübner
2024-06-28 8:22 ` Krzysztof Kozlowski [this message]
2024-07-04 18:01 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bd9a2da-6ac8-40b3-ad50-01ae53caeef0@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).