From: "Rafał Miłecki" <zajec5@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: "Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Michael Walle" <michael@walle.cc>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, u-boot@lists.denx.de,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V3 1/6] nvmem: core: add nvmem_dev_size() helper
Date: Mon, 30 Jan 2023 13:34:50 +0100 [thread overview]
Message-ID: <4c1173f3-18e9-e46d-c50e-1febb90b426c@gmail.com> (raw)
In-Reply-To: <20230130115654.0041716d@xps-13>
On 30.01.2023 11:56, Miquel Raynal wrote:
> Hi Rafał,
>
> zajec5@gmail.com wrote on Fri, 27 Jan 2023 13:57:04 +0100:
>
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> This is required by layouts that need to read whole NVMEM space. It
>> applies to NVMEM devices without hardcoded layout (like U-Boot
>> environment data block).
>>
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>> ---
>> V2: Drop "const" from "const size_t"
>
> It would be good if you could always add a cover-letter, just so that
> we can reply to the whole series. In my case I wanted to add a global
>
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
>
> Because I gave this series a quick review and it looks good to me.
Good point, I'll keep that in mind and do that in future for all bigger
series.
Thank you.
prev parent reply other threads:[~2023-01-30 12:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 12:57 [PATCH V3 1/6] nvmem: core: add nvmem_dev_size() helper Rafał Miłecki
2023-01-27 12:57 ` [PATCH V3 2/6] nvmem: core: allow .read_post_process() callbacks to adjust buffer Rafał Miłecki
2023-01-27 12:57 ` [PATCH V3 3/6] dt-bindings: nvmem: convert U-Boot env vars to NVMEM layout Rafał Miłecki
2023-01-27 12:57 ` [PATCH V3 4/6] nvmem: u-boot-env: convert to layout driver Rafał Miłecki
2023-01-27 12:57 ` [PATCH V3 5/6] dt-bindings: nvmem: u-boot,env: add MAC's #nvmem-cell-cells Rafał Miłecki
2023-01-27 12:57 ` [PATCH V3 6/6] nvmem: u-boot-env: post process "ethaddr" env variable Rafał Miłecki
2023-01-30 10:56 ` [PATCH V3 1/6] nvmem: core: add nvmem_dev_size() helper Miquel Raynal
2023-01-30 12:34 ` Rafał Miłecki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c1173f3-18e9-e46d-c50e-1febb90b426c@gmail.com \
--to=zajec5@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).