From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Steev Klimaszewski <steev@kali.org>
Subject: Re: [RFT PATCH] arm64: dts: qcom: sdm850-c630: add missing panel supply
Date: Mon, 19 Jun 2023 15:16:06 +0200 [thread overview]
Message-ID: <4c71208b-5621-2495-a5de-3622a44d05d4@linaro.org> (raw)
In-Reply-To: <20230617171512.286795-1-krzysztof.kozlowski@linaro.org>
On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> Panel bindings (boe,nv133fhm-n61) require supply which here actually can
> be turned on/off via GPIO control:
>
> sdm850-lenovo-yoga-c630.dtb: panel: 'power-supply' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Not tested on hardware
> ---
+Steev
Konrad
> .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> index cfbc4fc1eba9..3d871567cf81 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> @@ -87,6 +87,25 @@ sn65dsi86_refclk: sn65dsi86-refclk {
> clock-frequency = <19200000>;
> };
>
> + vph_pwr: regulator-vph-pwr {
> + compatible = "regulator-fixed";
> + regulator-name = "vph_pwr";
> + regulator-min-microvolt = <3700000>;
> + regulator-max-microvolt = <3700000>;
> + };
> +
> + vlcm_3v3: regulator-vlcm-3v3 {
> + compatible = "regulator-fixed";
> + regulator-name = "vlcm_3v3";
> +
> + vin-supply = <&vph_pwr>;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> +
> + gpio = <&tlmm 88 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> backlight: backlight {
> compatible = "pwm-backlight";
> pwms = <&sn65dsi86 1000000>;
> @@ -419,6 +438,7 @@ aux-bus {
> panel: panel {
> compatible = "boe,nv133fhm-n61";
> backlight = <&backlight>;
> + power-supply = <&vlcm_3v3>;
>
> port {
> panel_in_edp: endpoint {
next prev parent reply other threads:[~2023-06-19 13:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-17 17:15 [RFT PATCH] arm64: dts: qcom: sdm850-c630: add missing panel supply Krzysztof Kozlowski
2023-06-19 13:16 ` Konrad Dybcio [this message]
2023-06-19 14:11 ` Steev Klimaszewski
2023-06-24 14:56 ` Caleb Connolly
2023-06-26 9:47 ` Konrad Dybcio
2023-07-14 5:48 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c71208b-5621-2495-a5de-3622a44d05d4@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=steev@kali.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).