From: Jakob Hauser <jahau@rocketmail.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Lee Jones <lee@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Beomho Seo <beomho.seo@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Stephan Gerhold <stephan@gerhold.net>,
Raymond Hackley <raymondhackley@protonmail.com>,
Pavel Machek <pavel@ucw.cz>, Axel Lin <axel.lin@ingics.com>,
ChiYuan Huang <cy_huang@richtek.com>,
Linus Walleij <linus.walleij@linaro.org>,
Henrik Grimler <henrik@grimler.se>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v4 5/8] power: supply: rt5033_charger: Add RT5033 charger device driver
Date: Mon, 8 May 2023 22:27:34 +0200 [thread overview]
Message-ID: <4c99e915-b067-367d-bdbe-095b7f244aa4@rocketmail.com> (raw)
In-Reply-To: <20230508065014.xfftu6vorxgqdh7h@mercury.elektranox.org>
Hi Sebastian,
On 08.05.23 08:50, Sebastian Reichel wrote:
> Hi,
>
> On Sat, May 06, 2023 at 05:54:32PM +0200, Jakob Hauser wrote:
>> This patch adds device driver of Richtek RT5033 PMIC. The driver supports
>> switching charger. rt5033 charger provides three charging modes. The charging
>> modes are pre-charge mode, fast charge mode and constant voltage mode. They
>> vary in charge rate, the charge parameters can be controlled by i2c interface.
>>
>> Cc: Beomho Seo <beomho.seo@samsung.com>
>> Cc: Chanwoo Choi <cw00.choi@samsung.com>
>> Tested-by: Raymond Hackley <raymondhackley@protonmail.com>
>> Signed-off-by: Jakob Hauser <jahau@rocketmail.com>
>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>> ---
>
> Driver looks mostly good. I still found a couple of small things
> though. Please find them inline.
...
The change requests look reasonable. Thanks for additional hints. I'll
implement them in v5.
Kind regards,
Jakob
next prev parent reply other threads:[~2023-05-08 20:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230506155435.3005-1-jahau.ref@rocketmail.com>
2023-05-06 15:54 ` [PATCH v4 0/8] Add RT5033 charger device driver Jakob Hauser
2023-05-06 15:54 ` [PATCH v4 1/8] mfd: rt5033: Drop rt5033-battery sub-device Jakob Hauser
2023-05-06 15:54 ` [PATCH v4 2/8] mfd: rt5033: Fix chip revision readout Jakob Hauser
2023-05-06 15:54 ` [PATCH v4 3/8] mfd: rt5033: Fix STAT_MASK, HZ_MASK and AICR defines Jakob Hauser
2023-05-06 15:54 ` [PATCH v4 4/8] mfd: rt5033: Apply preparatory changes before adding rt5033-charger driver Jakob Hauser
2023-05-06 15:54 ` [PATCH v4 5/8] power: supply: rt5033_charger: Add RT5033 charger device driver Jakob Hauser
2023-05-08 6:50 ` Sebastian Reichel
2023-05-08 20:27 ` Jakob Hauser [this message]
2023-05-06 15:54 ` [PATCH v4 6/8] power: supply: rt5033_charger: Add cable detection and USB OTG supply Jakob Hauser
2023-05-08 11:43 ` Sebastian Reichel
2023-05-08 20:36 ` Jakob Hauser
2023-05-06 15:54 ` [PATCH v4 7/8] power: supply: rt5033_battery: Adopt status property from charger Jakob Hauser
2023-05-08 11:35 ` Sebastian Reichel
2023-05-08 21:18 ` Jakob Hauser
2023-05-08 22:06 ` Sebastian Reichel
2023-05-09 1:01 ` Jakob Hauser
2023-05-09 7:25 ` Sebastian Reichel
2023-05-09 23:00 ` Jakob Hauser
2023-05-06 15:54 ` [PATCH v4 8/8] dt-bindings: Add rt5033 mfd, regulator and charger Jakob Hauser
2023-05-09 9:18 ` Krzysztof Kozlowski
2023-05-09 23:08 ` Jakob Hauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c99e915-b067-367d-bdbe-095b7f244aa4@rocketmail.com \
--to=jahau@rocketmail.com \
--cc=axel.lin@ingics.com \
--cc=beomho.seo@samsung.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=henrik@grimler.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=phone-devel@vger.kernel.org \
--cc=raymondhackley@protonmail.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=stephan@gerhold.net \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).