From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 611EDC4332F for ; Mon, 23 May 2022 10:16:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233994AbiEWKQo (ORCPT ); Mon, 23 May 2022 06:16:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234000AbiEWKQn (ORCPT ); Mon, 23 May 2022 06:16:43 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E42217A97 for ; Mon, 23 May 2022 03:16:42 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id br17so12415466lfb.2 for ; Mon, 23 May 2022 03:16:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=j8uqO6uQ4ZVj6x5j3Kl+olRHxX/AM+5LdyICh38VHXE=; b=fC9+RpjMk78CzVqFkNwOUai6bcQM0Tesa/wSc2z0nc1VHyYbtwAA/YK9QMSEOKDPgH kdXs5N30fwwWeaLGky3V1M3nn9x2Ews948w5x3UcGetJJiK8MivYnNKOx4gk/7k24//X GVYiJOhGnGqQqp07xLC1ZIU8lJ43U5kGttsu8NMt9uY7gxl0MR+zTmdNtkIsb4Z53WtN Wvykrz9XD+zOTuuMVsayJ5j/mLr+hjNXLik8B+6POPxntfLso+wNK4aqEb47lbQmtCOx Z+nGxbcapTHTjd0+MWxZ4k12vkIV56W2+Ir0XckPrFqWDstrJE52AZZbXUWaN8KEPrvK lfHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=j8uqO6uQ4ZVj6x5j3Kl+olRHxX/AM+5LdyICh38VHXE=; b=INMuL3jzHffWPkApo7JT7/lL0YCfPKeY7qjeJ5q2OPyxdWj4ZlnNGxTt4i29cClKgy zFzo/oyhhCELAju7C4Nfx2Chvv3sGHpqUgahiLXrwZP2sB5UGYpJW4cwwCvKBa7z1EdG zoHGn/HxRi+xaIQenCVmM8pHwdHkHMQlhmz1jFakXbcZ9NnVHF0LjGZ1hVsavgPtmqLB eOqFGTNla+9Kbv2rVbov0v/yib0QuRhRWPfESpslUnD77lNNA26VlpjdPfDQgJXUd5G8 LmoBpoRwxD1jHM9UIJ2sXmCsFfV9epcawYQYH59cZchWE+xRgi5tVxFxWl8C2fx+/vGJ 59HQ== X-Gm-Message-State: AOAM5314XffIp6r5z04/9uwLK+kJ6q9knr1XBLpPcOC4NMmOiGvalRls ICdpothXaRCpFLpWDp0V1ycX5Q== X-Google-Smtp-Source: ABdhPJxv2fNPrFHFEbYevTCh7ab2jEDuHx62613siI3C1Md983g45XmCnzx8iSep9cpN92v3xEeFzw== X-Received: by 2002:a05:6512:6cc:b0:478:6e03:964b with SMTP id u12-20020a05651206cc00b004786e03964bmr3550540lff.283.1653301000478; Mon, 23 May 2022 03:16:40 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id n3-20020ac242c3000000b0047255d211e8sm1898666lfl.279.2022.05.23.03.16.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 May 2022 03:16:40 -0700 (PDT) Message-ID: <4cbbd4c2-6d39-da8e-d0fc-c49ba9b8ae7d@linaro.org> Date: Mon, 23 May 2022 12:16:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 1/3] dt-bindings: iio: adc: Add FSD-HW variant Content-Language: en-US To: Tamseel Shams , jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org, krzk+dt@kernel.org Cc: geert@linux-m68k.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, alim.akhtar@samsung.com, paul@crapouillou.net, linux-fsd@tesla.com References: <20220520145820.67667-1-m.shams@samsung.com> <20220520145820.67667-2-m.shams@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220520145820.67667-2-m.shams@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/05/2022 16:58, Tamseel Shams wrote: > From: Alim Akhtar > > This patch adds a new compatible string for FSD-HW's > ADC variant > > Signed-off-by: Alim Akhtar > Signed-off-by: Tamseel Shams > --- > - Changes since v1 > * Addressed Krzysztof's comment to use soc-specific compatible > > .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > index 81c87295912c..ded0e3f85991 100644 > --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > @@ -14,6 +14,7 @@ properties: > enum: > - samsung,exynos-adc-v1 # Exynos5250 > - samsung,exynos-adc-v2 > + - samsung,exynos-adc-fsd-hw The soc is fsd, so compatible should rather be: tesla,fsd-adc What does the "HW" mean? > - samsung,exynos3250-adc > - samsung,exynos4212-adc # Exynos4212 and Exynos4412 > - samsung,exynos7-adc Best regards, Krzysztof