From: "Rafał Miłecki" <rafal@milecki.pl>
To: "Arınç ÜNAL" <arinc.unal@arinc9.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Hauke Mehrtens <hauke@hauke-m.de>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH 4/5] ARM: dts: BCM5301X: Retrieve gmac1 MAC address from NVRAM on Asus RT-AC88U
Date: Fri, 01 Apr 2022 12:32:37 +0200 [thread overview]
Message-ID: <4cd234fd46673ec935eec09129853b47@milecki.pl> (raw)
In-Reply-To: <20220401102002.15765-4-arinc.unal@arinc9.com>
On 2022-04-01 12:20, Arınç ÜNAL wrote:
> The et1macaddr NVRAM variable contains a MAC address for gmac1 on Asus
> RT-AC88U. Add NVMEM cell for it and reference it in the gmac1 node.
>
> The Broadcom GBit BCMA driver will issue the MAC address for
> gmac{0,1,2}
> retrieved from et{0,1,2}mac from SPROM without this but let's
> explicitly
> define it as mac-address on the devicetree.
> Refer to drivers/net/ethernet/broadcom/bgmac-bcma.c:147.
It doesn't matter how Linux handles that in details. You're working on
hardware binding.
Change is OK of course.
If you need to reference sth it should be
Documentation/devicetree/bindings/net/ethernet-controller.yaml
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
I'd drop bgmac-bcma.c reference but nevertheless:
Acked-by: Rafał Miłecki <rafal@milecki.pl>
next prev parent reply other threads:[~2022-04-01 11:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 10:19 [PATCH 1/5] ARM: dts: BCM5301X: Fix DTC warning for NAND node Arınç ÜNAL
2022-04-01 10:19 ` [PATCH 2/5] ARM: dts: BCM5301X: Remove cell properties from srab ports on Asus RT-AC88U Arınç ÜNAL
2022-04-01 10:28 ` Rafał Miłecki
2022-04-04 18:35 ` Florian Fainelli
2022-04-01 10:20 ` [PATCH 3/5] ARM: dts: BCM5301X: Add rgmii to port@5 of Broadcom switch " Arınç ÜNAL
2022-04-04 18:36 ` Florian Fainelli
2022-04-01 10:20 ` [PATCH 4/5] ARM: dts: BCM5301X: Retrieve gmac1 MAC address from NVRAM " Arınç ÜNAL
2022-04-01 10:32 ` Rafał Miłecki [this message]
2022-04-04 18:36 ` Florian Fainelli
2022-04-01 10:20 ` [PATCH 5/5] ARM: dts: BCM5301X: Disable unused gmac0 and gmac2 " Arınç ÜNAL
2022-04-01 10:40 ` Rafał Miłecki
2022-04-01 11:36 ` Arınç ÜNAL
2022-04-06 18:16 ` Florian Fainelli
2022-04-10 9:20 ` Arınç ÜNAL
2022-04-01 10:27 ` [PATCH 1/5] ARM: dts: BCM5301X: Fix DTC warning for NAND node Rafał Miłecki
2022-04-04 18:35 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cd234fd46673ec935eec09129853b47@milecki.pl \
--to=rafal@milecki.pl \
--cc=arinc.unal@arinc9.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).