From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 453D4C28CBC for ; Wed, 6 May 2020 21:25:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 198E92075A for ; Wed, 6 May 2020 21:25:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729444AbgEFVZq (ORCPT ); Wed, 6 May 2020 17:25:46 -0400 Received: from smtprelay0034.hostedemail.com ([216.40.44.34]:54658 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729152AbgEFVZq (ORCPT ); Wed, 6 May 2020 17:25:46 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 264B918025396; Wed, 6 May 2020 21:25:45 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: ice18_31e3e67744b3e X-Filterd-Recvd-Size: 2298 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf04.hostedemail.com (Postfix) with ESMTPA; Wed, 6 May 2020 21:25:42 +0000 (UTC) Message-ID: <4cdeaa2af2fe0d6cc2ca8ce3a37608340799df8a.camel@perches.com> Subject: Re: [PATCH v3 2/6] pstore/platform: Pass max_reason to kmesg dump From: Joe Perches To: Kees Cook , Pavel Tatashin Cc: Anton Vorontsov , Colin Cross , Tony Luck , Jonathan Corbet , Rob Herring , Benson Leung , Enric Balletbo i Serra , Petr Mladek , Sergey Senozhatsky , Steven Rostedt , jmorris@namei.org, sashal@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Date: Wed, 06 May 2020 14:25:41 -0700 In-Reply-To: <20200506211523.15077-3-keescook@chromium.org> References: <20200506211523.15077-1-keescook@chromium.org> <20200506211523.15077-3-keescook@chromium.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 2020-05-06 at 14:15 -0700, Kees Cook wrote: > From: Pavel Tatashin > > Add a new member to struct pstore_info for passing information about > kmesg dump maximum reason. This allows a finer control of what kmesg > dumps are sent to pstore storage backends. trivia: > diff --git a/include/linux/pstore.h b/include/linux/pstore.h [] > @@ -96,6 +96,12 @@ struct pstore_record { > * > * @read_mutex: serializes @open, @read, @close, and @erase callbacks > * @flags: bitfield of frontends the backend can accept writes for > + * @max_reason: Used when PSTORE_FLAGS_DMESG is set. Contains the > + * kmsg_dump_reason enum value. KMSG_DUMP_UNDEF means > + * "use existing kmsg_dump() filtering, based on the > + * printk.always_kmsg_dump boot param" (which is either > + * KMSG_DUMP_OOPS when false, or KMSG_DUMP_MAX when > + * tree); see printk.always_kmsg_dump for more details. s/tree/true/