From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A62BFC00140 for ; Fri, 12 Aug 2022 12:04:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237726AbiHLMEt (ORCPT ); Fri, 12 Aug 2022 08:04:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231302AbiHLMEs (ORCPT ); Fri, 12 Aug 2022 08:04:48 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B200AF0CF for ; Fri, 12 Aug 2022 05:04:47 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id o2so1083675lfb.1 for ; Fri, 12 Aug 2022 05:04:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=6Kp8Yta0WaKZAcq5lDGwXYhuy7Bp52cXQEeMVR/1+WI=; b=e0NTS05OhsARZawCS+Q9V5QJklC7TFmJvLAbC9/1Rjz6b9TNijx7oX6q1vyROu9TGa L0GarXzM939iDPY+j88jTWrXvpr9+jisqiOo01vBWL1rq457Qd3WlrD8H1S4k/iyc/KW 8m6xzKOXbjIKqyrTLY8QI+2M8TRkN0S3NV+UvwHCa5I1GSdFXUD6MMrkpWz65uVrwObF PA3IZWAZB1iE5H7/JTu5WF383hEt5cRcvSZhQ8ip1G17tF0MhvQBe4pXSF7jqPU2bbaT EydDQkwel042igDTE9+/sVIgg700h2ooG4BGxWR50lm/Q3fqPMW0/zKODvwTJB4/cqXZ m9Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=6Kp8Yta0WaKZAcq5lDGwXYhuy7Bp52cXQEeMVR/1+WI=; b=qFoCWHv8kBeq7e7XPdcEhUYvrleGDG+XkovxrhQCaXbKs/aTR6ENfk/1HTeXYNeJcY HlCwl7cyZyKV3zoFylzUVDauXQWXNiCJKqO/DXBWj2rXXuOI0Zfv5gY+OiglhGWc3vXs aSaSVwUR9QAlGi7EOaPOtWonl12tuL+7Xl5koWSqWAFqnm74ImilaEiXDyj++oUTtc0e ADe0GUBBdzYzWaxkZPsx5Jexh/+rDQINyivvX8KGAXzl2G+HGctmQMsXccuWV1DYqsph OY2D4FLj86mV2GHaXhpXAAk3AykE6W+MU9GnU1IBi07W0xjhr56ZKxa5ADHrsUuVT5JN +omw== X-Gm-Message-State: ACgBeo3BGEaGaYqmkT0dxZl8RjVUbU0hDC4c4B7GETop9gJpSU99XOCd rIUfmPVg7l2ssFVQVJW4AGkvCg== X-Google-Smtp-Source: AA6agR4sqXxxKi4mb3+0CFJc4qCyD4xvAMcIyGUn9NI4/7Ff/JuoW8K5vFDg7SS1M6jSetsvVHzWQQ== X-Received: by 2002:a05:6512:401b:b0:48b:32f5:de20 with SMTP id br27-20020a056512401b00b0048b32f5de20mr1268909lfb.33.1660305885359; Fri, 12 Aug 2022 05:04:45 -0700 (PDT) Received: from [192.168.1.39] ([83.146.140.105]) by smtp.gmail.com with ESMTPSA id r3-20020a2e8e23000000b0025e60089f34sm333216ljk.52.2022.08.12.05.04.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Aug 2022 05:04:44 -0700 (PDT) Message-ID: <4cf8d73e-9f14-fe8d-d6e2-551920c1f29e@linaro.org> Date: Fri, 12 Aug 2022 15:04:41 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH net 1/2] dt: ar803x: Document disable-hibernation property Content-Language: en-US To: "Russell King (Oracle)" Cc: Wei Fang , "andrew@lunn.ch" , "hkallweit1@gmail.com" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "f.fainelli@gmail.com" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20220812145009.1229094-1-wei.fang@nxp.com> <20220812145009.1229094-2-wei.fang@nxp.com> <0cd22a17-3171-b572-65fb-e9d3def60133@linaro.org> <14cf568e-d7ee-886e-5122-69b2e58b8717@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/08/2022 14:36, Russell King (Oracle) wrote: > On Fri, Aug 12, 2022 at 02:25:42PM +0300, Krzysztof Kozlowski wrote: >> hibernation is a feature, but 'disable-hibernation' is not. DTS >> describes the hardware, not policy or driver bejhvior. Why disabling >> hibernation is a property of hardware? How you described, it's not, >> therefore either property is not for DT or it has to be phrased >> correctly to describe the hardware. > > However, older DT descriptions need to be compatible with later kernels, > and as existing setups have hibernation enabled, introducing a property > to _enable_ hibernation (which implies if the property is not present, > hibernation is disabled) changes the behaviour with older DT, thereby > breaking backwards compatibility. > > Yes, DT needs to describe hardware, but there are also other > constraints too. I did not propose a property to enable hibernation. The property must describe hardware, so this piece is missing, regardless whether the logic in the driver is "enable" or "disable". The hardware property for example is: "broken foo, so hibernation should be disabled" or "engineer forgot to wire cables, so hibernation won't work"... Best regards, Krzysztof