From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C51C6C64E7B for ; Tue, 1 Dec 2020 12:57:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63CEA207FF for ; Tue, 1 Dec 2020 12:57:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GBU61fFc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726988AbgLAM5h (ORCPT ); Tue, 1 Dec 2020 07:57:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727116AbgLAM5h (ORCPT ); Tue, 1 Dec 2020 07:57:37 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EFD0C061A48 for ; Tue, 1 Dec 2020 04:56:49 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id o1so2464176wrx.7 for ; Tue, 01 Dec 2020 04:56:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=fhSdydiNHIuE7kH/VZv5LNrrxvRIALi9bCyYo0cAOQ0=; b=GBU61fFcIfgXME5qVa36xFJVFJmb5+EHsvpQuu7GUNrca+sC99MVJa5L3eXYGY/ue6 vdeiDP5CstZt8slf4x3ydVOXINeGZElSS0q8mbuRJvo6Oqwe3F/cohI9+8Dctlke5zAs iBJHA+WM/dzYl8ENXWS1nAFYIlYtk9O8bO7h/hv1Gg8OJbrpYerXmC11DJn2tcMn60JM R0LUj26CsIy4MI6mFnbb5TJS7rlRV/CJ0eE8mqt7lXv9PQKD+LghHjpWccgBryN6KDJ1 QqgwV6HnY3qwDzziY9sCwy8lwtq8pK7Xz55e2dVFbR/or3HpVdiqom+tOB5TDbf1QNKB GMTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fhSdydiNHIuE7kH/VZv5LNrrxvRIALi9bCyYo0cAOQ0=; b=igqwXKdv5LBMpoBQWlFQqdioXmexnMSsnL23n3bl3mQr3Zozv6b50PKMb9tJ1OWqW+ QM5HJDlX15+ChvFB5I4xO5JigNm7hkeBDU6D7Zo/RiT1T8QVtsR+YDVj2hE8ASn3K/XG QARhENerVwSpMdFtWUZQbHEXK1PxzCw1hBT3MFZzrRmbWXTobawVArXGqj+DyktgAh3k +6X3jkj8K5Q3uFsiwK7YkuWpNYAOePrZyS3rQEM1k3PXkHQqH0Jj7oRhP57WQtqJAN4+ kSMdbrOU3EHWF2jkrvn6MiXQrTIB9U52vtY0cfb6o23uHEyfEg8CHkaMD7x8K0jdamg2 pfWA== X-Gm-Message-State: AOAM532xag3dq/pkvwAAiWN/WWYiXDVWOPvUhNDxZ5RzEzeSbxnUDluR zdS5HihGiL/C8AuMq3sH5q025g== X-Google-Smtp-Source: ABdhPJzQ1k3k98QkgMHXg5Y+DER3dcc331ppnIuJxF97i7TDGLT/iMqZRO5mfpwO6uJSzeSvhQu5ow== X-Received: by 2002:a5d:4e87:: with SMTP id e7mr3887518wru.70.1606827408027; Tue, 01 Dec 2020 04:56:48 -0800 (PST) Received: from MacBook-Pro.local ([212.45.64.13]) by smtp.googlemail.com with ESMTPSA id t136sm2859898wmt.18.2020.12.01.04.56.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Dec 2020 04:56:47 -0800 (PST) Subject: Re: [PATCH v2 1/7] arm64: dts: imx8m: Add NOC nodes To: Martin Kepplinger , robh@kernel.org, shawnguo@kernel.org, festevam@gmail.com, catalin.marinas@arm.com, will@kernel.org, cdleonard@gmail.com Cc: kernel@pengutronix.de, linux-imx@nxp.com, kernel@puri.sm, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Leonard Crestez References: <20201201123932.12312-1-martin.kepplinger@puri.sm> <20201201123932.12312-2-martin.kepplinger@puri.sm> From: Georgi Djakov Message-ID: <4d089936-65fe-8601-73e7-0424d363b6f2@linaro.org> Date: Tue, 1 Dec 2020 14:56:46 +0200 MIME-Version: 1.0 In-Reply-To: <20201201123932.12312-2-martin.kepplinger@puri.sm> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Martin, Thank you for sending the patches. On 1.12.20 14:39, Martin Kepplinger wrote: > From: Leonard Crestez > > Add initial support for dynamic frequency scaling of main NOC. > > Make DDRC the parent of the NOC (using passive governor) so that the > main NOC is automatically scaled together with DDRC by default. > > Support for proactive scaling via interconnect will come on top. > > Signed-off-by: Leonard Crestez > Tested-by: Martin Kepplinger (imx8mq) As you are sending this, i believe that it should have your signed-off line (please check Documentation/process/submitting-patches.rst). Also please give people some time to look into this (at least 1-2 weeks) before submitting a new version. Thanks, Georgi > --- > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 22 ++++++++++++++++++++++ > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 22 ++++++++++++++++++++++ > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++++++++++++++++++++++ > 3 files changed, 66 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > index c824f2615fe8..835b19f0ea42 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > @@ -921,6 +921,28 @@ > > }; > > + noc: interconnect@32700000 { > + compatible = "fsl,imx8mm-noc", "fsl,imx8m-noc"; > + reg = <0x32700000 0x100000>; > + clocks = <&clk IMX8MM_CLK_NOC>; > + devfreq = <&ddrc>; > + operating-points-v2 = <&noc_opp_table>; > + > + noc_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + opp-150M { > + opp-hz = /bits/ 64 <150000000>; > + }; > + opp-375M { > + opp-hz = /bits/ 64 <375000000>; > + }; > + opp-750M { > + opp-hz = /bits/ 64 <750000000>; > + }; > + }; > + }; > + > aips4: bus@32c00000 { > compatible = "fsl,aips-bus", "simple-bus"; > reg = <0x32c00000 0x400000>; > diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > index a06d2a6268e6..8e2d413f97d4 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > @@ -772,6 +772,28 @@ > > }; > > + noc: interconnect@32700000 { > + compatible = "fsl,imx8mn-noc", "fsl,imx8m-noc"; > + reg = <0x32700000 0x100000>; > + clocks = <&clk IMX8MN_CLK_NOC>; > + devfreq = <&ddrc>; > + operating-points-v2 = <&noc_opp_table>; > + > + noc_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + opp-100M { > + opp-hz = /bits/ 64 <100000000>; > + }; > + opp-600M { > + opp-hz = /bits/ 64 <600000000>; > + }; > + opp-800M { > + opp-hz = /bits/ 64 <800000000>; > + }; > + }; > + }; > + > aips4: bus@32c00000 { > compatible = "fsl,aips-bus", "simple-bus"; > reg = <0x32c00000 0x400000>; > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index a841a023e8e0..d139a46ee8ce 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -1158,6 +1158,28 @@ > }; > }; > > + noc: interconnect@32700000 { > + compatible = "fsl,imx8mq-noc", "fsl,imx8m-noc"; > + reg = <0x32700000 0x100000>; > + clocks = <&clk IMX8MQ_CLK_NOC>; > + devfreq = <&ddrc>; > + operating-points-v2 = <&noc_opp_table>; > + > + noc_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + opp-133M { > + opp-hz = /bits/ 64 <133333333>; > + }; > + opp-400M { > + opp-hz = /bits/ 64 <400000000>; > + }; > + opp-800M { > + opp-hz = /bits/ 64 <800000000>; > + }; > + }; > + }; > + > bus@32c00000 { /* AIPS4 */ > compatible = "fsl,aips-bus", "simple-bus"; > reg = <0x32c00000 0x400000>; >