From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E531C04A95 for ; Wed, 28 Sep 2022 17:30:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234166AbiI1RaU (ORCPT ); Wed, 28 Sep 2022 13:30:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234185AbiI1RaQ (ORCPT ); Wed, 28 Sep 2022 13:30:16 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82036101E1; Wed, 28 Sep 2022 10:30:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3D84AB82188; Wed, 28 Sep 2022 17:30:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14B36C433D6; Wed, 28 Sep 2022 17:30:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664386212; bh=had18nHIWk58wHIEUYBL8s5bf2zGuGtjvjtrM+XgU3w=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=U2/i9hdRC3qmwAnSJroV7/p49fAgUfqa7khD2K5Q3FIUcrAmvI09JOibqi1GavBBF kqWr+vDGhmw8PW8aZZ3WKFnal2tBrZcxr05Plg+ptFQcd5AO+iN6cYGXGgaUxdItzt nToszzQtaBkj3S1B6bMRNIb8CeNT0+Dob4cutWIpdztQeoVNKiQn/tYvD8Lmx9+I8/ ZnkcPGlfpaQd7swcJ361l+PMspA1dzv6REkk2+gzGKtGo0UnnMCtLm1RRvjuzvXjTc K1VOWpUC6oJgB3uczF7k1DN5bqjYpcN7EuMG/vr7YiOTy2ZoNJLsg+HKRu5v5YQVCt vWy2sSAWMkDYg== Message-ID: <4d0f7a01-1995-1b1e-40b9-125c3447b8c7@kernel.org> Date: Wed, 28 Sep 2022 19:30:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH V14 1/7] dt-bindings: Added the yaml bindings for DCC Content-Language: en-US To: Souradeep Chowdhury , Andy Gross , Bjorn Andersson , Rob Herring , Alex Elder Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Sai Prakash Ranjan , Sibi Sankar , Rajendra Nayak , vkoul@kernel.org References: From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/09/2022 19:11, Souradeep Chowdhury wrote: > Documentation for Data Capture and Compare(DCC) device tree bindings > in yaml format. > > Signed-off-by: Souradeep Chowdhury > Reviewed-by: Rob Herring > Reviewed-by: Bjorn Andersson I asked last time and there was just partial improvement, so let me be clear: you must rebase on latest kernel and use scripts/get_maintainers.pl. I am repeating myself, which should not be actually needed... but then maybe my comment was not accurate? If so, please post the output of `git describe` and `scripts/get_maintainers.pl __on_your_patches__` and let's go line by line... > --- > .../devicetree/bindings/soc/qcom/qcom,dcc.yaml | 44 ++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,dcc.yaml > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,dcc.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,dcc.yaml > new file mode 100644 > index 0000000..8396b0c > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,dcc.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/msm/qcom,dcc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Data Capture and Compare > + > +maintainers: > + - Souradeep Chowdhury > + > +description: | > + DCC (Data Capture and Compare) is a DMA engine which is used to save > + configuration data or system memory contents during catastrophic failure > + or SW trigger. DCC is used to capture and store data for debugging purpose > + > +properties: > + compatible: > + items: > + - enum: > + - qcom,sm8150-dcc > + - qcom,sc7280-dcc > + - qcom,sc7180-dcc > + - qcom,sdm845-dcc > + - const: qcom,dcc > + > + reg: > + items: > + - description: DCC base register region > + - description: DCC RAM base register region > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + dma@10a2000{ > + compatible = "qcom,sm8150-dcc","qcom,dcc"; odd indentation. Use 4 spaces for example indentation. > + reg = <0x010a2000 0x1000>, > + <0x010ad000 0x2000>; > + }; Best regards, Krzysztof