public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sirat <email@sirat.me>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
	andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/2] dt-bindings: iio: proximity: add ST VL53L1X ToF sensor
Date: Wed, 25 Mar 2026 09:57:56 +0100	[thread overview]
Message-ID: <4d10b6c0-d599-4fc5-b9ed-ce669ac46e84@kernel.org> (raw)
In-Reply-To: <CANn+LW+Y6j0xk2x02-BUL9qNq2gf-PXspi4wP_KGd7Abz3hOYw@mail.gmail.com>

On 25/03/2026 09:48, Sirat wrote:
> On Wed, Mar 25, 2026 at 2:05 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On Wed, Mar 25, 2026 at 12:32:22PM +0600, Siratul Islam wrote:
>>> Add device tree binding documentation for the STMicroelectronics
>>> VL53L1X Time-of-Flight ranging sensor connected via I2C.
>>>
>>> Make vdd-supply required. The device requires power to operate
>>> and the property should have been required from the start.
>>
>> That's ABI break and device for many years was working fine, so this
>> should not be changed.
>>
> Jonathan and David asked that vdd-supply be made required. I feel like
> there is a conflict here that I am not able to resolve myself.
> 
> What I think about it is the binding does not correctly describe the
> hardware and we should consider this a bug and fix it.
> The driver worked because of a fallback mechanism (dummy/fake
> regulator) and not because power was optional.
> 


I looked at v6 and v5 and I do not see such comment for binding that
existing device should change ABI. Can you point me to it?

Best regards,
Krzysztof

  reply	other threads:[~2026-03-25  8:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25  6:32 [PATCH v7 0/2] iio: proximity: add driver for ST VL53L1X ToF sensor Siratul Islam
2026-03-25  6:32 ` [PATCH v7 1/2] dt-bindings: iio: proximity: add " Siratul Islam
2026-03-25  8:05   ` Krzysztof Kozlowski
2026-03-25  8:48     ` Sirat
2026-03-25  8:57       ` Krzysztof Kozlowski [this message]
2026-03-25  9:18         ` Sirat
2026-03-25 13:38           ` Jonathan Cameron
2026-03-25 13:44             ` Krzysztof Kozlowski
2026-03-25 14:06               ` Jonathan Cameron
2026-03-25 14:38                 ` Sirat
2026-03-25 15:01                   ` Jonathan Cameron
2026-03-25  6:32 ` [PATCH v7 2/2] iio: proximity: add driver for " Siratul Islam
2026-03-25 14:47   ` Jonathan Cameron
2026-03-25 16:33     ` Sirat
2026-03-25 19:47       ` Jonathan Cameron
2026-03-26  9:14     ` Andy Shevchenko
2026-03-25  7:55 ` [PATCH v7 0/2] " Krzysztof Kozlowski
2026-03-25  8:23   ` Sirat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d10b6c0-d599-4fc5-b9ed-ce669ac46e84@kernel.org \
    --to=krzk@kernel.org \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=email@sirat.me \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox