From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B1AF3932F2 for ; Sun, 24 May 2026 13:07:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779628031; cv=none; b=CuSB/H8XMNLMadAkH2rLizr+2JJLyk6SN3BFmqrZ1qtnfYf4JiwHg6HS7f/80kan+x2jzb/ksF/4yQCfODqj0VGq2TZrxx7axkM7aex2vkZVmR89CMw7ojQGNmLKWlEMOvuyhHcnPaTOnbqRiugw/9E4BxeRpPMqFKx1yMNQxKA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779628031; c=relaxed/simple; bh=CGu9itIYUblNfG+RLcHmeNDouaMDmZ+0SgVnDgTcO2M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ByTPELPj603y7hrgJVk8F7hKYTVABJXFue9wGTaiIilTjpvf1HVJqiom0nPH+HHrSuuDhhjVsVzpeolmDUG1B3yT17qjdJQ6b1DUwQSbwJXd3b1lwIgfl+xhWh3HIRIaWRDEh7hKUJGL2W+wEbvqqrWMlAspSjj2S75vcBf4vy4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AvQIgkBJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PnhAnTId; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AvQIgkBJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PnhAnTId" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64NMo6hp3079108 for ; Sun, 24 May 2026 13:07:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3rFnaq83VGMEew0lXNYSC0puW4n7VbyCoCWMnn4QSJc=; b=AvQIgkBJDUbU9bCZ PXfr/RMex/vPBtgPdIQzG0N79vOXB90r6lDJxBErmLHekenl52svqRCyW2z6yXeU MDiIgQmzI0oehTAao3UZ/RFY5mdrwDbmzKAMmizUfgem980ZwxUUQqMhbCfID0bz 0cWzKJkDCkABLH/3Zk2jG/DcRHG8LczF9j47rRH05z4zHaGAiJHy+RuURY98hWAN 9lBQ8MysUrfTNo1y90mSkGcR4I3Im+6Mlv1Tlmox/XJ6A09pIWcud6BP7PdL+/gZ Cg9iTQEe4GDoMYf9SVM5E86Ico5IwYQx432dzMW5vDsW1Yib/38Ia15cvgl4lZ5u K5HIAw== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eb88w2pv7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 24 May 2026 13:07:09 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c8531d89e59so444073a12.0 for ; Sun, 24 May 2026 06:07:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779628029; x=1780232829; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3rFnaq83VGMEew0lXNYSC0puW4n7VbyCoCWMnn4QSJc=; b=PnhAnTIdFAhwtnARoxb9quUmbprI1/4Xd4braU2ay+LFzy6/r1M2rgSpLz8EAK1jcq lvvdVb6/P+/RCMnp3GJ9pqYX0289bvoueK3oDVLkZnh7FyrZP13C5hsi1dCFE3LGMOBS d0mHZ3FDTHPO6Qsy7uJ6NpA+L6ewWWFPKgGfTn2LvRVsVNiMZT0TGC6f/WmQnkzMimc0 W1f1ZKAuzYHFlNZXK37PImaBSQnMCOSSFpV8x+GLD5cRa2C0UfuuoUBFOFbW527nqSE9 NRiZ44IwrvLjK5bnv0Nd3I6Yu0Oq8OaCeGIGTpQveRZKmx+3WDWnE553zLtmZkMiPOr2 Mtlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779628029; x=1780232829; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3rFnaq83VGMEew0lXNYSC0puW4n7VbyCoCWMnn4QSJc=; b=pC58biEK7f/67uHYThRS7UArYZp9GlFWlhlw0cCkcTmQU//sDWEBj7kzHSwZngBtN/ iOJE7sVS2s6ik0ppwmo2qaNh15CtotvicMCn0MrIZWgkWLPOptmpeWUFL09T6uQEcp9K HHWFpd7VzaiKTtA/r9OMyMwRcABKaee4cRz7VR/bZJ73lT6OvRNrmsB6dt6mCi4JBWGA 6gOE3oNFenTcpEQ9zZDx0mt5xVa8xj2Y/J0eNXjDa6JDZx0nSo84wzNj25OeGS3QdeYz uImLmxQOSKSLBqkpiwtuo4Len+HGL46dniZyb6RzQe8gVoAg+Q+v73VcDj5G1TDuG3HC vUPw== X-Forwarded-Encrypted: i=1; AFNElJ9ef9Uy5e5klDIyMcH3kWxX5s1WazL59KrxFz77Ark+rLgxIroYns/9Na8Na/J4hGh1ITqI4irrgIjY@vger.kernel.org X-Gm-Message-State: AOJu0YxLNax/vIwuvPOaRfDEhC7aYwqEqUp2YdtkJ7y7VuYAmNDJ6h/l SMqinl9Rm1kBlRSuTnr7az+NyPDDHGA3QQuA5byGam0OkVojy9bUuVLaqMYEZLCo/jz5fdhwwap JJ4E8EhKq2dYKFbyn+MvJB8S/Hnzi2QEjgI2o7G3LGGL1v1Bgzf9KcTcrCgidPxaW X-Gm-Gg: Acq92OH5aabOWawroWcaBj5i2twl64khA1YoALqHsrnJWFfEGy2uojYUAS+TeZADTRv AM1HlNnff9cEuZgvqLH/yddIp97HhPBdzxayr07KvgTLAKs0aG48sqfdO5MA1mu32tiSTen8thd mmQC22j9isGh4mAqrsxTLqiFlg/paoKpfubqrJHdZnicoKHFDsAHy9FDBEQzvuYxc9FHF04KNXD 5eaU+gWnnM6EcwygeFkvEI30dNeExrQTvY4a39syPG7gnbW6UKsserUHYqSu6vCFwDXC0XfqOZr tTcYeDydngdjFpMgyZgZLFDPZJ3ub1qWQvYx8a0930RIOuYKH4g2CxUEJUXXFuxbJcxjUiBCeL2 qKYqWOKlU2HCfjsD+/RoaWkVAonw9eCp30B4MGP5JMDGwQTKLzaO1 X-Received: by 2002:a05:6a20:7485:b0:39b:8571:3051 with SMTP id adf61e73a8af0-3b307f420e2mr13083769637.28.1779628028658; Sun, 24 May 2026 06:07:08 -0700 (PDT) X-Received: by 2002:a05:6a20:7485:b0:39b:8571:3051 with SMTP id adf61e73a8af0-3b307f420e2mr13083731637.28.1779628027923; Sun, 24 May 2026 06:07:07 -0700 (PDT) Received: from [192.168.29.166] ([49.43.232.251]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c852028fecbsm5631720a12.1.2026.05.24.06.07.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 May 2026 06:07:07 -0700 (PDT) Message-ID: <4d10e792-5d47-4c39-a054-37588ef7fd6f@oss.qualcomm.com> Date: Sun, 24 May 2026 18:37:01 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/5] arm64: dts: qcom: Add Shikra EVK boards To: sashiko-reviews@lists.linux.dev Cc: vkoul@kernel.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, conor+dt@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com, robh@kernel.org References: <20260522-shikra-dt-v3-5-80ffde8a3dc4@oss.qualcomm.com> <20260522193943.660811F000E9@smtp.kernel.org> Content-Language: en-US From: Komal Bajaj In-Reply-To: <20260522193943.660811F000E9@smtp.kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=S/jpBosP c=1 sm=1 tr=0 ts=6a12f7fd cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=XawOCIWsnnDrxziW7imd2g==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=rmuw6e2lUgWHCeyTDCgA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI0MDEzMyBTYWx0ZWRfX9hK6uwxkjyve zMAw4CexzG7Bhe8UJbyZQQKLh1Fel9n78NISRKJu3LnF2yfNPo0LoaU1LAG/LPsJbmozTF8gbUX hWqRyBLtiKLKQcqCGyBKOLmYSHoatgRXz7W/O943q0WDk80uYi3IAO6aYNvdjEG6IKKpA1dcL6f j1H8EumhDvTqeXJWAVMhR4toNYbYxzIx76ph6fvtRhlEh8+UdrAs6doNqbMPX+i+NJqFrvhM0Qw PlGPShr9UY0RxpjDBoJn9pyxO8B+xkGDZuuoSEK9wqvIPCqZVKJ/Ggc3cihJwTVOqGQ0NcEzuKI 2/NAoi3yxbSh/wEFVM41l+JaCuVrYbgrFY6SmxuX2pBRjmWl89n0G8bH9QTP/gBGdCZ126tb3bE Reibd4FbnJpNONKotpAZsQb+0GDhlSogn0d9ZwRCvEolsGN5d+5XnXz0yZWf4/w35TxFkllwgvS RwGybUKUXjqkm+d0ezA== X-Proofpoint-ORIG-GUID: QOsPCdQ-xnlopOahAaCraPiCySUnJnSO X-Proofpoint-GUID: QOsPCdQ-xnlopOahAaCraPiCySUnJnSO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-24_04,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 impostorscore=0 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605240133 On 5/23/2026 1:09 AM, sashiko-bot@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [High] The device tree file shikra-cqs-evk.dts incorrectly includes the CQM SoM device tree (shikra-cqm-som.dtsi) instead of the expected CQS SoM device tree (shikra-cqs-som.dtsi). > -- > > commit cb9ff9c76f4ee019113138237f57794fa621d71f > Author: Komal Bajaj > > arm64: dts: qcom: Add Shikra EVK boards > > This commit adds device trees for the Shikra EVK platform, combining > Shikra SoM variants with a common carrier board. It introduces three EVK > boards: CQM (retail with modem), CQS (retail without modem), and IQS > (industrial without modem). > > [ ... ] > >> diff --git a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts >> new file mode 100644 >> index 0000000000000..b3f19a64d7aed >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts >> @@ -0,0 +1,40 @@ >> +// SPDX-License-Identifier: BSD-3-Clause >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + */ >> + >> +/dts-v1/; >> + >> +#include "shikra-cqm-som.dtsi" > [Severity: High] > The commit message states that shikra-cqs-evk.dts pairs with the CQ2390S > SoM (retail, without modem). Does this file include the incorrect SoM dtsi? > > Including shikra-cqm-som.dtsi here seems like it would pull in the hardware > description of the modem-enabled CQM SoM instead of the expected CQS variant. > > Could this cause boot issues or lead to loading drivers for hardware that > isn't actually present on the CQS board? Already discussed, refer: https://lore.kernel.org/all/4787d5f9-601a-4d27-91d3-33216ee6f64d@oss.qualcomm.com/ Thanks Komal > >> +#include "shikra-evk.dtsi" >> + >> +/ { >> + model = "Qualcomm Technologies, Inc. Shikra CQS EVK"; >> + compatible = "qcom,shikra-cqs-evk", "qcom,shikra-cqs-som", "qcom,shikra"; > [ ... ] >