From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Cc: linux-media@vger.kernel.org, linux-acpi@vger.kernel.org,
devicetree@vger.kernel.org, laurent.pinchart@ideasonboard.com,
hverkuil@xs4all.nl
Subject: Re: [PATCH v3 5/7] docs-rst: media: Sort topic list alphabetically
Date: Tue, 6 Jun 2017 23:57:55 +0300 [thread overview]
Message-ID: <4d1b8a9a-af82-c72d-3554-f1844d5a5b08@linux.intel.com> (raw)
In-Reply-To: <20170606094834.0152cd6f@vento.lan>
Hi Mauro,
Mauro Carvalho Chehab wrote:
> Em Mon, 10 Apr 2017 16:02:54 +0300
> Sakari Ailus <sakari.ailus@linux.intel.com> escreveu:
>
>> Bring some order by alphabetically ordering the list of topics.
>>
>> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>> ---
>> Documentation/media/kapi/v4l2-core.rst | 18 +++++++++---------
>> 1 file changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/Documentation/media/kapi/v4l2-core.rst b/Documentation/media/kapi/v4l2-core.rst
>> index d8f6c46..2fbf532 100644
>> --- a/Documentation/media/kapi/v4l2-core.rst
>> +++ b/Documentation/media/kapi/v4l2-core.rst
>> @@ -4,23 +4,23 @@ Video4Linux devices
>> .. toctree::
>> :maxdepth: 1
>>
>> - v4l2-intro
>
> NACK.
>
> The order of the documentation should match what makes sense for the
> user that will be reading the docs, and *not* an alphabetical order.
I wrote the patch to address some of the review comments I got over the
several versions of the patchset. I have no objections to maintaining
the current order.
>
> I didn't check what order you did, but for sure the introduction should
> come first, and then the stuff that all drivers use, like
> v4l2-dev, v4l2-device and v4l2-fh. Then, other stuff that it is part of
> the framework but are used only by a subset of the drivers.
>
> That's said, it probably makes sense to use multiple toctrees here, and
> add some description before each of them, in order to better organize
> its contents. Something similar to what it was done with
> Documentation/admin-guide/index.rst
>
> I'll rebase patch 6/7 to not depend on this one.
Thanks!
--
Regards,
Sakari Ailus
sakari.ailus@linux.intel.com
next prev parent reply other threads:[~2017-06-06 20:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 13:02 [PATCH v3 0/7] V4L2 fwnode support Sakari Ailus
2017-04-10 13:02 ` [PATCH v3 1/7] v4l: fwnode: Support generic fwnode for parsing standardised properties Sakari Ailus
2017-04-10 13:02 ` [PATCH v3 2/7] v4l: async: Add fwnode match support Sakari Ailus
2017-04-10 13:02 ` [PATCH v3 3/7] v4l: flash led class: Use fwnode_handle instead of device_node in init Sakari Ailus
2017-04-10 13:02 ` [PATCH v3 4/7] v4l: Switch from V4L2 OF not V4L2 fwnode API Sakari Ailus
2017-04-25 11:56 ` [PATCH v3.1 " Sakari Ailus
2017-04-25 11:58 ` [PATCH v3 " Sakari Ailus
2017-05-04 13:43 ` [PATCH v3.1 " Philipp Zabel
2017-05-04 22:02 ` [PATCH v3.2 " Sakari Ailus
[not found] ` <1491829376-14791-1-git-send-email-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-04-10 13:02 ` [PATCH v3 5/7] docs-rst: media: Sort topic list alphabetically Sakari Ailus
2017-06-06 12:48 ` Mauro Carvalho Chehab
2017-06-06 20:57 ` Sakari Ailus [this message]
2017-06-07 9:54 ` Mauro Carvalho Chehab
2017-04-10 13:02 ` [PATCH v3 6/7] docs-rst: media: Switch documentation to V4L2 fwnode API Sakari Ailus
2017-04-10 13:02 ` [PATCH v3 7/7] v4l: Remove V4L2 OF framework in favour of V4L2 fwnode framework Sakari Ailus
2017-04-25 8:51 ` [PATCH v3 0/7] V4L2 fwnode support Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d1b8a9a-af82-c72d-3554-f1844d5a5b08@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@s-opensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).