From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3DE323817E; Wed, 12 Mar 2025 09:49:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741772966; cv=none; b=lMw9zchi8xAh6m9WnaHs5djiuRq76TbMd8ImUEib7Q3bGgfJQTt78PT1Bg5Kbdm6tCr2WGhLH6CFTmgx8cOVEWNxJMH/16gNoaBeDN8VghIEAjNbZ644/4tOP2ZqlnsK7Xj4jAYRKTxchdFFBfFyWJ2DPsabb0YysMUCsnaC4Dg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741772966; c=relaxed/simple; bh=9vq5WqopeqFaRAC/QXK6vUpcgfTx1+VCb/Pwcfhdc0M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HrTgiIIubgwjFaL0FawDzCZmv+KX4NofeUbEV0ZJnLluK63KMXByNuDBgVWUofpvsD5Q0qnWHGHF6gCkKvwCseM9GfoeSIjWMazXz2GBhAnNJHUSNf87n4BA/G8alnKiKbUNy13M9efyg4FxYY6IxFVci3iwY+4mH9D2x1cVke4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iLgeLtI4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iLgeLtI4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1EC1C4CEED; Wed, 12 Mar 2025 09:49:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741772966; bh=9vq5WqopeqFaRAC/QXK6vUpcgfTx1+VCb/Pwcfhdc0M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iLgeLtI4m9YUXYkCb/kDvDE0qto/8QZaluBm6RwkgrkI5iXqEuczAMUaSH8b7+qaW 0yZ3eZj6jlRjMo2qoY2vAi/ya+16Jxqml9NIMm7QwdT25Fi5oWKfxCRB9tbtlwJi7l 5EqP2orT7mOtsQL+v42TKTL0YSSAydo1+NJfJowqoikWmUeBNjJy33Yc2yLNwm6uZU L8TfgoDxQ0rmRy4j0KczGfL3nRy46S6Dg3qFwltR9DADsNtpL187lZpwOTNQ/anpzE C+83xeEVT39FQs6/8+x7T2Y4/q3EL0lFcZ8uCiSqYOqWmEFlxlVSeNNYFffl46bveN 6WoYL0eiuMa3w== Message-ID: <4d1c3eb1-5c42-490f-83e5-60de05ffad06@kernel.org> Date: Wed, 12 Mar 2025 10:49:19 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/2] dt-bindings: power: supply: Document Maxim MAX8971 charger To: Svyatoslav Ryhel , Rob Herring Cc: Sebastian Reichel , Krzysztof Kozlowski , Conor Dooley , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250310080237.7400-1-clamor95@gmail.com> <20250310080237.7400-2-clamor95@gmail.com> <20250311193732.GA4183071-robh@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/03/2025 07:02, Svyatoslav Ryhel wrote: >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + interrupts: >>> + maxItems: 1 >>> + >>> + monitored-battery: true >>> + >>> + maxim,usb-connector: >> >> Just 'connector', so when we have a 3rd case, we don't have a 3rd >> vendor. >> > > Please, please be explicit and specific, you could not tell me this in git grep -C 3 connector: > v3, you could but you decided to fuck up v4 as well. So wise. We got a lot to review thus we make reviews concise. I understand that it might lead to insufficient guidance, so more help in removing workload from maintainers is always appreciated. Instead of using vulgar words towards us, please put a bit more effort and look at other recent bindings how they do it. Review is provided in good faith and if it is by any chance incorrect, it is enough to disagree instead of throwing things like above. That's not acceptable. > Additionally, if you want a generic 'connector' which can be > referenced as 'connector: true' then add one, ATM this is classified > under your own terms as 'vendor property' and needs a vendor prefix. richtek,usb-connector is not the good example here. Your previous code here: https://lore.kernel.org/all/20250225090014.59067-2-clamor95@gmail.com/ looks correct - you have there port. So where does charger_input point? > >>> + description: >>> + Phandle to a USB connector according to usb-connector.yaml. The connector >>> + should be a child of the extcon device. >> >> 'extcon' is a Linuxism. Is there an actual requirement here that's not >> *current* Linux requirements (which could change)? I assume the >> requirement is to have vbus or some supply? >> > > Pardon me, this schema is part of Linux kernel, no? I have no clue why Bindings are used by other projects as well and they live here because of possibility of review by skilled people and due to size of the community. It does not make them, in general, Linux specific. > you collectively decided to just ignore external connector detection > devices. Ignorance does not affect the fact that such devices exist. We didn't. They are described. > > And no, it does not need vbus not supply, it needs EXTCON There is no such thing as "extcon" from hardware point of view. Point us to any standard or even wikipedia article describing it. Best regards, Krzysztof