Re: [PATCH 1/2] iio: light: veml3328: add devicetree binding for new sensor

[Krzysztof Kozlowski <krzk@kernel.org>]

On 16/05/2026 23:50, Joshua Crofts wrote:
> Add devicetree binding for the Vishay VEML3328 RGB/IR light sensor
> connected via I2C (SMBus compatible).

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

And then:
drop second/last, redundant "devicetree binding for new". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

> 
> Additionally, add an entry in MAINTAINERS.

Drop, no need to describe what you did. We see that in the diff.

> 
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
> ---

...


> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        light-sensor@10 {
> +            compatible = "vishay,veml3328";
> +            reg = <0x10>;
> +            vdd-supply = <&vcc_3v3>;
> +        };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d6c3c7d22403..134690aa9866 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -28386,6 +28386,12 @@ S:	Maintained
>  F:	Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml
>  F:	drivers/iio/light/veml3235.c
>  
> +VISHAY VEML3328 RGB IR LIGHT SENSOR DRIVER
> +M:	Joshua Crofts <joshua.crofts1@gmail.com>
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/iio/light/vishay,veml3328.yaml
> +F:	drivers/iio/light/veml3328.c

There is no such file at this point.


Best regards,
Krzysztof