From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE96CC433FE for ; Wed, 23 Nov 2022 13:22:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238728AbiKWNWu (ORCPT ); Wed, 23 Nov 2022 08:22:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238611AbiKWNWY (ORCPT ); Wed, 23 Nov 2022 08:22:24 -0500 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82A6F6162 for ; Wed, 23 Nov 2022 05:01:34 -0800 (PST) Received: by mail-lj1-x231.google.com with SMTP id x21so21249314ljg.10 for ; Wed, 23 Nov 2022 05:01:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Rp9LQRHK4UZG+xUfLLMwYJtuh3wPrpxN6Fnd2UjWdQg=; b=YqKW4WZ12w3737HpIKaIbSfRqSmPKWir3XDrW/zdqOV9JGrfgldRSUQjiOR4mpwLZL CO+CHVIHt2qkz75r4PuT1YifKI/ufwNk5CLMVXDEnjYh7zYOibvXOFRLqK+eOY4JqvRa eylk3gfX+g7syMCZg6KdhAncldUPL6p8UKHWvE8a+SpBROLKURnbhyQ76keSjsPLxvFr euPLS7vpgu8v9MlgyjPLinBvTgoSYUbjCGPFxWH5zBqhxO9NI3+MV1+oW06cV5+DmYTU 2Wxron4/P1HDYbINnL2S67EKIlSDaeuH8ldHoqSH2es4ghAFTlCTrCpmNhgR2wRM3yw0 WEWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Rp9LQRHK4UZG+xUfLLMwYJtuh3wPrpxN6Fnd2UjWdQg=; b=sS/7ftY3B1NxrHozqVxOJuBNp+0dArXOWEJlaXAC5RuwfTggMWBH+E7MoA8ZJAHmHd ePUmy2WP82d4o0U0eNoxFkWAjv/dto8ypYiOPEjUV7uq9OVj+jh5oERzS1j91eAoqumH 5ns5Zfqr3pEbXEFJQCGyA8QK14xD0QUxJqcK7w7SagemeGQ6LXkiAuTv8rD5xOBjfM3u KpZA0La22lH4SaRgLvNTAPZPkkq/lmFddNibCpuOW5zZjkEuHoxlG9TI9AISYFMzWvMI NWRJ+ZJN0edvPbb6fqrxaVKxshpgSa7dKOdyc9XiX1BdQ8a+YehYkH/f/n9oXVL6qihK BPtg== X-Gm-Message-State: ANoB5plujPCBLyRAYIFrlB5XV5HO/TXVL6lDE1JcLMirnA0TlPPU4cxq qiw7r47MWDYHuIk4m5uQyVgEXA== X-Google-Smtp-Source: AA0mqf5DGm4ZvktT4NR9WyAWpPuHSnlNUVoErSOEdsb9pP81a5SYi+qylXXNjUQBbNtecR/QIXyT/g== X-Received: by 2002:a2e:a90b:0:b0:277:794:ae09 with SMTP id j11-20020a2ea90b000000b002770794ae09mr8806647ljq.286.1669208492340; Wed, 23 Nov 2022 05:01:32 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id p7-20020a2eb987000000b002796fb63dbdsm534480ljp.13.2022.11.23.05.01.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Nov 2022 05:01:31 -0800 (PST) Message-ID: <4d62d7e9-5454-4d1c-b3bb-4ba1fd7a31d6@linaro.org> Date: Wed, 23 Nov 2022 14:01:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v5] dt-bindings: iio: adc: ad7923: adjust documentation Content-Language: en-US To: Edmund Berenson Cc: Lukasz Zemla , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221122161437.18937-1-edmund.berenson@emlix.com> <20221123113224.5vxs2zmxf7z2bmvm@emlix.com> From: Krzysztof Kozlowski In-Reply-To: <20221123113224.5vxs2zmxf7z2bmvm@emlix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23/11/2022 12:32, Edmund Berenson wrote: > On Wed, Nov 23, 2022 at 11:42:40AM +0100, Krzysztof Kozlowski wrote: >> On 22/11/2022 17:14, Edmund Berenson wrote: >>> - The ad7927 is fully compatible with ad7928 driver, add >>> documentation for device. >>> - ad7923 and ad7924 are treated the same in the driver, show >>> the relationship in the documentation. >>> >>> Suggested-by: Lukasz Zemla >>> Signed-off-by: Edmund Berenson >>> --- >>> .../bindings/iio/adc/adi,ad7923.yaml | 26 ++++++++++++------- >>> 1 file changed, 17 insertions(+), 9 deletions(-) >>> >> >> 1. This is a v5, what are the changes? >> > The original idea was adding the compatible string into driver itself, > then it was suggested that I have a fallback compatible to 7928 as the > hardware versions are treated the same in the driver. After that it was > suggested to add deprecated flag to standalone compatibility, but doing > so I didn't want to add compatibility on driver side just to mark it > deprecated in the documentation, so I dropped driver side changes. > Finally I had some issues getting the documentation syntax into an > acceptable form, mainly const vs enum listing of compatibility stings. That's a bit too long for a changelog. Keep it short but still descriptive. Anyway - this must be in the changelog place, so after --- Best regards, Krzysztof