From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D122C7EE22 for ; Thu, 4 May 2023 16:22:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229505AbjEDQWL (ORCPT ); Thu, 4 May 2023 12:22:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229739AbjEDQWK (ORCPT ); Thu, 4 May 2023 12:22:10 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C00F63AA7 for ; Thu, 4 May 2023 09:22:07 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2ac826a1572so4195301fa.0 for ; Thu, 04 May 2023 09:22:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683217326; x=1685809326; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y0//78+uXYFr6PUUQe4KmtdkJ/mFw3NuDFvW5FcRoZQ=; b=b2PPRS393qwzfXujkfb1itL3HU4nmRZ2GeFjtSbxbb4B5LWfmP2u/7SUg3VP6ZfnId JuSqBYz9XknIcLBR5BSO2b+0duwUwM6ypEiA3aRpz5wbdWz9R1ricHxiKK4T2KEmbbEY ok27nLjU0jqjlBkP5hxLkRSPXDJeJgFdP4Trcaecy4XbcnrZfB+3zH2CavTN2tAw+Pon 8iFEHWgBI3j0XanI+EcsXcaFZlZ2hf5NiG47XY6zSAJ1wqtVBW58mT+QrBuWKw5dLsrY YloQuSMGfNajcySaziY/1qubxqI6oztOMv4Iw0Ue8pZEt89v6IbF4iQeFhe5uL+NYcYO T9TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683217326; x=1685809326; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y0//78+uXYFr6PUUQe4KmtdkJ/mFw3NuDFvW5FcRoZQ=; b=WS/SkZsaNerjEhdvidLLY87T/PO19RjqvJg9NdclTpXWnHmTciGwK4Rhjszm+0fM5i Ht0XJc0CIxhzhaNJIqkLKz8TiEo4sBKREwzN5a1vw4O0AwXAGHAPlzVTzW1V3ixNeHwU gXJgYWx240S9eRPB9RFJkDr0EGSkeUyGRLN7kf1YyJutrAelTbPWqoInj9hRorYPDw4C hs+iIQ5Z6mfQRtj6lCZy4u8PM2uuEHELTL9BX8N5GuIadt+SLn56cwoVn2kXV+rr6ddY li+7p7TLLtuUuWzJHycz+Ten6p+2J5lFiybrNGUsxEOzrJj4rJjGLqs1zYEl+51jSmD6 W7rw== X-Gm-Message-State: AC+VfDzSlYm7tk7CrB97QncQa/K+6e7EOk8R2Ojuk756PuTfDbxA9ppP PKlC7IIU7F/MxfhITgvHaW1vLQ== X-Google-Smtp-Source: ACHHUZ7nzyVmwttPurr+ePQF0cmLpk+IMorprUHkikxMLmIjeifJSsAylHxffCQRQTHoMTrpLLc5bA== X-Received: by 2002:a2e:a30b:0:b0:2aa:af16:5c55 with SMTP id l11-20020a2ea30b000000b002aaaf165c55mr1105267lje.44.1683217326048; Thu, 04 May 2023 09:22:06 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id p16-20020a2e8050000000b002a8c409f1f5sm6658915ljg.110.2023.05.04.09.22.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 May 2023 09:22:05 -0700 (PDT) Message-ID: <4d6568cd-3678-f3ec-36b3-0b4b474d9871@linaro.org> Date: Thu, 4 May 2023 19:22:05 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH V4 1/3] dt-bindings: sram: qcom,imem: Add Boot Stat region within IMEM Content-Language: en-GB To: Krzysztof Kozlowski , Caleb Connolly , Souradeep Chowdhury , Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , Bjorn Andersson , Rob Herring Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Sibi Sankar , Rajendra Nayak References: <9da030c6-6a9f-6766-7120-94aaa8fcd8ab@linaro.org> <3ef818c8-1ee4-5bee-6b37-20658b2e4637@linaro.org> From: Dmitry Baryshkov In-Reply-To: <3ef818c8-1ee4-5bee-6b37-20658b2e4637@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 04/05/2023 09:26, Krzysztof Kozlowski wrote: > On 04/05/2023 00:10, Caleb Connolly wrote: >> >> >> On 17/04/2023 16:08, Souradeep Chowdhury wrote: >>> All Qualcomm bootloaders log useful timestamp information related >>> to bootloader stats in the IMEM region. Add the child node within >>> IMEM for the boot stat region containing register address and >>> compatible string. >>> >>> Signed-off-by: Souradeep Chowdhury >>> --- >>> .../devicetree/bindings/sram/qcom,imem.yaml | 22 ++++++++++++++++++++++ >>> 1 file changed, 22 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml >>> index ba694ce..d028bed 100644 >>> --- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml >>> +++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml >>> @@ -49,6 +49,28 @@ patternProperties: >>> $ref: /schemas/remoteproc/qcom,pil-info.yaml# >>> description: Peripheral image loader relocation region >>> >>> + "^stats@[0-9a-f]+$": >>> + type: object >>> + description: >>> + Imem region dedicated for storing timestamps related >>> + information regarding bootstats. >>> + >>> + additionalProperties: false >>> + >>> + properties: >>> + compatible: >>> + items: >>> + - enum: >>> + - qcom,sm8450-bootstats >> >> This region isn't exclusive to sm8450, it exists also on sdm845 and >> presumably other platforms. Is there any need for an SoC specific >> compatible? > > Yes. > https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42 > > Also see many discussions on LKML about this. I checked the closest relative: qcom_stats.c driver. It defines several platform-specific overrides and also a generic "qcom,rpm-stats" / "qcom,rpmh-stats" drivers. -- With best wishes Dmitry