Re: [PATCH v2 2/2] drm/panel: simple: add NEC NL6448BC33-70C

[Neil Armstrong <neil.armstrong@linaro.org>]

On 5/15/26 13:46, Steffen Trumtrar wrote:
> Add NEC NL6448BC33-70C 10.4" 640x480 LCD module support.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>   drivers/gpu/drm/panel/panel-simple.c | 29 +++++++++++++++++++++++++++++
>   1 file changed, 29 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 236bd56208ccf..dca6cbc41bd9f 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -3659,6 +3659,32 @@ static const struct panel_desc nec_nl4827hc19_05b = {
>   	.bus_flags = DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
>   };
>   
> +static const struct drm_display_mode nec_nl6448bc33_70c_mode = {
> +	.clock = 25175,
> +	.hdisplay = 640,
> +	.hsync_start = 640 + 16,
> +	.hsync_end = 640 + 16 + 48,
> +	.htotal = 640 + 16 + 48 + 96,
> +	.vdisplay = 480,
> +	.vsync_start = 480 + 2,
> +	.vsync_end = 480 + 2 + 31,
> +	.vtotal = 480 + 2 + 31 + 31,
> +	.flags = DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_PHSYNC,
> +};
> +
> +static const struct panel_desc nec_nl6448bc33_70c = {
> +	.modes = &nec_nl6448bc33_70c_mode,
> +	.num_modes = 1,
> +	.bpc = 6,
> +	.size = {
> +		.width = 211,
> +		.height = 158,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> +	.bus_flags = DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
> +	.connector_type = DRM_MODE_CONNECTOR_LVDS,
> +};
> +
>   static const struct drm_display_mode netron_dy_e231732_mode = {
>   	.clock = 66000,
>   	.hdisplay = 1024,
> @@ -5520,6 +5546,9 @@ static const struct of_device_id platform_of_match[] = {
>   	}, {
>   		.compatible = "nec,nl4827hc19-05b",
>   		.data = &nec_nl4827hc19_05b,
> +	}, {
> +		.compatible = "nec,nl6448bc33-70c",
> +		.data = &nec_nl6448bc33_70c,
>   	}, {
>   		.compatible = "netron-dy,e231732",
>   		.data = &netron_dy_e231732,
> 

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil