Re: [PATCH V2 3/5] Add aw9610x series related interfaces to the aw_sar driver.

[Krzysztof Kozlowski <krzk@kernel.org>]

On 05/06/2024 11:11, wangshuaijie@awinic.com wrote:
> From: shuaijie wang <wangshuaijie@awinic.com>
> 

No commit msg, no proper subject prefix.

> Signed-off-by: shuaijie wang <wangshuaijie@awinic.com>
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> | Reported-by: Dan Carpenter <error27@gmail.com>

Drop all these, this is some bogus tags. Tag never starts with pipe, btw.

> ---
>  drivers/input/misc/aw_sar/aw9610x/aw9610x.c | 884 ++++++++++++++++++++
>  drivers/input/misc/aw_sar/aw9610x/aw9610x.h | 327 ++++++++
>  2 files changed, 1211 insertions(+)
>  create mode 100644 drivers/input/misc/aw_sar/aw9610x/aw9610x.c
>  create mode 100644 drivers/input/misc/aw_sar/aw9610x/aw9610x.h

...

> +struct aw_reg_data {
> +	unsigned char rw;
> +	unsigned short reg;
> +};
> +/********************************************
> + * Register Access
> + *******************************************/
> +#define REG_NONE_ACCESS					(0)
> +#define REG_RD_ACCESS					(1 << 0)
> +#define REG_WR_ACCESS					(1 << 1)
> +
> +static const struct aw_reg_data g_aw9610x_reg_access[] = {

Ehh... so we are at basics of C. Data structures do not go to headers.


Best regards,
Krzysztof