devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Rob Herring <robh@kernel.org>
Cc: dri-devel@lists.freedesktop.org, robert.foss@linaro.org,
	Jagan Teki <jagan@amarulasolutions.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: display: bridge: icn6211: Add support for RGB/BGR swap
Date: Tue, 2 Aug 2022 13:33:14 +0200	[thread overview]
Message-ID: <4d917546-23a2-a33a-1f59-ec78305aa854@denx.de> (raw)
In-Reply-To: <20220801163238.GA1130127-robh@kernel.org>

On 8/1/22 18:32, Rob Herring wrote:
> On Mon, Aug 01, 2022 at 03:19:00PM +0200, Marek Vasut wrote:
>> The ICN6211 is capable of swapping the output DPI RGB/BGR color channels,
>> document a DT property to select this swap in DT. This can be useful on
>> hardware where such swap happens.
> 
> We should ensure this series[1] works for you instead.

[...]

> Rob
> 
> [1] https://lore.kernel.org/r/20220628181838.2031-3-max.oss.09@gmail.com

I'm still not convinced that we should encode this pixel format value 
directly into the DT instead of trying to describe the DPI bus color 
channel width/order/shift in the DT instead. I think I mentioned that 
before in one of the previous versions of that series.

  reply	other threads:[~2022-08-02 11:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-01 13:19 [PATCH 1/2] dt-bindings: display: bridge: icn6211: Add support for RGB/BGR swap Marek Vasut
2022-08-01 16:32 ` Rob Herring
2022-08-02 11:33   ` Marek Vasut [this message]
2022-08-03 22:41     ` Rob Herring
2022-08-08  1:57       ` Marek Vasut
2022-08-26 11:52         ` Linus Walleij
2022-08-26 11:54           ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d917546-23a2-a33a-1f59-ec78305aa854@denx.de \
    --to=marex@denx.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jagan@amarulasolutions.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linus.walleij@linaro.org \
    --cc=robert.foss@linaro.org \
    --cc=robh@kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).