From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Guru Das Srinagesh <quic_gurus@quicinc.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Nicolas Schier <nicolas@fjasle.eu>,
Kees Cook <keescook@chromium.org>,
Bjorn Andersson <andersson@kernel.org>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
Will Deacon <will@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
quic_pkondeti@quicinc.com, u.kleine-koenig@pengutronix.de
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 0/1] Add add-maintainer.py script
Date: Tue, 15 Aug 2023 23:06:44 +0200 [thread overview]
Message-ID: <4d94d0fd-72d4-0196-3a30-3e1efb9f5aca@linaro.org> (raw)
In-Reply-To: <20230810185526.GC31860@quicinc.com>
On 10/08/2023 20:55, Guru Das Srinagesh wrote:
> On Aug 03 2023 01:23, Guru Das Srinagesh wrote:
>> When pushing patches to upstream, the `get_maintainer.pl` script is used to
>> determine whom to send the patches to. Instead of having to manually process
>> the output of the script, add a wrapper script to do that for you.
>>
>> The add-maintainer.py script adds maintainers (and mailing lists) to a patch,
>> editing it in-place.
>
> Could I request reviews from the other maintainers as well, please? Just to see
> if I should continue working on this script or if the `b4` tool obviates the
> need for such a script.
I send a bit of patches but I use very simple workflow. It is really
simple, so simple, that I was always surprised how people can make their
life difficult with some complicated process to send patches... and then
obviously skip some maintainers, because of that process.
I almost always feed git send-email with addresses from
scripts/get_maintainers.pl. This tool would not bring any benefits to my
simple workflow.
For newcomers, OTOH, I would either recommend simple workflow or just
use b4. Why? Because if you cannot use git-send-email, then it means
your email setup will make your life difficult and adding maintainers to
existing patch won't help you.
This tool depends on the command line and shell interface of
scripts/get_maintainers.pl which is another reason why it might not be a
good idea.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-15 21:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 8:23 [PATCH v2 0/1] Add add-maintainer.py script Guru Das Srinagesh
2023-08-03 8:23 ` [PATCH v2 1/1] scripts: Add add-maintainer.py Guru Das Srinagesh
2023-08-03 9:04 ` Pavan Kondeti
2023-08-10 18:52 ` Guru Das Srinagesh
2023-08-23 15:14 ` Nicolas Schier
2023-08-24 21:44 ` Guru Das Srinagesh
2023-08-25 11:44 ` Nicolas Schier
2023-08-25 17:00 ` Guru Das Srinagesh
2023-08-27 5:52 ` Nicolas Schier
2023-08-03 9:16 ` [PATCH v2 0/1] Add add-maintainer.py script Neil Armstrong
2023-08-10 18:49 ` Guru Das Srinagesh
2023-08-19 2:23 ` Guru Das Srinagesh
2023-08-10 18:55 ` Guru Das Srinagesh
2023-08-15 21:06 ` Krzysztof Kozlowski [this message]
2023-08-16 17:15 ` Guru Das Srinagesh
2023-08-18 8:33 ` Neil Armstrong
2023-08-19 1:48 ` Guru Das Srinagesh
2023-08-18 8:43 ` Krzysztof Kozlowski
2023-08-18 19:46 ` Bjorn Andersson
2023-08-19 7:50 ` Krzysztof Kozlowski
2023-08-19 1:33 ` Guru Das Srinagesh
2023-08-19 7:53 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d94d0fd-72d4-0196-3a30-3e1efb9f5aca@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=quic_gurus@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).