From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Robert Marko <robimarko@gmail.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
lgirdwood@gmail.com, broonie@kernel.org,
Rob Herring <robh+dt@kernel.org>,
krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Devicetree List <devicetree@vger.kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>
Subject: Re: [PATCH v4 6/6] arm64: dts: qcom: Add PMP8074 DTSI
Date: Thu, 19 May 2022 13:35:30 +0200 [thread overview]
Message-ID: <4d9b29e8-b171-e181-e2a7-2c8c80107ab1@linaro.org> (raw)
In-Reply-To: <CAOX2RU4--VULzvc9NGc4zWV4jpD+riM+9Ff8mqU834a6vQFc5Q@mail.gmail.com>
On 19/05/2022 13:21, Robert Marko wrote:
> On Thu, 19 May 2022 at 13:07, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 18/05/2022 20:48, Robert Marko wrote:
>>> PMP8074 is a companion PMIC to the Qualcomm IPQ8074 series that is
>>> controlled via SPMI.
>>>
>>> Since we now have support for the regulators inside of it add DTSI
>>> for it.
>>>
>>> Signed-off-by: Robert Marko <robimarko@gmail.com>
>>> ---
>>> arch/arm64/boot/dts/qcom/pmp8074.dtsi | 38 +++++++++++++++++++++++++++
>>
>> This file is not referenced by anything, thus not possible to compile
>> nor verify.
>
> That is correct, I can include it on HK01 which has an SDHCI controller
> and thus can consume L11 for VQMMC so that HS200 and higher work.
Yes, otherwise this does not have any effect.
>
> I wanted to include the nodes directly in the SoC DTSI and set L11 as VQMMC
> for SDHCI there as this is a companion PMIC and always present, but
> the established
> procedure is for the PMIC to have its own DTSI and then be included per board.
Which was correct suggestion but it is not relevant here. In your
previous approach your PMIC would be included on every board via SoC
DTSI. Now your PMIC is not included at all.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-05-19 11:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 18:48 [PATCH v4 1/6] dt-bindings: regulator: qcom,spmi-regulator: Convert to dtschema Robert Marko
2022-05-18 18:48 ` [PATCH v4 2/6] regulator: qcom_spmi: add support for HT_P150 Robert Marko
2022-05-18 18:48 ` [PATCH v4 3/6] regulator: qcom_spmi: add support for HT_P600 Robert Marko
2022-05-18 18:48 ` [PATCH v4 4/6] dt-bindings: regulator: qcom,spmi-regulator: add PMP8074 PMIC Robert Marko
2022-05-18 18:48 ` [PATCH v4 5/6] regulator: qcom_spmi: Add support for PMP8074 regulators Robert Marko
2022-05-18 18:48 ` [PATCH v4 6/6] arm64: dts: qcom: Add PMP8074 DTSI Robert Marko
2022-05-19 11:07 ` Krzysztof Kozlowski
2022-05-19 11:21 ` Robert Marko
2022-05-19 11:35 ` Krzysztof Kozlowski [this message]
2022-05-19 11:09 ` [PATCH v4 1/6] dt-bindings: regulator: qcom,spmi-regulator: Convert to dtschema Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d9b29e8-b171-e181-e2a7-2c8c80107ab1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).