From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: st7571-i2c: Add Sitronix ST7571 panel bindings
Date: Thu, 3 Apr 2025 16:28:22 +0200 [thread overview]
Message-ID: <4dbdea1f-dc22-4c66-b253-c3fd625edc67@kernel.org> (raw)
In-Reply-To: <Z-5jhrwTfu4WMk5n@gmail.com>
On 03/04/2025 12:31, Marcus Folkesson wrote:
>>> + i2c {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + display@3f {
>>
>> Look how this is called in other bindings... The binding and example are
>> not following existing code. Why? Why doing something entirely
>> different?
>
> Sorry, I'm not sure what you mean here.
You added code entirely different than existing code. Why doing
something entirely different? Open any other panel and look how it is
called.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-03 14:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 6:12 [PATCH 0/3] Add support for Sitronix ST7571 LCD controller Marcus Folkesson
2025-04-02 6:12 ` [PATCH 1/3] dt-bindings: st7571-i2c: Add Sitronix ST7571 panel bindings Marcus Folkesson
2025-04-02 8:27 ` Krzysztof Kozlowski
2025-04-03 10:31 ` Marcus Folkesson
2025-04-03 14:28 ` Krzysztof Kozlowski [this message]
2025-04-03 14:53 ` Marcus Folkesson
2025-04-02 8:31 ` Krzysztof Kozlowski
2025-04-02 8:32 ` Krzysztof Kozlowski
2025-04-02 6:12 ` [PATCH 2/3] drm/st7571-i2c: add support for Sitronix ST7571 LCD controller Marcus Folkesson
2025-04-02 8:12 ` Thomas Zimmermann
2025-04-02 8:31 ` Krzysztof Kozlowski
2025-04-02 6:12 ` [PATCH 3/3] MAINTAINERS: add antry " Marcus Folkesson
2025-04-02 8:28 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dbdea1f-dc22-4c66-b253-c3fd625edc67@kernel.org \
--to=krzk@kernel.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marcus.folkesson@gmail.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).