From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Thomas Bonnefille" <thomas.bonnefille@bootlin.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Chen Wang" <unicorn_wang@outlook.com>,
"Inochi Amaoto" <inochiama@outlook.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v3 1/3] dt-bindings: iio: adc: sophgo,cv18xx-saradc.yaml: Add Sophgo SARADC binding documentation
Date: Mon, 5 Aug 2024 16:46:21 +0200 [thread overview]
Message-ID: <4dc17f0c-557b-443b-a6cf-840b1b848b6f@kernel.org> (raw)
In-Reply-To: <20240803113959.12aa0c4a@jic23-huawei>
On 03/08/2024 12:39, Jonathan Cameron wrote:
>>
>>> +
>>> +unevaluatedProperties: false
>>
>> I don't see any other $ref. Don't you miss adc.yaml? Or channels? Or
>> some more properties? This looks incomplete for ADC.
>
> It's acceptable on ADCs in particular (but more generally)
> to just assume all channels are exposed. They may all be wired
> to internal power lines anyway, in which case what is there is
> a chip feature. This only works if their isn't any channel specific
> configuration, then not providing the channels child nodes is fine.
>
> However, that requires us to be fairly sure there won't ever be
> a per channel thing that needs configuring from DT.
> That's generally only the case in simple devices.
>
> So might be better to put the channels nodes in there and deal with
> dynamic channel configuration (so don't present any without
> a channel node) from the start as it's more future proof.
OK. Then anyway this should be additionalProperties: false (unless I
missed somewhere $ref?).
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-05 14:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 12:24 [PATCH v3 0/3] Add SARADC support on Sophgo SoC Thomas Bonnefille
2024-07-31 12:24 ` [PATCH v3 1/3] dt-bindings: iio: adc: sophgo,cv18xx-saradc.yaml: Add Sophgo SARADC binding documentation Thomas Bonnefille
2024-07-31 12:41 ` Inochi Amaoto
2024-07-31 14:48 ` Thomas Bonnefille
2024-07-31 22:39 ` Inochi Amaoto
2024-07-31 13:57 ` Krzysztof Kozlowski
2024-08-03 10:39 ` Jonathan Cameron
2024-08-05 14:46 ` Krzysztof Kozlowski [this message]
2024-07-31 12:24 ` [PATCH v3 2/3] iio: adc: sophgo-saradc: Add driver for Sophgo SARADC Thomas Bonnefille
2024-07-31 23:57 ` Chen Wang
2024-08-03 10:49 ` Jonathan Cameron
2024-07-31 12:24 ` [PATCH v3 3/3] riscv: dts: sophgo: Add SARADC description Thomas Bonnefille
2024-07-31 13:57 ` Krzysztof Kozlowski
2024-07-31 23:12 ` [PATCH v3 0/3] Add SARADC support on Sophgo SoC Chen Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dc17f0c-557b-443b-a6cf-840b1b848b6f@kernel.org \
--to=krzk@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=inochiama@outlook.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=thomas.bonnefille@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).