From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Abel Vesa <abelvesa@kernel.org>,
Shawn Guo <shengchao.guo@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Add the cfg_ahb clock for Nord
Date: Fri, 13 Nov 2026 12:47:16 +0100 [thread overview]
Message-ID: <4dc982c8-af04-4af8-8a56-66459f91cf3a@kernel.org> (raw)
In-Reply-To: <zo5qopdc6gxeoonqxohmnrzwmmrwa3wnim72op5zq2cjtn4pjs@kdjl3hwgxph3>
On 13/11/2026 11:45, Bartosz Golaszewski wrote:
> On Fri, Nov 13, 2026 at 11:07:38AM +0100, Krzysztof Kozlowski wrote:
>>> @@ -229,6 +231,7 @@ allOf:
>>> compatible:
>>> contains:
>>> enum:
>>> + - qcom,nord-qmp-usb3-dp-phy
>>
>> I don't understand why it is added to two blocks constraining clocks.
>> Does it even pass checks?
>>
>
> Yes, it passes dtbs_check in my WiP branch for USB nodes that will be
> sent as v4 and takes the binding changes into account.
>
> First we add the "qcom,nord-qmp-usb3-dp-phy" to the if block that sets
> minItems to 5. Then we exclude that compatible in the block that does an
> if not and sets minItems: 4 for all non-matching compatibles. This is in
> line with what's being done for existing "qcom,sc7180-qmp-usb3-dp-phy"
> and "qcom,sdm845-qmp-usb3-dp-phy" compatibles.
Oh my... what's with this binding :/
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-13 11:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 15:36 [PATCH v2 0/3] phy: qcom: Describe the AHB2PHY bridge clock on Nord Bartosz Golaszewski
2026-11-12 15:36 ` [PATCH v2 1/3] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Add the cfg_ahb clock for Nord Bartosz Golaszewski
2026-11-13 10:07 ` Krzysztof Kozlowski
2026-11-13 10:45 ` Bartosz Golaszewski
2026-11-13 11:47 ` Krzysztof Kozlowski [this message]
2026-11-12 15:36 ` [PATCH v2 2/3] dt-bindings: phy: qcom,snps-eusb2-phy: Add Nord bus clock Bartosz Golaszewski
2026-11-13 10:08 ` Krzysztof Kozlowski
2026-11-12 15:36 ` [PATCH v2 3/3] phy: phy-snps-eusb2: Enable AHB2PHY bus clock on Nord Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dc982c8-af04-4af8-8a56-66459f91cf3a@kernel.org \
--to=krzk@kernel.org \
--cc=abelvesa@kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mani@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=shengchao.guo@oss.qualcomm.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox