From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ED9915199D for ; Fri, 14 Feb 2025 06:53:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739515991; cv=none; b=AUeUGwWCulSPbAxXtJO3pYUieuzb3ZRz53xuBbCVxqSyeI2hB4Vr9QLYKs6s3aH3Yf1pZkP+eP3Sm3Wi9AAUt8z8x8jt6K/hKSrF9TsySjaFs3bxGTQNoHqFoWvnHJ1SbnFEn+5I1hvrhoMgo8nl95eyUeAeGjlqrVWkTEYHKrM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739515991; c=relaxed/simple; bh=pfdkkHyh2t3osDFLju+T4VzcDn1ZPpl25CDRF3LIv9A=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=gCDi1rK4md9U2/h6wuDarx6YN9oZr6gzg2eOyOnhwdidzC88OkHIR/3+JcAOck2NyiAXGSG0/QoXtc4X8TktdPQ6I5PCx1MsyQPQRNCBMzcZMDXBvyOfBOc07vRzhvT+4E7PPmWxllx9t8+7q7FsxYYuWPrV5NySsv7BsJv40iE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ALffev6/; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ALffev6/" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5de74599749so2611774a12.1 for ; Thu, 13 Feb 2025 22:53:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739515988; x=1740120788; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=00T2ImKqG2q8X/m5/Khez9kmb7XoPbfhx8Bnox/fhX8=; b=ALffev6/MPXYX8SjyyVK0HhjbbEqDz0avxA3sv2oxkeUkpXpPPIP7vyHRrJQVlT83d wzNq0hTeUAnDXVXsk4yna1kHO8IoGZ/AbhDNHdVeqtiu7AtSkmfZOfolfhd4RzGEQ58X y4r4845r3G550/C8Ax1U2qO+ytceM3lS6k+HFhVe1BzHHQUm81GFlD5OGXM/XsWLkk0H 5xQAJAvd1J8fpWssoUEFFBosbBcy1c+dwQy8xkQ3qUS+F+NQEmGMHFRn11lN+UhjkO2h GjG2i8P1VxizhH6f2M1ruEgEaLcdlRfp2kYL8o53J/ISn3SA+cGGBTlfIIMmS4AlUXh1 d2eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739515988; x=1740120788; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=00T2ImKqG2q8X/m5/Khez9kmb7XoPbfhx8Bnox/fhX8=; b=jUAiWpCRZkpwa6pIw8Cvfqjfo033304QbkM7vYL3HBmfke3VjwJLReQY6molO4T8Ur rHzg1Uuq0PZJgfaqIumgqUTvrjvQK2YUU0+MiatUZ2Jto/x4O15x5l3DiTdHnwIiT9of VEWIjDt1c/U6dTU/sg/VYdkXqQwbAm5jg0URlDHMRnrYPWYG8zmBJti2ZM6JJNo6BoK/ 7Fnf3IZENMaiVNNLhpx/gKRk0SwioU4wQxaMZ1T2LydMX9SDEIWNhIL88U2R53qn5yig 2Cj6RFK4Ohx9ejMFhH+Lm13KquCMG3FNCeqXFCBJAEeK93RTnXw7CM+WeCsKM8q98aJm dnOQ== X-Forwarded-Encrypted: i=1; AJvYcCXMLvPoq2Zzgq9Mum1b4cCgDeMUYi2Q+6Th06s3ZCGkYN6BO0MotjnvfHnkBltHuK94cN1vpo4Sge24@vger.kernel.org X-Gm-Message-State: AOJu0YzMfDxtry5AkNXUeFZ0l+lrggC3NxylTm6PGHZo+UTSj8mkejY2 tyw0Ylh5CXDaiBu72QMuf4ZfceXfQeGi48vE6FLvJ6Bi5V+71iLMt32oxbVCF94= X-Gm-Gg: ASbGncu+xslnE3DL6ywtVWaa8jsnEjzF/X62uq0SrP5KhHmyb8/e7/QRmYN7dRtm3Do kRuz8fcg+TBQAe27fGCycRCcLEbqtqqbFrppxIuW/nN57r2PT8PFa1yfrdcm4eZJIpKd0pXeusy xxh0FbGGJuCrE010pz0xdO17pThtqXXc4CUoz2D9qt853st3M/8ciQmF01f57Nrjc2RkBwnL/GV XisNcRa2nE0iFnaQ8dprmD7mxwT+yghMHR2ebYgquQFCPx+31RxyiHRynym/8878haKi7lKvwub ehvIiINm3DV+bFDGrE/ha3Gh X-Google-Smtp-Source: AGHT+IGXgRThBo7whBqMDD6umXjpqv2Cx6RqhrMtLSVb4XCNTRlLfTHBJzqRYVPktZC+1NWyeqaxJQ== X-Received: by 2002:a05:6402:4025:b0:5da:b64:e5d4 with SMTP id 4fb4d7f45d1cf-5dec9fad55bmr6890118a12.25.1739515988458; Thu, 13 Feb 2025 22:53:08 -0800 (PST) Received: from [192.168.0.14] ([79.115.63.124]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5dece287c7fsm2379602a12.70.2025.02.13.22.53.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Feb 2025 22:53:07 -0800 (PST) Message-ID: <4dcf3258-5e98-4f6d-bce0-e79c36f1f8ca@linaro.org> Date: Fri, 14 Feb 2025 06:53:05 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/3] spi: s3c64xx: add support exynos990-spi to new port config data To: Denzeel Oliva , andi.shyti@kernel.org, broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20250214043343.263-1-wachiturroxd150@gmail.com> Content-Language: en-US From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/14/25 5:31 AM, Denzeel Oliva wrote: > On Fri, Feb 14, 2025 at 04:33:40AM +0000, Denzeel Oliva wrote: >> Changes in v3: >> - Reordered fifo_depth handling in s3c64xx_spi_probe() so that the DT >> property takes precedence over the default value in port_config. >> This allows node-specific FIFO depths to be applied correctly while >> preserving a fallback. > > Showing evidence: > [ 0.339111] s3c64xx-spi 10920000.spi: spi bus clock parent not specified, using clock at index 0 as parent > [ 0.339119] s3c64xx-spi 10920000.spi: number of chip select lines not specified, assuming 1 chip select line > [ 0.339467] s3c64xx-spi 10920000.spi: registered host spi0 > [ 0.339589] s3c64xx-spi 10920000.spi: Samsung SoC SPI Driver loaded for Bus SPI-0 with 1 Targets attached > [ 0.339597] s3c64xx-spi 10920000.spi: IOmem=[[mem 0x10920000-0x1092002f]] FIFO 256bytes > ------------------------------------------------------------------------------------------------------------- > [ 0.587452] s3c64xx-spi 10650000.spi: spi bus clock parent not specified, using clock at index 0 as parent > [ 0.587462] s3c64xx-spi 10650000.spi: number of chip select lines not specified, assuming 1 chip select line > [ 0.587847] s3c64xx-spi 10650000.spi: registered host spi1 > [ 0.587986] s3c64xx-spi 10650000.spi: Samsung SoC SPI Driver loaded for Bus SPI-1 with 1 Targets attached > [ 0.587997] s3c64xx-spi 10650000.spi: IOmem=[[mem 0x10650000-0x1065002f]] FIFO 64bytes > Why does this prove that the IP works? Can you do a loopback test? See drivers/spi/spi-loopback-test.c