From: Johan Jonker <jbx6244@gmail.com>
To: Vivek Unune <npcomplete13@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, heiko@sntech.de,
ezequiel@collabora.com, akash@openedev.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Add Hugsun X99 IR receiver and power led
Date: Fri, 13 Mar 2020 15:29:59 +0100 [thread overview]
Message-ID: <4deb154d-3095-7d18-fbf9-85b60f57765f@gmail.com> (raw)
In-Reply-To: <20200313142005.GA25349@ubuntu>
Hi Vivek,
On 3/13/20 3:20 PM, Vivek Unune wrote:
> On Fri, Mar 13, 2020 at 09:32:27AM +0100, Johan Jonker wrote:
>> Hi Vivek,
>>
>> The 'power-led' need some changes.
>>
>> From leds-gpio.yaml:
>>
>> patternProperties:
>> # The first form is preferred, but fall back to just 'led' anywhere in the
>> # node name to at least catch some child nodes.
>> "(^led-[0-9a-f]$|led)":
>> type: object
>>
>> Test with:
>> make -k ARCH=arm64 dtbs_check
>>
>> arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dt.yaml: leds:
>> power-led:linux,default-trigger:0: 'none' is not one of ['backlight',
>> 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
>>
>> On 3/13/20 1:01 AM, Vivek Unune wrote:
>>> - Add Hugsun X99 IR receiver and power led
>>> - Remove pwm0 node as it interferes with pwer LED gpio
>>
>> pwer => power
>>
>
> Hi Johan,
>
> I'll fix those in my next version. Here's what I intended to to:
>
> 1. Rename 'power-led' node to 'led-power'
The first form is preferred.
Put 'led-power' in a regex tester with ^led-[0-9a-f]$
https://regex101.com/
Your regular expression does not match the subject string.
Test 'led-0'
Full match
> 2. Remove 'linux,default-trigger' entirely since this led is always on
>
> Thanks,
>
> Vivek
>
>>> index d69a613fb65a..df425e164a2e 100644
>>> --- a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
>>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
>>> @@ -29,6 +29,26 @@
>>> regulator-max-microvolt = <5000000>;
>>> };
>>>
>>> + leds {
>>> + compatible = "gpio-leds";
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&power_led_gpio>;
>>> +
>>> + power-led {
>>> + label = "blue:power";
>>> + gpios = <&gpio4 RK_PC2 GPIO_ACTIVE_HIGH>;
>>> + default-state = "on";
>>> + linux,default-trigger = "none";
>>> + };
>>> + };
>>> +
next prev parent reply other threads:[~2020-03-13 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 0:01 [PATCH] arm64: dts: rockchip: Add Hugsun X99 IR receiver and power led Vivek Unune
2020-03-13 8:32 ` Johan Jonker
2020-03-13 14:20 ` Vivek Unune
2020-03-13 14:29 ` Johan Jonker [this message]
2020-03-13 14:37 ` Vivek Unune
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4deb154d-3095-7d18-fbf9-85b60f57765f@gmail.com \
--to=jbx6244@gmail.com \
--cc=akash@openedev.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=npcomplete13@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).