From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>,
LKML <linux-kernel@vger.kernel.org>
Cc: agross@kernel.org, andersson@kernel.org, conor+dt@kernel.org,
cros-qcom-dts-watchers@chromium.org, devicetree@vger.kernel.org,
dianders@chromium.org, konrad.dybcio@linaro.org,
krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
robh+dt@kernel.org
Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: sc7180: Add board id for lazor/limozeen
Date: Thu, 10 Aug 2023 13:27:28 +0200 [thread overview]
Message-ID: <4e05a1fb-f6f2-3219-b41d-67351c70a7ff@linaro.org> (raw)
In-Reply-To: <cd15df3a-eadc-13d6-7088-3ad785ea733e@linaro.org>
On 10/08/2023 11:30, Sheng-Liang Pan wrote:
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
>> Isn't this duplicated with r9? Probably other places as well... or....
>> separate r10 add rt5682s node which different with r9.
> we separate r10 add rt5682s which differentwith r9
>
>
>>> - model = "Google Lazor Limozeen without Touchscreen (rev9+)";
>>> - compatible = "google,lazor-sku6", "google,lazor-sku18", "qcom,sc7180";
>>> + model = "Google Lazor Limozeen without Touchscreen (rev9)";
>>> + compatible = "google,lazor-rev9-sku6", "google,lazor-rev9-sku18", "qcom,sc7180";
>
>> Your patch 2 does not make any sense. Didn't you touch it in patch 2?
>> Really, what is happening here?
> patch 2 explain why we added new sku for no-eSIM.
So which commit explain why you touch the same line twice? Sorry, this
does not make sense.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-10 11:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 6:49 [PATCH v3 0/3] Add no-esim sku for sc7180-lazor family and new board version Sheng-Liang Pan
2023-08-09 6:49 ` [PATCH v3 1/3] dt-bindings: arm: qcom: add sc7180-lazor board bindings Sheng-Liang Pan
2023-08-15 21:10 ` Doug Anderson
2023-08-09 6:49 ` [PATCH v3 2/3] arm64: dts: qcom: sc7180: Add sku_id for lazor/limozeen Sheng-Liang Pan
2023-08-09 6:49 ` [PATCH v3 3/3] arm64: dts: qcom: sc7180: Add board id " Sheng-Liang Pan
2023-08-09 15:50 ` Krzysztof Kozlowski
2023-08-10 11:27 ` Krzysztof Kozlowski [this message]
2023-08-14 8:01 ` Krzysztof Kozlowski
[not found] ` <20230814094802.9127-1-sheng-liang.pan@quanta.corp-partner.google.com>
2023-08-15 21:12 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e05a1fb-f6f2-3219-b41d-67351c70a7ff@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sheng-liang.pan@quanta.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).