Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Wadim Mueller" <wafgo01@gmail.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Maxwell Doose" <m32285159@gmail.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Marcelo Schmitt" <marcelo.schmitt1@gmail.com>,
	"Rodrigo Alencar" <455.rodrigo.alencar@gmail.com>
Subject: Re: [PATCH v4 4/4] iio: flow: add Sensirion SLF3S liquid flow sensor driver
Date: Sat, 13 Jun 2026 09:51:13 +0200	[thread overview]
Message-ID: <4e4ef1ae-62e7-4639-914c-19f49930be02@kernel.org> (raw)
In-Reply-To: <20260612184729.795e0e84@jic23-huawei>

On 12/06/2026 19:47, Jonathan Cameron wrote:
> On Thu, 11 Jun 2026 16:01:12 +0200
> Krzysztof Kozlowski <krzk@kernel.org> wrote:
> 
>> On 11/06/2026 15:27, Wadim Mueller wrote:
>>> +
>>> +static const struct of_device_id slf3s_of_match[] = {
>>> +	{ .compatible = "sensirion,slf3s-0600f", .data = &slf3s_variants[0] },
>>> +	{ .compatible = "sensirion,slf3s-1300f", .data = &slf3s_variants[1] },
>>> +	{ .compatible = "sensirion,slf3s-4000b", .data = &slf3s_variants[2] },  
>>
>> You should have only 1300f here and detect the variants. That was my
>> point when I suggested to use the fallback.
>>
> 
> I'm lost. How does that work?  They cannot fallback to that part because
> it relies on in driver detection of the fact that they are incompatible.
> 

I am lost too. Then why were they made compatible in the binding?

Entire discussion was that these are FULLY compatible due to variant
detection. That was the entire point of discussing more generic
fallback. Using specific fallback does not change that - it is the same
concept.

If devices are not detectable, why were we discussing any compatibility?

Best regards,
Krzysztof

  reply	other threads:[~2026-06-13  7:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-11 13:26 [PATCH v4 0/4] iio: flow: Sensirion SLF3S liquid flow sensor Wadim Mueller
2026-06-11 13:26 ` [PATCH v4 1/4] iio: types: add IIO_VOLUMEFLOW channel type Wadim Mueller
2026-06-11 13:26 ` [PATCH v4 2/4] dt-bindings: iio: flow: add Sensirion SLF3S liquid flow sensor Wadim Mueller
2026-06-11 14:01   ` Krzysztof Kozlowski
2026-06-11 13:26 ` [PATCH v4 3/4] iio: core: add IIO_VAL_DECIMAL64_FEMTO format type Wadim Mueller
2026-06-12  9:11   ` Rodrigo Alencar
2026-06-11 13:27 ` [PATCH v4 4/4] iio: flow: add Sensirion SLF3S liquid flow sensor driver Wadim Mueller
2026-06-11 14:01   ` Krzysztof Kozlowski
2026-06-12 17:47     ` Jonathan Cameron
2026-06-13  7:51       ` Krzysztof Kozlowski [this message]
2026-06-11 19:18   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e4ef1ae-62e7-4639-914c-19f49930be02@kernel.org \
    --to=krzk@kernel.org \
    --cc=455.rodrigo.alencar@gmail.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m32285159@gmail.com \
    --cc=marcelo.schmitt1@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=wafgo01@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox