devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alessandrelli, Daniele" <daniele.alessandrelli@intel.com>
To: "Murphy, Paul J" <paul.j.murphy@intel.com>,
	"jacopo@jmondi.org" <jacopo@jmondi.org>,
	"mchehab@kernel.org" <mchehab@kernel.org>,
	"bryan.odonoghue@linaro.org" <bryan.odonoghue@linaro.org>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"sakari.ailus@iki.fi" <sakari.ailus@iki.fi>
Cc: "konrad.dybcio@somainline.org" <konrad.dybcio@somainline.org>,
	"dmitry.baryshkov@linaro.org" <dmitry.baryshkov@linaro.org>,
	"andrey.konovalov@linaro.org" <andrey.konovalov@linaro.org>
Subject: Re: [PATCH 2/2] media: i2c: imx412: Add imx577 compatible string
Date: Tue, 14 Jun 2022 08:02:13 +0000	[thread overview]
Message-ID: <4e5aefa1dec1b90c9f43e175fdf82d75ad0fe46f.camel@intel.com> (raw)
In-Reply-To: <20220607134057.2427663-3-bryan.odonoghue@linaro.org>

On Tue, 2022-06-07 at 14:40 +0100, Bryan O'Donoghue wrote:
> The Sony IMX577 uses the same silicon enabling reference code from Sony in
> the available examples provided.
> 
> Add an imx577 compatible string and re-use the existing imx412 code.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

I've read the discussion following the cover letter and I also tend to
agree that this change makes sense, at least for now.

If in the future somebody wants to add IMX577-specific features, they
can always create a separate driver for IMX577, if that's preferable.

Reviewed-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com>

> ---
>  drivers/media/i2c/imx412.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/i2c/imx412.c b/drivers/media/i2c/imx412.c
> index a1394d6c1432..3b7011ab0a8f 100644
> --- a/drivers/media/i2c/imx412.c
> +++ b/drivers/media/i2c/imx412.c
> @@ -1282,6 +1282,7 @@ static const struct dev_pm_ops imx412_pm_ops = {
>  
>  static const struct of_device_id imx412_of_match[] = {
>         { .compatible = "sony,imx412" },
> +       { .compatible = "sony,imx577" },
>         { }
>  };
>  


  parent reply	other threads:[~2022-06-14  8:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-07 13:40 [PATCH 0/2] Add imx577 compatible to imx412 Bryan O'Donoghue
2022-06-07 13:40 ` [PATCH 1/2] media: dt-bindings: imx412: Add imx577 compatible string Bryan O'Donoghue
2022-06-09 20:15   ` Rob Herring
2022-06-14  7:48   ` Kieran Bingham
2022-06-07 13:40 ` [PATCH 2/2] media: i2c: " Bryan O'Donoghue
2022-06-14  7:47   ` Kieran Bingham
2022-06-14  8:02   ` Alessandrelli, Daniele [this message]
2022-06-14 12:00   ` Sakari Ailus
2022-06-14 14:43     ` Bryan O'Donoghue
2022-06-07 21:56 ` [PATCH 0/2] Add imx577 compatible to imx412 Kieran Bingham
2022-06-07 22:01   ` Bryan O'Donoghue
2022-06-14 12:05   ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e5aefa1dec1b90c9f43e175fdf82d75ad0fe46f.camel@intel.com \
    --to=daniele.alessandrelli@intel.com \
    --cc=andrey.konovalov@linaro.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=jacopo@jmondi.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=paul.j.murphy@intel.com \
    --cc=sakari.ailus@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).