From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
vkoul@kernel.org, broonie@kernel.org
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
bgoswami@codeaurora.org, plai@codeaurora.org,
linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
robh+dt@kernel.org
Subject: Re: [alsa-devel] [PATCH v2 4/4] ASoC: codecs: add wsa881x amplifier support
Date: Thu, 8 Aug 2019 11:29:20 -0500 [thread overview]
Message-ID: <4e60b92f-a32e-671c-3b1b-9b1ccec4f9b5@linux.intel.com> (raw)
In-Reply-To: <32516aae-8a43-6a74-c564-92dea8ff6e53@linaro.org>
>>> +/* 4 ports */
>>> +static struct sdw_dpn_prop wsa_sink_dpn_prop[WSA881X_MAX_SWR_PORTS] = {
>>> + {
>>> + /* DAC */
>>> + .num = 1,
>>> + .type = SDW_DPN_SIMPLE,
>>
>> IIRC we added the REDUCED type in SoundWire 1.1 to cover the PDM case
>> with channel packing (or was it grouping) used by Qualcomm. I am not
>> sure the SIMPLE type works?
> grouping I guess.
>
> This is a simplified data port as there is no DPn_OffsetCtrl2 register
> implemented.
ok, for the REDUCED type it's required to have BlockPackingMode and
OffsetCtrl2, so it does not apply here. Thanks for confirming.
next prev parent reply other threads:[~2019-08-08 16:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 14:45 [PATCH v2 0/4] ASoC: codecs: Add WSA881x Smart Speaker amplifier support Srinivas Kandagatla
2019-08-08 14:45 ` [PATCH v2 1/4] dt-bindings: soundwire: add slave bindings Srinivas Kandagatla
2019-08-08 15:58 ` Pierre-Louis Bossart
2019-08-08 16:48 ` Srinivas Kandagatla
2019-08-08 19:52 ` Mark Brown
2019-08-09 4:54 ` Vinod Koul
2019-08-09 8:25 ` Srinivas Kandagatla
2019-08-09 5:00 ` Vinod Koul
2019-08-08 14:45 ` [PATCH v2 2/4] soundwire: core: add device tree support for slave devices Srinivas Kandagatla
2019-08-08 15:00 ` Pierre-Louis Bossart
2019-08-08 15:17 ` Srinivas Kandagatla
2019-08-09 5:46 ` Vinod Koul
2019-08-09 8:24 ` Srinivas Kandagatla
2019-08-09 5:07 ` Vinod Koul
2019-08-09 8:24 ` Srinivas Kandagatla
2019-08-08 14:45 ` [PATCH v2 3/4] dt-bindings: ASoC: Add WSA881x bindings Srinivas Kandagatla
2019-08-08 14:45 ` [PATCH v2 4/4] ASoC: codecs: add wsa881x amplifier support Srinivas Kandagatla
2019-08-08 15:18 ` [alsa-devel] " Pierre-Louis Bossart
2019-08-08 16:20 ` Srinivas Kandagatla
2019-08-08 16:29 ` Pierre-Louis Bossart [this message]
2019-08-09 4:56 ` [PATCH v2 0/4] ASoC: codecs: Add WSA881x Smart Speaker " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e60b92f-a32e-671c-3b1b-9b1ccec4f9b5@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).