From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/6] arm64: dts: qcom: sc7280: use constants for gpucc clocks and power-domains
Date: Wed, 6 Jul 2022 17:43:59 +0200 [thread overview]
Message-ID: <4e61ab03-6edf-c228-78c3-d250e36e8556@linaro.org> (raw)
In-Reply-To: <20220706145412.1566011-2-dmitry.baryshkov@linaro.org>
On 06/07/2022 16:54, Dmitry Baryshkov wrote:
> To ease merging of bindings and dts files, the constants were replaced
In the future I recommend just adding defines in top part of DTSI (under
ifdef not defined). Then when time comes, you drop this entire piece of
defines which makes it extra readable and easy to review. Nice clean
patchset.
To review this approach, I would need to check every define if it
matches the previous number.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-06 15:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 14:54 [PATCH 1/6] arm64: dts: qcom: msm8996: add missing DSI clock assignments Dmitry Baryshkov
2022-07-06 14:54 ` [PATCH 2/6] arm64: dts: qcom: sc7280: use constants for gpucc clocks and power-domains Dmitry Baryshkov
2022-07-06 15:43 ` Krzysztof Kozlowski [this message]
2022-07-06 21:02 ` Bjorn Andersson
2022-07-06 14:54 ` [PATCH 3/6] arm64: dts: qcom: sc7180-idp: add vdds supply to the DSI PHY Dmitry Baryshkov
2022-07-06 14:54 ` [PATCH 4/6] arm: dts: qcom: apq8064: rename DSI PHY iface clock Dmitry Baryshkov
2022-07-06 14:54 ` [PATCH 5/6] arm: dts: qcom: apq8064: disable DSI and DSI PHY by default Dmitry Baryshkov
2022-07-06 14:54 ` [PATCH 6/6] arm: dts: qcom-msm8974: rename GPU's OPP table node Dmitry Baryshkov
2022-07-07 2:31 ` (subset) [PATCH 1/6] arm64: dts: qcom: msm8996: add missing DSI clock assignments Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e61ab03-6edf-c228-78c3-d250e36e8556@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).