From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D8B2C433EF for ; Wed, 6 Jul 2022 15:50:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234745AbiGFPuO (ORCPT ); Wed, 6 Jul 2022 11:50:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229757AbiGFPtY (ORCPT ); Wed, 6 Jul 2022 11:49:24 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 201ED2A965 for ; Wed, 6 Jul 2022 08:44:04 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id y16so26572865lfb.9 for ; Wed, 06 Jul 2022 08:44:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=9vQCQQEHozN/CKCyvBt3RmwrseBMzr8DZRLmrXsr6Vk=; b=xGdDsvCZ93HCAJQGgrVqKH9nd651H8wO6nk6g4ZSzMR2yRgrUVmzPa/elcZd5L4Lde /Q5Gpz1ztCxj5dL9sIJTvAn6vHVMtKGu0J0E9QX0TSZYY+FpxVy58hDP/FzALwaI8mxG d3poucFFf0vaghLZUf5xjAH0phOs+1BpzaQCOyYxObA0oxig9oPiexkeNhpb8dUdXVND l9h6HpaERJadAhRkq2s38orTXYCIqcyB+OpIvW2xAKZmYSjoanjd2tZrwtYp9rDf3U6n /aAO9zg3xkHYHk8xinqeW6k/82hKd6+360WBOFJiyprazmQoI9CkTWE1guV2/d+4Ts+L YkhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=9vQCQQEHozN/CKCyvBt3RmwrseBMzr8DZRLmrXsr6Vk=; b=m0+Jyl2Q4hz7trx46jaaiUnJOTxZTwgdox5hOAPXb7XFLlm8/OUqwyZ3MscUVg/DZa 4hTReRoLH/a/cwSh/+L3tfDqZ/84/Znpj4BorAntj7N90lIcwN5tv+g7efg2AjMOZO6o zXuILZurZQKvdcXCuQzjhqNbqfCyTDJYPwx94Xbyk39xs6dLEvjsCD8RUycWlTZSZuib 6snZ8M/DXrdwg4tXtDYbtopMLppPsJZGsy5DiPBzZuRlWnZvlDBBSNQ0dAU4My2VlGnL v6ssIbEta8XW9X4vVnDU4dsrSs08u3lt2Q5ANkfjNn0rkM9CiVk07g4gvFuxHT1lOqhw 5XxQ== X-Gm-Message-State: AJIora/A059dVDav7zAM10eLevxtReei1agKuFLBzMPNt1VQACj0AVLV vrF5m1iMB4zp0c0u9+5PVCL2xQ== X-Google-Smtp-Source: AGRyM1tFVri7akrkvOuHoOv7M8H62ctTF43uQERPnuj8O45tl7BTZfj5hL5DTJ9KyKtLQDUAMl/AaA== X-Received: by 2002:a05:6512:3e2a:b0:47f:7549:e3f1 with SMTP id i42-20020a0565123e2a00b0047f7549e3f1mr26431687lfv.386.1657122241371; Wed, 06 Jul 2022 08:44:01 -0700 (PDT) Received: from [192.168.1.52] ([84.20.121.239]) by smtp.gmail.com with ESMTPSA id e14-20020a05651c038e00b0025a7056f4easm6260769ljp.85.2022.07.06.08.44.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jul 2022 08:44:00 -0700 (PDT) Message-ID: <4e61ab03-6edf-c228-78c3-d250e36e8556@linaro.org> Date: Wed, 6 Jul 2022 17:43:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/6] arm64: dts: qcom: sc7280: use constants for gpucc clocks and power-domains Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20220706145412.1566011-1-dmitry.baryshkov@linaro.org> <20220706145412.1566011-2-dmitry.baryshkov@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220706145412.1566011-2-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/07/2022 16:54, Dmitry Baryshkov wrote: > To ease merging of bindings and dts files, the constants were replaced In the future I recommend just adding defines in top part of DTSI (under ifdef not defined). Then when time comes, you drop this entire piece of defines which makes it extra readable and easy to review. Nice clean patchset. To review this approach, I would need to check every define if it matches the previous number. Best regards, Krzysztof