From: Nick Chan <towinchenmi@gmail.com>
To: Yureka Lilian <yureka@cyberchaos.dev>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Sven Peter <sven@kernel.org>, Janne Grunau <j@jannau.net>,
Neal Gompa <neal@gompa.dev>, Hector Martin <marcan@marcan.st>,
Thomas Gleixner <tglx@kernel.org>, Radu Rendec <radu@rendec.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 4/6] dt-bindings: interrupt-controller: apple,aic2: Add apple,t8140 compatible
Date: Sat, 5 Sep 2026 16:25:36 +0800 [thread overview]
Message-ID: <4e65ef39-cf1b-49d4-a899-da36acb442c2@gmail.com> (raw)
In-Reply-To: <20260904-apple-a18-pro-initial-devicetrees-v1-4-0c25401d165d@cyberchaos.dev>
Yureka Lilian 於 2026/9/5 凌晨3:49 寫道:
> The Apple t8140 (A18 Pro) SoC uses an AIC3 as interrupt controller, same as
> the M1-M4 SoCs.
>
> Signed-off-by: Yureka Lilian <yureka@cyberchaos.dev>
> ---
> Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> index 1cb886785173..e3cadc5ad39d 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> @@ -46,6 +46,7 @@ properties:
> - apple,t6030-aic3
> - apple,t6031-aic3
> - apple,t8132-aic3
> + - apple,t8140-aic3
the title should be "... Add t8140 compatible" describing the hardware corresponding
to the added compatible since the compatible being added is not "apple,t8140".
(Alternatively, if you mention the compatible in title, say "...Add apple,t8140-aic3" as
"compatible" is already implied)
> - const: apple,t8122-aic3
> - const: apple,t8122-aic3
>
>
next prev parent reply other threads:[~2026-09-05 8:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 19:49 [PATCH 0/6] Initial Apple Silicon A18 Pro device trees and dt-bindings Yureka Lilian
2026-09-04 19:49 ` [PATCH 1/6] dt-bindings: arm: cpus: Add Apple A18 Pro CPU core compatibles Yureka Lilian
2026-09-04 19:49 ` [PATCH 2/6] dt-bindings: arm: apple: apple,pmgr: Add t8140 compatible Yureka Lilian
2026-09-04 20:30 ` Sven Peter
2026-09-04 20:54 ` Yureka Lilian
2026-09-04 19:49 ` [PATCH 3/6] dt-bindings: arm: power: apple,pmgr-pwrstate: " Yureka Lilian
2026-09-04 19:49 ` [PATCH 4/6] dt-bindings: interrupt-controller: apple,aic2: Add apple,t8140 compatible Yureka Lilian
2026-09-05 8:25 ` Nick Chan [this message]
2026-09-04 19:49 ` [PATCH 5/6] dt-bindings: watchdog: apple,wdt: Add t8140 compatible Yureka Lilian
2026-09-04 19:49 ` [PATCH 6/6] arm64: dts: apple: Add minimal MacBook Neo device tree Yureka Lilian
2026-09-04 19:59 ` sashiko-bot
2026-09-04 20:34 ` Sven Peter
2026-09-04 20:57 ` Yureka Lilian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e65ef39-cf1b-49d4-a899-da36acb442c2@gmail.com \
--to=towinchenmi@gmail.com \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j@jannau.net \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lpieralisi@kernel.org \
--cc=marcan@marcan.st \
--cc=neal@gompa.dev \
--cc=radu@rendec.net \
--cc=robh@kernel.org \
--cc=sven@kernel.org \
--cc=tglx@kernel.org \
--cc=wim@linux-watchdog.org \
--cc=yureka@cyberchaos.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox