* [PATCH] arm64: dts: qcom: sm8550: Add support for camss
@ 2025-04-15 7:38 Wenmeng Liu
2025-04-30 11:11 ` Konrad Dybcio
0 siblings, 1 reply; 7+ messages in thread
From: Wenmeng Liu @ 2025-04-15 7:38 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Depeng Shao, Wenmeng Liu
Add support for the camera subsystem on the SM8550 Qualcomm SoC. This
includes bringing up the CSIPHY, CSID, VFE/RDI interfaces.
SM8550 provides
- 3 x VFE, 3 RDI per VFE
- 2 x VFE Lite, 4 RDI per VFE
- 3 x CSID
- 2 x CSID Lite
- 8 x CSI PHY
Co-developed-by: Depeng Shao <quic_depengs@quicinc.com>
Signed-off-by: Depeng Shao <quic_depengs@quicinc.com>
Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
---
arch/arm64/boot/dts/qcom/sm8550.dtsi | 210 +++++++++++++++++++++++++++++++++++
1 file changed, 210 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index e9bb077aa9f0b8be28608d4a0345aae7df8cd167..722521496a2dadb1c3f22d36c9cc28f87861a57b 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -3326,6 +3326,216 @@ cci2_i2c1: i2c-bus@1 {
};
};
+ isp: isp@acb7000 {
+ compatible = "qcom,sm8550-camss";
+
+ reg = <0x0 0x0acb7000 0x0 0x0d00>,
+ <0x0 0x0acb9000 0x0 0x0d00>,
+ <0x0 0x0acbb000 0x0 0x0d00>,
+ <0x0 0x0acca000 0x0 0x0a00>,
+ <0x0 0x0acce000 0x0 0x0a00>,
+ <0x0 0x0acb6000 0x0 0x1000>,
+ <0x0 0x0ace4000 0x0 0x2000>,
+ <0x0 0x0ace6000 0x0 0x2000>,
+ <0x0 0x0ace8000 0x0 0x2000>,
+ <0x0 0x0acea000 0x0 0x2000>,
+ <0x0 0x0acec000 0x0 0x2000>,
+ <0x0 0x0acee000 0x0 0x2000>,
+ <0x0 0x0acf0000 0x0 0x2000>,
+ <0x0 0x0acf2000 0x0 0x2000>,
+ <0x0 0x0ac62000 0x0 0xf000>,
+ <0x0 0x0ac71000 0x0 0xf000>,
+ <0x0 0x0ac80000 0x0 0xf000>,
+ <0x0 0x0accb000 0x0 0x1800>,
+ <0x0 0x0accf000 0x0 0x1800>;
+ reg-names = "csid0",
+ "csid1",
+ "csid2",
+ "csid_lite0",
+ "csid_lite1",
+ "csid_wrapper",
+ "csiphy0",
+ "csiphy1",
+ "csiphy2",
+ "csiphy3",
+ "csiphy4",
+ "csiphy5",
+ "csiphy6",
+ "csiphy7",
+ "vfe0",
+ "vfe1",
+ "vfe2",
+ "vfe_lite0",
+ "vfe_lite1";
+
+ clocks = <&camcc CAM_CC_CAMNOC_AXI_CLK>,
+ <&camcc CAM_CC_CPAS_AHB_CLK>,
+ <&camcc CAM_CC_CPAS_FAST_AHB_CLK>,
+ <&camcc CAM_CC_CPAS_IFE_LITE_CLK>,
+ <&camcc CAM_CC_CPAS_IFE_0_CLK>,
+ <&camcc CAM_CC_CPAS_IFE_1_CLK>,
+ <&camcc CAM_CC_CPAS_IFE_2_CLK>,
+ <&camcc CAM_CC_CSID_CLK>,
+ <&camcc CAM_CC_CSIPHY0_CLK>,
+ <&camcc CAM_CC_CSI0PHYTIMER_CLK>,
+ <&camcc CAM_CC_CSIPHY1_CLK>,
+ <&camcc CAM_CC_CSI1PHYTIMER_CLK>,
+ <&camcc CAM_CC_CSIPHY2_CLK>,
+ <&camcc CAM_CC_CSI2PHYTIMER_CLK>,
+ <&camcc CAM_CC_CSIPHY3_CLK>,
+ <&camcc CAM_CC_CSI3PHYTIMER_CLK>,
+ <&camcc CAM_CC_CSIPHY4_CLK>,
+ <&camcc CAM_CC_CSI4PHYTIMER_CLK>,
+ <&camcc CAM_CC_CSIPHY5_CLK>,
+ <&camcc CAM_CC_CSI5PHYTIMER_CLK>,
+ <&camcc CAM_CC_CSIPHY6_CLK>,
+ <&camcc CAM_CC_CSI6PHYTIMER_CLK>,
+ <&camcc CAM_CC_CSIPHY7_CLK>,
+ <&camcc CAM_CC_CSI7PHYTIMER_CLK>,
+ <&camcc CAM_CC_CSID_CSIPHY_RX_CLK>,
+ <&gcc GCC_CAMERA_HF_AXI_CLK>,
+ <&camcc CAM_CC_IFE_0_CLK>,
+ <&camcc CAM_CC_IFE_0_FAST_AHB_CLK>,
+ <&camcc CAM_CC_IFE_1_CLK>,
+ <&camcc CAM_CC_IFE_1_FAST_AHB_CLK>,
+ <&camcc CAM_CC_IFE_2_CLK>,
+ <&camcc CAM_CC_IFE_2_FAST_AHB_CLK>,
+ <&camcc CAM_CC_IFE_LITE_CLK>,
+ <&camcc CAM_CC_IFE_LITE_AHB_CLK>,
+ <&camcc CAM_CC_IFE_LITE_CPHY_RX_CLK>,
+ <&camcc CAM_CC_IFE_LITE_CSID_CLK>;
+ clock-names = "camnoc_axi",
+ "cpas_ahb",
+ "cpas_fast_ahb_clk",
+ "cpas_ife_lite",
+ "cpas_vfe0",
+ "cpas_vfe1",
+ "cpas_vfe2",
+ "csid",
+ "csiphy0",
+ "csiphy0_timer",
+ "csiphy1",
+ "csiphy1_timer",
+ "csiphy2",
+ "csiphy2_timer",
+ "csiphy3",
+ "csiphy3_timer",
+ "csiphy4",
+ "csiphy4_timer",
+ "csiphy5",
+ "csiphy5_timer",
+ "csiphy6",
+ "csiphy6_timer",
+ "csiphy7",
+ "csiphy7_timer",
+ "csiphy_rx",
+ "gcc_axi_hf",
+ "vfe0",
+ "vfe0_fast_ahb",
+ "vfe1",
+ "vfe1_fast_ahb",
+ "vfe2",
+ "vfe2_fast_ahb",
+ "vfe_lite",
+ "vfe_lite_ahb",
+ "vfe_lite_cphy_rx",
+ "vfe_lite_csid";
+
+ interrupts = <GIC_SPI 601 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 603 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 431 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 605 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 376 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 477 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 478 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 479 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 448 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 122 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 89 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 278 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 277 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 602 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 604 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 688 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 606 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 377 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "csid0",
+ "csid1",
+ "csid2",
+ "csid_lite0",
+ "csid_lite1",
+ "csiphy0",
+ "csiphy1",
+ "csiphy2",
+ "csiphy3",
+ "csiphy4",
+ "csiphy5",
+ "csiphy6",
+ "csiphy7",
+ "vfe0",
+ "vfe1",
+ "vfe2",
+ "vfe_lite0",
+ "vfe_lite1";
+
+ interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
+ &config_noc SLAVE_CAMERA_CFG QCOM_ICC_TAG_ACTIVE_ONLY>,
+ <&mmss_noc MASTER_CAMNOC_HF QCOM_ICC_TAG_ALWAYS
+ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
+ interconnect-names = "ahb",
+ "hf_0_mnoc";
+
+ iommus = <&apps_smmu 0x800 0x20>;
+
+ power-domains = <&camcc CAM_CC_IFE_0_GDSC>,
+ <&camcc CAM_CC_IFE_1_GDSC>,
+ <&camcc CAM_CC_IFE_2_GDSC>,
+ <&camcc CAM_CC_TITAN_TOP_GDSC>;
+ power-domain-names = "ife0",
+ "ife1",
+ "ife2",
+ "top";
+
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ };
+
+ port@1 {
+ reg = <1>;
+ };
+
+ port@2 {
+ reg = <2>;
+ };
+
+ port@3 {
+ reg = <3>;
+ };
+
+ port@4 {
+ reg = <4>;
+ };
+
+ port@5 {
+ reg = <5>;
+ };
+
+ port@6 {
+ reg = <6>;
+ };
+
+ port@7 {
+ reg = <7>;
+ };
+ };
+ };
+
camcc: clock-controller@ade0000 {
compatible = "qcom,sm8550-camcc";
reg = <0 0x0ade0000 0 0x20000>;
---
base-commit: 4c29b58d51224f92c01df1337b5348f82052337c
change-id: 20250415-sm8550_camss-e3feb5294ac9
Best regards,
--
Wenmeng Liu <quic_wenmliu@quicinc.com>
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sm8550: Add support for camss
2025-04-15 7:38 [PATCH] arm64: dts: qcom: sm8550: Add support for camss Wenmeng Liu
@ 2025-04-30 11:11 ` Konrad Dybcio
2025-05-01 1:15 ` Bryan O'Donoghue
0 siblings, 1 reply; 7+ messages in thread
From: Konrad Dybcio @ 2025-04-30 11:11 UTC (permalink / raw)
To: Wenmeng Liu, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bryan O'Donoghue,
Vladimir Zapolskiy
Cc: linux-arm-msm, devicetree, linux-kernel, Depeng Shao
On 4/15/25 9:38 AM, Wenmeng Liu wrote:
> Add support for the camera subsystem on the SM8550 Qualcomm SoC. This
> includes bringing up the CSIPHY, CSID, VFE/RDI interfaces.
>
> SM8550 provides
> - 3 x VFE, 3 RDI per VFE
> - 2 x VFE Lite, 4 RDI per VFE
> - 3 x CSID
> - 2 x CSID Lite
> - 8 x CSI PHY
>
> Co-developed-by: Depeng Shao <quic_depengs@quicinc.com>
> Signed-off-by: Depeng Shao <quic_depengs@quicinc.com>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
[...]
> + <GIC_SPI 604 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 688 IRQ_TYPE_EDGE_RISING>,
It *may* be 689 instead but I'm not 100% sure
Otherwise the numbers look good
Bryan, Vlad, please also take a look
Konrad
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sm8550: Add support for camss
2025-04-30 11:11 ` Konrad Dybcio
@ 2025-05-01 1:15 ` Bryan O'Donoghue
2025-05-16 7:34 ` Wenmeng Liu
0 siblings, 1 reply; 7+ messages in thread
From: Bryan O'Donoghue @ 2025-05-01 1:15 UTC (permalink / raw)
To: Konrad Dybcio, Wenmeng Liu, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bryan O'Donoghue, Vladimir Zapolskiy
Cc: linux-arm-msm, devicetree, linux-kernel, Depeng Shao
On 30/04/2025 12:11, Konrad Dybcio wrote:
> On 4/15/25 9:38 AM, Wenmeng Liu wrote:
>> Add support for the camera subsystem on the SM8550 Qualcomm SoC. This
>> includes bringing up the CSIPHY, CSID, VFE/RDI interfaces.
>>
>> SM8550 provides
>> - 3 x VFE, 3 RDI per VFE
>> - 2 x VFE Lite, 4 RDI per VFE
>> - 3 x CSID
>> - 2 x CSID Lite
>> - 8 x CSI PHY
>>
>> Co-developed-by: Depeng Shao <quic_depengs@quicinc.com>
>> Signed-off-by: Depeng Shao <quic_depengs@quicinc.com>
>> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
>> ---
>
> [...]
>
>> + <GIC_SPI 604 IRQ_TYPE_EDGE_RISING>,
>> + <GIC_SPI 688 IRQ_TYPE_EDGE_RISING>,
>
> It *may* be 689 instead but I'm not 100% sure
>
> Otherwise the numbers look good
>
> Bryan, Vlad, please also take a look
>
> Konrad
>
+ <GIC_SPI 688 IRQ_TYPE_EDGE_RISING>,
This should be 689 yes
---
bod
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sm8550: Add support for camss
2025-05-01 1:15 ` Bryan O'Donoghue
@ 2025-05-16 7:34 ` Wenmeng Liu
2025-05-16 10:15 ` Bryan O'Donoghue
0 siblings, 1 reply; 7+ messages in thread
From: Wenmeng Liu @ 2025-05-16 7:34 UTC (permalink / raw)
To: Bryan O'Donoghue, Konrad Dybcio, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vladimir Zapolskiy
Cc: linux-arm-msm, devicetree, linux-kernel, Depeng Shao
On 2025/5/1 9:15, Bryan O'Donoghue wrote:
> On 30/04/2025 12:11, Konrad Dybcio wrote:
>> On 4/15/25 9:38 AM, Wenmeng Liu wrote:
>>> Add support for the camera subsystem on the SM8550 Qualcomm SoC. This
>>> includes bringing up the CSIPHY, CSID, VFE/RDI interfaces.
>>>
>>> SM8550 provides
>>> - 3 x VFE, 3 RDI per VFE
>>> - 2 x VFE Lite, 4 RDI per VFE
>>> - 3 x CSID
>>> - 2 x CSID Lite
>>> - 8 x CSI PHY
>>>
>>> Co-developed-by: Depeng Shao <quic_depengs@quicinc.com>
>>> Signed-off-by: Depeng Shao <quic_depengs@quicinc.com>
>>> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
>>> ---
>>
>> [...]
>>
>>> + <GIC_SPI 604 IRQ_TYPE_EDGE_RISING>,
>>> + <GIC_SPI 688 IRQ_TYPE_EDGE_RISING>,
>>
>> It *may* be 689 instead but I'm not 100% sure
>>
>> Otherwise the numbers look good
>>
>> Bryan, Vlad, please also take a look
>>
>> Konrad
>>
>
> + <GIC_SPI 688 IRQ_TYPE_EDGE_RISING>,
> This should be 689 yes
>
> ---
> bod
Hi Bryan,Konrad,
I confirmed that the value is 688 instead of 689. The documentation
incorrectly listed it as 689. To CC linux-media, I have resent the patch:
https://lore.kernel.org/linux-arm-msm/20250516072707.388332-1-quic_wenmliu@quicinc.com/
Thanks,
wenmeng
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sm8550: Add support for camss
2025-05-16 7:34 ` Wenmeng Liu
@ 2025-05-16 10:15 ` Bryan O'Donoghue
2025-05-16 10:32 ` Wenmeng Liu
0 siblings, 1 reply; 7+ messages in thread
From: Bryan O'Donoghue @ 2025-05-16 10:15 UTC (permalink / raw)
To: Wenmeng Liu, Konrad Dybcio, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vladimir Zapolskiy
Cc: linux-arm-msm, devicetree, linux-kernel, Depeng Shao
On 16/05/2025 08:34, Wenmeng Liu wrote:
>> This should be 689 yes
>>
>> ---
>> bod
>
> Hi Bryan,Konrad,
>
> I confirmed that the value is 688 instead of 689. The documentation
> incorrectly listed it as 689. To CC linux-media, I have resent the patch:
> https://lore.kernel.org/linux-arm-msm/20250516072707.388332-1-
> quic_wenmliu@quicinc.com/
Do you mean the documentation in the kernel or the documentation inside
of qcom ?
I checked the internal silicon definition, I think Konrad did also.
Which documentation do you mean here ?
---
bod
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sm8550: Add support for camss
2025-05-16 10:15 ` Bryan O'Donoghue
@ 2025-05-16 10:32 ` Wenmeng Liu
2025-05-16 10:41 ` Bryan O'Donoghue
0 siblings, 1 reply; 7+ messages in thread
From: Wenmeng Liu @ 2025-05-16 10:32 UTC (permalink / raw)
To: Bryan O'Donoghue, Konrad Dybcio, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vladimir Zapolskiy
Cc: linux-arm-msm, devicetree, linux-kernel, Depeng Shao
On 2025/5/16 18:15, Bryan O'Donoghue wrote:
> On 16/05/2025 08:34, Wenmeng Liu wrote:
>>> This should be 689 yes
>>>
>>> ---
>>> bod
>>
>> Hi Bryan,Konrad,
>>
>> I confirmed that the value is 688 instead of 689. The documentation
>> incorrectly listed it as 689. To CC linux-media, I have resent the patch:
>> https://lore.kernel.org/linux-arm-msm/20250516072707.388332-1-
>> quic_wenmliu@quicinc.com/
>
> Do you mean the documentation in the kernel or the documentation inside
> of qcom ?
>
> I checked the internal silicon definition, I think Konrad did also.
>
> Which documentation do you mean here ?
>
> ---
> bod
I mean is the ipcat documentation.
And if configured to 689, the interrupt will fail to request:
irq：irq: type mismatch, failed to map hwirq-721 for
interrupt-controller@17100000!
According the mobile configuration, this value should be 688.
Thanks,
Wenmeng
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sm8550: Add support for camss
2025-05-16 10:32 ` Wenmeng Liu
@ 2025-05-16 10:41 ` Bryan O'Donoghue
0 siblings, 0 replies; 7+ messages in thread
From: Bryan O'Donoghue @ 2025-05-16 10:41 UTC (permalink / raw)
To: Wenmeng Liu, Konrad Dybcio, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vladimir Zapolskiy
Cc: linux-arm-msm, devicetree, linux-kernel, Depeng Shao
On 16/05/2025 11:32, Wenmeng Liu wrote:
>
>
> On 2025/5/16 18:15, Bryan O'Donoghue wrote:
>> On 16/05/2025 08:34, Wenmeng Liu wrote:
>>>> This should be 689 yes
>>>>
>>>> ---
>>>> bod
>>>
>>> Hi Bryan,Konrad,
>>>
>>> I confirmed that the value is 688 instead of 689. The documentation
>>> incorrectly listed it as 689. To CC linux-media, I have resent the
>>> patch:
>>> https://lore.kernel.org/linux-arm-msm/20250516072707.388332-1-
>>> quic_wenmliu@quicinc.com/
>>
>> Do you mean the documentation in the kernel or the documentation
>> inside of qcom ?
>>
>> I checked the internal silicon definition, I think Konrad did also.
>>
>> Which documentation do you mean here ?
>>
>> ---
>> bod
>
> I mean is the ipcat documentation.
> And if configured to 689, the interrupt will fail to request:
> irq：irq: type mismatch, failed to map hwirq-721 for interrupt-
> controller@17100000!
>
> According the mobile configuration, this value should be 688.
>
> Thanks,
> Wenmeng
OK, thank you for clarification.
---
bod
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-05-16 10:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-15 7:38 [PATCH] arm64: dts: qcom: sm8550: Add support for camss Wenmeng Liu
2025-04-30 11:11 ` Konrad Dybcio
2025-05-01 1:15 ` Bryan O'Donoghue
2025-05-16 7:34 ` Wenmeng Liu
2025-05-16 10:15 ` Bryan O'Donoghue
2025-05-16 10:32 ` Wenmeng Liu
2025-05-16 10:41 ` Bryan O'Donoghue
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).