From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26EABC04A68 for ; Thu, 28 Jul 2022 13:13:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239072AbiG1NNR (ORCPT ); Thu, 28 Jul 2022 09:13:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236688AbiG1NNQ (ORCPT ); Thu, 28 Jul 2022 09:13:16 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7B172BDE for ; Thu, 28 Jul 2022 06:13:14 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id z13so1919160ljj.6 for ; Thu, 28 Jul 2022 06:13:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=enxGsIYunokJEXPMGCaE1Z7pYtuICaBoKBXgeSWmWds=; b=KnPMKWFuiKPiA/P4vExFpb/yxNCbd6RN4z9b8adLpTi0enYQdO1DCGVCgRRXSZC5Aq lTQJRiT2rver/3W0QAvIbJasWNyvKj5jOGvuGSZ9L7ugDmmtuWPgZiRkF87i839pGiHN FkI57ALLpz6VRvaVAVKLZI/FYYj/Upg4C8T+7DTj6WVkB+S3QGqYG8PplFXF2huPBcPn K9SlgYUChDKy2D7mZm0hVnLB1AA+a84x2krOEb0Tr9YFTHd3ANjZxyWjAg+NisUbkwxR dO4ju2jllwgx2GQNjQBZ8LCO+mRH00lr4tzjMTd3F3ByUX8UNDmfwCm6por0skChclOp 5RNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=enxGsIYunokJEXPMGCaE1Z7pYtuICaBoKBXgeSWmWds=; b=44GGzTuE+sbiroVzyl2FnNLCz/sAm+CkJM8Ny/Y1wYvkeRpW5Rqu1hrg4ai+OJoyGD 0d6lOdpDjo4fga91fjt/+yIkmdwi5hW51m6pmsfn3QlkNrwCSRb7Zm6zF14sdqn7jM9g heDaV00juj+NWoukCI0IUuHDhDMbGibmPH6/RFE5rSCU1ksHS9dMwDX2QNw8TJquCUc2 ADlm516sbNCflKDeko8djh25iGzqKjdIFtP5ZF16zW5jEoXdcsPlqpm5nKOK2pclC0vI i9Rtl0zt1WUyfx2uI0GHeGKpijCpXV/7rncMNDIQuZjl+VGatwMWXU81uFjfd6F0oUpY Ws/A== X-Gm-Message-State: AJIora9WYQhqyLLmxZcgg9QRdV0cFrwmBcHeXWuq1TqWRRXCajW3gvwq ORlJ+jPD0zGubFbFWNmZFwrTsA== X-Google-Smtp-Source: AGRyM1ueWV1tfxf9FVvPLoM/8R4w9qdGdgVWOxGzoYQXpfgmjsGBeWL+qbYnT+dzT+zmLYVcaF3k7Q== X-Received: by 2002:a2e:5741:0:b0:25d:fcb1:d449 with SMTP id r1-20020a2e5741000000b0025dfcb1d449mr7752871ljd.333.1659013992945; Thu, 28 Jul 2022 06:13:12 -0700 (PDT) Received: from [192.168.3.197] (78-26-46-173.network.trollfjord.no. [78.26.46.173]) by smtp.gmail.com with ESMTPSA id d20-20020a193854000000b0048a757d314esm188383lfj.304.2022.07.28.06.13.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jul 2022 06:13:12 -0700 (PDT) Message-ID: <4e89e55b-9312-5525-974b-0a1dbe0b3dd1@linaro.org> Date: Thu, 28 Jul 2022 15:13:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v4 3/7] media: i2c: ov9282: Add ov9281 compatible Content-Language: en-US To: Alexander Stein , "Paul J . Murphy" , Daniele Alessandrelli , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Sakari Ailus References: <20220728130237.3396663-1-alexander.stein@ew.tq-group.com> <20220728130237.3396663-4-alexander.stein@ew.tq-group.com> From: Krzysztof Kozlowski In-Reply-To: <20220728130237.3396663-4-alexander.stein@ew.tq-group.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/07/2022 15:02, Alexander Stein wrote: > According to product brief they are identical from software point of view. > Differences are a different chief ray angle (CRA) and the package. > > Signed-off-by: Alexander Stein > Acked-by: Daniele Alessandrelli > --- > drivers/media/i2c/ov9282.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c > index 8a252bf3b59f..c8d83a29f9bb 100644 > --- a/drivers/media/i2c/ov9282.c > +++ b/drivers/media/i2c/ov9282.c > @@ -1113,6 +1113,7 @@ static const struct dev_pm_ops ov9282_pm_ops = { > }; > > static const struct of_device_id ov9282_of_match[] = { > + { .compatible = "ovti,ov9281" }, The devices seem entirely compatible, so why you add a new compatible and not re-use existing? The difference in lens does not explain this. Best regards, Krzysztof