[PATCH v2] dt-bindings: phy: samsung,ufs-phy: match clock items

[PATCH v2] dt-bindings: phy: samsung,ufs-phy: match clock items

[Chanho Park]

Below error is detected from dtbs_check. exynos7-ufs-phy is required
symbol clocks otherwise only PLL ref clock is required.

clock-names: ['ref_clk'] is too short

Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Suggested-by: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Chanho Park <chanho61.park@samsung.com>
---
Changes since v1:
- Move allOf: block location after required:
- Remove unnecessary spaces of clock descriptions

 .../bindings/phy/samsung,ufs-phy.yaml         | 47 +++++++++++++++----
 1 file changed, 37 insertions(+), 10 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
index 8da99461e817..346eb7cf29a5 100644
--- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
@@ -27,18 +27,12 @@ properties:
       - const: phy-pma
 
   clocks:
-    items:
-      - description: PLL reference clock
-      - description: symbol clock for input symbol ( rx0-ch0 symbol clock)
-      - description: symbol clock for input symbol ( rx1-ch1 symbol clock)
-      - description: symbol clock for output symbol ( tx0 symbol clock)
+    minItems: 1
+    maxItems: 4
 
   clock-names:
-    items:
-      - const: ref_clk
-      - const: rx1_symbol_clk
-      - const: rx0_symbol_clk
-      - const: tx0_symbol_clk
+    minItems: 1
+    maxItems: 4
 
   samsung,pmu-syscon:
     $ref: '/schemas/types.yaml#/definitions/phandle-array'
@@ -62,6 +56,39 @@ required:
   - clock-names
   - samsung,pmu-syscon
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: samsung,exynos7-ufs-phy
+
+    then:
+      properties:
+        clocks:
+          items:
+            - description: PLL reference clock
+            - description: symbol clock for input symbol (rx0-ch0 symbol clock)
+            - description: symbol clock for input symbol (rx1-ch1 symbol clock)
+            - description: symbol clock for output symbol (tx0 symbol clock)
+
+        clock-names:
+          items:
+            - const: ref_clk
+            - const: rx1_symbol_clk
+            - const: rx0_symbol_clk
+            - const: tx0_symbol_clk
+
+    else:
+      properties:
+        clocks:
+          items:
+            - description: PLL reference clock
+
+        clock-names:
+          items:
+            - const: ref_clk
+
 additionalProperties: false
 
 examples:
-- 
2.37.0

Re: [PATCH v2] dt-bindings: phy: samsung,ufs-phy: match clock items

[Krzysztof Kozlowski]

On 07/07/2022 08:28, Chanho Park wrote:
> Below error is detected from dtbs_check. exynos7-ufs-phy is required
> symbol clocks otherwise only PLL ref clock is required.
> 
> clock-names: ['ref_clk'] is too short
> 
> Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Suggested-by: Alim Akhtar <alim.akhtar@samsung.com>
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

RE: [PATCH v2] dt-bindings: phy: samsung,ufs-phy: match clock items

[Chanho Park]

> Subject: Re: [PATCH v2] dt-bindings: phy: samsung,ufs-phy: match clock
> items
> 
> On 07/07/2022 08:28, Chanho Park wrote:
> > Below error is detected from dtbs_check. exynos7-ufs-phy is required
> > symbol clocks otherwise only PLL ref clock is required.
> >
> > clock-names: ['ref_clk'] is too short
> >
> > Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Suggested-by: Alim Akhtar <alim.akhtar@samsung.com>
> > Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> 
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Hi Krzysztof,

No one takes this patch. Could you please pick this patch in your tree?
Thanks.

Best Regards,
Chanho Park

Re: [PATCH v2] dt-bindings: phy: samsung,ufs-phy: match clock items

[Krzysztof Kozlowski]

On 22/07/2022 03:20, Chanho Park wrote:
>> Subject: Re: [PATCH v2] dt-bindings: phy: samsung,ufs-phy: match clock
>> items
>>
>> On 07/07/2022 08:28, Chanho Park wrote:
>>> Below error is detected from dtbs_check. exynos7-ufs-phy is required
>>> symbol clocks otherwise only PLL ref clock is required.
>>>
>>> clock-names: ['ref_clk'] is too short
>>>
>>> Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> Suggested-by: Alim Akhtar <alim.akhtar@samsung.com>
>>> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
>>
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Hi Krzysztof,
> 
> No one takes this patch. Could you please pick this patch in your tree?
> Thanks.

You did not send it to PHY maintainers... The bindings go via subsystem
maintainers.

If Vinod doesn't want it, I could take it, but he never had a chance to
say :)

Please resend.

Best regards,
Krzysztof

RE: [PATCH v2] dt-bindings: phy: samsung,ufs-phy: match clock items

[Chanho Park]

> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >
> > Hi Krzysztof,
> >
> > No one takes this patch. Could you please pick this patch in your tree?
> > Thanks.
> 
> You did not send it to PHY maintainers... The bindings go via subsystem
> maintainers.
> 
> If Vinod doesn't want it, I could take it, but he never had a chance to
> say :)
> 
> Please resend.

Oh, maybe I missed him due to not showing from get_maintainer.pl script.
I'll resend this.

Best Regards,
Chanho Park

Re: [PATCH v2] dt-bindings: phy: samsung,ufs-phy: match clock items

[Vinod Koul]

On 25-07-22, 08:58, Chanho Park wrote:
> > >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > >
> > > Hi Krzysztof,
> > >
> > > No one takes this patch. Could you please pick this patch in your tree?
> > > Thanks.
> > 
> > You did not send it to PHY maintainers... The bindings go via subsystem
> > maintainers.
> > 
> > If Vinod doesn't want it, I could take it, but he never had a chance to
> > say :)
> > 
> > Please resend.
> 
> Oh, maybe I missed him due to not showing from get_maintainer.pl script.

./scripts/get_maintainer.pl Documentation/devicetree/bindings/phy/
Kishon Vijay Abraham I <kishon@ti.com> (supporter:GENERIC PHY FRAMEWORK)
Vinod Koul <vkoul@kernel.org> (supporter:GENERIC PHY FRAMEWORK)

:-|

> I'll resend this.

Pls do..

-- 
~Vinod