* [PATCH v2] dt-bindings: phy: samsung,ufs-phy: match clock items [not found] <CGME20220707063058epcas2p19364a05a5b2fc8aad81fa390ac030f21@epcas2p1.samsung.com> @ 2022-07-07 6:28 ` Chanho Park 2022-07-07 6:34 ` Krzysztof Kozlowski 0 siblings, 1 reply; 6+ messages in thread From: Chanho Park @ 2022-07-07 6:28 UTC (permalink / raw) To: Krzysztof Kozlowski, Rob Herring Cc: Alim Akhtar, devicetree, linux-samsung-soc, linux-arm-kernel, Chanho Park, Krzysztof Kozlowski Below error is detected from dtbs_check. exynos7-ufs-phy is required symbol clocks otherwise only PLL ref clock is required. clock-names: ['ref_clk'] is too short Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Suggested-by: Alim Akhtar <alim.akhtar@samsung.com> Signed-off-by: Chanho Park <chanho61.park@samsung.com> --- Changes since v1: - Move allOf: block location after required: - Remove unnecessary spaces of clock descriptions .../bindings/phy/samsung,ufs-phy.yaml | 47 +++++++++++++++---- 1 file changed, 37 insertions(+), 10 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml index 8da99461e817..346eb7cf29a5 100644 --- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml @@ -27,18 +27,12 @@ properties: - const: phy-pma clocks: - items: - - description: PLL reference clock - - description: symbol clock for input symbol ( rx0-ch0 symbol clock) - - description: symbol clock for input symbol ( rx1-ch1 symbol clock) - - description: symbol clock for output symbol ( tx0 symbol clock) + minItems: 1 + maxItems: 4 clock-names: - items: - - const: ref_clk - - const: rx1_symbol_clk - - const: rx0_symbol_clk - - const: tx0_symbol_clk + minItems: 1 + maxItems: 4 samsung,pmu-syscon: $ref: '/schemas/types.yaml#/definitions/phandle-array' @@ -62,6 +56,39 @@ required: - clock-names - samsung,pmu-syscon +allOf: + - if: + properties: + compatible: + contains: + const: samsung,exynos7-ufs-phy + + then: + properties: + clocks: + items: + - description: PLL reference clock + - description: symbol clock for input symbol (rx0-ch0 symbol clock) + - description: symbol clock for input symbol (rx1-ch1 symbol clock) + - description: symbol clock for output symbol (tx0 symbol clock) + + clock-names: + items: + - const: ref_clk + - const: rx1_symbol_clk + - const: rx0_symbol_clk + - const: tx0_symbol_clk + + else: + properties: + clocks: + items: + - description: PLL reference clock + + clock-names: + items: + - const: ref_clk + additionalProperties: false examples: -- 2.37.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] dt-bindings: phy: samsung,ufs-phy: match clock items 2022-07-07 6:28 ` [PATCH v2] dt-bindings: phy: samsung,ufs-phy: match clock items Chanho Park @ 2022-07-07 6:34 ` Krzysztof Kozlowski 2022-07-22 1:20 ` Chanho Park 0 siblings, 1 reply; 6+ messages in thread From: Krzysztof Kozlowski @ 2022-07-07 6:34 UTC (permalink / raw) To: Chanho Park, Krzysztof Kozlowski, Rob Herring Cc: Alim Akhtar, devicetree, linux-samsung-soc, linux-arm-kernel On 07/07/2022 08:28, Chanho Park wrote: > Below error is detected from dtbs_check. exynos7-ufs-phy is required > symbol clocks otherwise only PLL ref clock is required. > > clock-names: ['ref_clk'] is too short > > Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Suggested-by: Alim Akhtar <alim.akhtar@samsung.com> > Signed-off-by: Chanho Park <chanho61.park@samsung.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2] dt-bindings: phy: samsung,ufs-phy: match clock items 2022-07-07 6:34 ` Krzysztof Kozlowski @ 2022-07-22 1:20 ` Chanho Park 2022-07-22 17:32 ` Krzysztof Kozlowski 0 siblings, 1 reply; 6+ messages in thread From: Chanho Park @ 2022-07-22 1:20 UTC (permalink / raw) To: 'Krzysztof Kozlowski', 'Krzysztof Kozlowski', 'Rob Herring' Cc: 'Alim Akhtar', devicetree, linux-samsung-soc, linux-arm-kernel > Subject: Re: [PATCH v2] dt-bindings: phy: samsung,ufs-phy: match clock > items > > On 07/07/2022 08:28, Chanho Park wrote: > > Below error is detected from dtbs_check. exynos7-ufs-phy is required > > symbol clocks otherwise only PLL ref clock is required. > > > > clock-names: ['ref_clk'] is too short > > > > Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Suggested-by: Alim Akhtar <alim.akhtar@samsung.com> > > Signed-off-by: Chanho Park <chanho61.park@samsung.com> > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Hi Krzysztof, No one takes this patch. Could you please pick this patch in your tree? Thanks. Best Regards, Chanho Park ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] dt-bindings: phy: samsung,ufs-phy: match clock items 2022-07-22 1:20 ` Chanho Park @ 2022-07-22 17:32 ` Krzysztof Kozlowski 2022-07-24 23:58 ` Chanho Park 0 siblings, 1 reply; 6+ messages in thread From: Krzysztof Kozlowski @ 2022-07-22 17:32 UTC (permalink / raw) To: Chanho Park, 'Krzysztof Kozlowski', 'Rob Herring' Cc: 'Alim Akhtar', devicetree, linux-samsung-soc, linux-arm-kernel On 22/07/2022 03:20, Chanho Park wrote: >> Subject: Re: [PATCH v2] dt-bindings: phy: samsung,ufs-phy: match clock >> items >> >> On 07/07/2022 08:28, Chanho Park wrote: >>> Below error is detected from dtbs_check. exynos7-ufs-phy is required >>> symbol clocks otherwise only PLL ref clock is required. >>> >>> clock-names: ['ref_clk'] is too short >>> >>> Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> Suggested-by: Alim Akhtar <alim.akhtar@samsung.com> >>> Signed-off-by: Chanho Park <chanho61.park@samsung.com> >> >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Hi Krzysztof, > > No one takes this patch. Could you please pick this patch in your tree? > Thanks. You did not send it to PHY maintainers... The bindings go via subsystem maintainers. If Vinod doesn't want it, I could take it, but he never had a chance to say :) Please resend. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2] dt-bindings: phy: samsung,ufs-phy: match clock items 2022-07-22 17:32 ` Krzysztof Kozlowski @ 2022-07-24 23:58 ` Chanho Park 2022-07-25 7:36 ` Vinod Koul 0 siblings, 1 reply; 6+ messages in thread From: Chanho Park @ 2022-07-24 23:58 UTC (permalink / raw) To: 'Krzysztof Kozlowski', 'Krzysztof Kozlowski', 'Rob Herring' Cc: 'Alim Akhtar', devicetree, linux-samsung-soc, linux-arm-kernel, vkoul > >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > Hi Krzysztof, > > > > No one takes this patch. Could you please pick this patch in your tree? > > Thanks. > > You did not send it to PHY maintainers... The bindings go via subsystem > maintainers. > > If Vinod doesn't want it, I could take it, but he never had a chance to > say :) > > Please resend. Oh, maybe I missed him due to not showing from get_maintainer.pl script. I'll resend this. Best Regards, Chanho Park ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] dt-bindings: phy: samsung,ufs-phy: match clock items 2022-07-24 23:58 ` Chanho Park @ 2022-07-25 7:36 ` Vinod Koul 0 siblings, 0 replies; 6+ messages in thread From: Vinod Koul @ 2022-07-25 7:36 UTC (permalink / raw) To: Chanho Park Cc: 'Krzysztof Kozlowski', 'Krzysztof Kozlowski', 'Rob Herring', 'Alim Akhtar', devicetree, linux-samsung-soc, linux-arm-kernel On 25-07-22, 08:58, Chanho Park wrote: > > >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > > > Hi Krzysztof, > > > > > > No one takes this patch. Could you please pick this patch in your tree? > > > Thanks. > > > > You did not send it to PHY maintainers... The bindings go via subsystem > > maintainers. > > > > If Vinod doesn't want it, I could take it, but he never had a chance to > > say :) > > > > Please resend. > > Oh, maybe I missed him due to not showing from get_maintainer.pl script. ./scripts/get_maintainer.pl Documentation/devicetree/bindings/phy/ Kishon Vijay Abraham I <kishon@ti.com> (supporter:GENERIC PHY FRAMEWORK) Vinod Koul <vkoul@kernel.org> (supporter:GENERIC PHY FRAMEWORK) :-| > I'll resend this. Pls do.. -- ~Vinod ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-25 7:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20220707063058epcas2p19364a05a5b2fc8aad81fa390ac030f21@epcas2p1.samsung.com>
2022-07-07 6:28 ` [PATCH v2] dt-bindings: phy: samsung,ufs-phy: match clock items Chanho Park
2022-07-07 6:34 ` Krzysztof Kozlowski
2022-07-22 1:20 ` Chanho Park
2022-07-22 17:32 ` Krzysztof Kozlowski
2022-07-24 23:58 ` Chanho Park
2022-07-25 7:36 ` Vinod Koul
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).