* [PATCH v5 0/2] power: supply: Add STC3117 Fuel Gauge
@ 2024-11-29 11:40 Bhavin Sharma
2024-11-29 11:40 ` [PATCH v5 1/2] dt-bindings: " Bhavin Sharma
2024-11-29 11:40 ` [PATCH v5 2/2] power: supply: Add STC3117 fuel gauge unit driver Bhavin Sharma
0 siblings, 2 replies; 7+ messages in thread
From: Bhavin Sharma @ 2024-11-29 11:40 UTC (permalink / raw)
To: sre, krzk+dt
Cc: Bhavin Sharma, Rob Herring, Conor Dooley, Hardevsinh Palaniya,
linux-pm, devicetree, linux-kernel
Adds initial support for the STC3117 fuel gauge.
v4 -> v5
- Fix variable names
- Limit code line length to 80 columns
- Add interrupt and monitor-battery properties to bindings
- Correct error handling with return dev_err_probe()
Link for v4: https://lore.kernel.org/linux-pm/21c08a45-34f1-443c-97d4-6baf9fa01b67@kernel.org/T/#t
v3 -> v4
- Added support for current, soc, temp, and status properties.
- Addressed comments and feedback provided by Krzysztof and Sebastian.
Link for v3: https://lore.kernel.org/linux-pm/20240205051321.4079933-1-bhavin.sharma@siliconsignals.io/T/#t
v2 -> v3
- Resolved DTC warnings and errors
- Formatted the changelogs
- Added monitored battery properties
- Replaced 'additionalProperties' with 'unevaluatedProperties'
- Replaced '&i2c6' with 'i2c'
Link for v2: https://lore.kernel.org/linux-pm/202401080530.0hMWnrIg-lkp@intel.com/T/#t
v1 -> v2
- String value is redundantly quoted with any quotes (quoted-strings)
- Found character '\t' that cannot start any token
Link for v1: https://lore.kernel.org/linux-pm/46bba29c-330d-417d-ad84-ceb5207fdb55@wanadoo.fr/T/#t
Hardevsinh Palaniya(1):
dt-bindings: power: supply: Add STC3117 Fuel Gauge
Bhavin Sharma (2):
power: supply: Add STC3117 fuel gauge unit driver
.../bindings/power/supply/st,stc3117.yaml | 81 +++
MAINTAINERS | 8 +
drivers/power/supply/Kconfig | 7 +
drivers/power/supply/Makefile | 1 +
drivers/power/supply/stc3117_fuel_gauge.c | 665 ++++++++++++++++++
5 files changed, 762 insertions(+)
create mode 100644 Documentation/devicetree/bindings/power/supply/st,stc3117.yaml
create mode 100644 drivers/power/supply/stc3117_fuel_gauge.c
--
2.43.0
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v5 1/2] dt-bindings: power: supply: Add STC3117 Fuel Gauge 2024-11-29 11:40 [PATCH v5 0/2] power: supply: Add STC3117 Fuel Gauge Bhavin Sharma @ 2024-11-29 11:40 ` Bhavin Sharma 2024-11-29 11:48 ` Krzysztof Kozlowski 2024-11-29 12:16 ` Rob Herring (Arm) 2024-11-29 11:40 ` [PATCH v5 2/2] power: supply: Add STC3117 fuel gauge unit driver Bhavin Sharma 1 sibling, 2 replies; 7+ messages in thread From: Bhavin Sharma @ 2024-11-29 11:40 UTC (permalink / raw) To: sre, krzk+dt Cc: Bhavin Sharma, Hardevsinh Palaniya, Rob Herring, Conor Dooley, linux-pm, devicetree, linux-kernel The STC3117 provides a simple fuel gauge via I2C. Add a DT schema to describe how to set it up in the device tree. Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io> Signed-off-by: Bhavin Sharma <bhavin.sharma@siliconsignals.io> --- .../bindings/power/supply/st,stc3117.yaml | 81 +++++++++++++++++++ 1 file changed, 81 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/st,stc3117.yaml diff --git a/Documentation/devicetree/bindings/power/supply/st,stc3117.yaml b/Documentation/devicetree/bindings/power/supply/st,stc3117.yaml new file mode 100644 index 000000000000..274e57be4bc6 --- /dev/null +++ b/Documentation/devicetree/bindings/power/supply/st,stc3117.yaml @@ -0,0 +1,81 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/supply/st,stc3117.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: STMicroelectronics STC3117 Fuel Gauge Unit Power Supply + +maintainers: + - Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io> + - Bhavin Sharma <bhavin.sharma@siliconsignals.io> + +description: | + The STC3117 includes the STMicroelectronics OptimGauge algorithm. + It provides accurate battery state-of-charge (SOC) monitoring, tracks + battery parameter changes with operation conditions, temperature, + and aging, and allows the application to get a battery state-of-health + (SOH) indication. + + An alarm output signals low SOC or low voltage conditions and also + indicates fault conditions like a missing or swapped battery. + + Datasheet is available at + https://www.st.com/resource/en/datasheet/stc3117.pdf + +allOf: + - $ref: power-supply.yaml# + +properties: + compatible: + enum: + - st,stc3117 + + reg: + maxItems: 1 + + monitored-battery: + description: | + The fuel gauge uses the following battery properties: + - charge-full-design-microamp-hours + - voltage-min-design-microvolt + - voltage-max-design-microvolt + + sense-resistor: + $ref: /schemas/types.yaml#/definitions/phandle + description: Current sense resistor in milliohms + maxItems: 1 + + interrupts: + maxItems: 1 + +required: + - compatible + - reg + - monitored-battery + - sense-resistor + +unevaluatedProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + bat: battery { + compatible = "simple-battery"; + charge-full-design-microamp-hours = <2600000>; + voltage-min-design-microvolt = <3300000>; + voltage-max-design-microvolt = <4250000>; + }; + + battery@70 { + compatible = "st,stc3117"; + reg = <0x70>; + interrupt-parent = <&gpio0>; + interrupts = <31 IRQ_TYPE_LEVEL_LOW>; + monitored-battery = <&bat>; + sense-resistor = <10>; + }; + }; -- 2.43.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v5 1/2] dt-bindings: power: supply: Add STC3117 Fuel Gauge 2024-11-29 11:40 ` [PATCH v5 1/2] dt-bindings: " Bhavin Sharma @ 2024-11-29 11:48 ` Krzysztof Kozlowski 2024-11-29 12:17 ` Bhavin Sharma 2024-11-29 12:16 ` Rob Herring (Arm) 1 sibling, 1 reply; 7+ messages in thread From: Krzysztof Kozlowski @ 2024-11-29 11:48 UTC (permalink / raw) To: Bhavin Sharma, sre, krzk+dt Cc: Hardevsinh Palaniya, Rob Herring, Conor Dooley, linux-pm, devicetree, linux-kernel On 29/11/2024 12:40, Bhavin Sharma wrote: > The STC3117 provides a simple fuel gauge via I2C. > Add a DT schema to describe how to set it up in the device tree. > > Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io> > Signed-off-by: Bhavin Sharma <bhavin.sharma@siliconsignals.io> Your SoBs are odd... second patch has totally reversed path comparing to this one. What do you want to express here? > --- > .../bindings/power/supply/st,stc3117.yaml | 81 +++++++++++++++++++ > 1 file changed, 81 insertions(+) > + > + monitored-battery: > + description: | > + The fuel gauge uses the following battery properties: > + - charge-full-design-microamp-hours > + - voltage-min-design-microvolt > + - voltage-max-design-microvolt > + > + sense-resistor: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: Current sense resistor in milliohms phandle cannot be in milliohms... Anyway, use existing widely used property: shunt-resistor-micro-ohms > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - monitored-battery > + - sense-resistor > + > +unevaluatedProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + bat: battery { > + compatible = "simple-battery"; > + charge-full-design-microamp-hours = <2600000>; > + voltage-min-design-microvolt = <3300000>; > + voltage-max-design-microvolt = <4250000>; > + }; Drop battery node, not needed for example. > + > + battery@70 { > + compatible = "st,stc3117"; > + reg = <0x70>; > + interrupt-parent = <&gpio0>; > + interrupts = <31 IRQ_TYPE_LEVEL_LOW>; It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v5 1/2] dt-bindings: power: supply: Add STC3117 Fuel Gauge 2024-11-29 11:48 ` Krzysztof Kozlowski @ 2024-11-29 12:17 ` Bhavin Sharma 0 siblings, 0 replies; 7+ messages in thread From: Bhavin Sharma @ 2024-11-29 12:17 UTC (permalink / raw) To: Krzysztof Kozlowski, sre@kernel.org, krzk+dt@kernel.org Cc: Hardevsinh Palaniya, Rob Herring, Conor Dooley, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Hi Krzysztof, Thanks for the review > > Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io> > > Signed-off-by: Bhavin Sharma <bhavin.sharma@siliconsignals.io> > > Your SoBs are odd... second patch has totally reversed path comparing to > this one. What do you want to express here? i will correct the order > > + sense-resistor: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: Current sense resistor in milliohms > > phandle cannot be in milliohms... Anyway, use existing widely used > property: shunt-resistor-micro-ohms okay > > + bat: battery { > > + compatible = "simple-battery"; > > + charge-full-design-microamp-hours = <2600000>; > > + voltage-min-design-microvolt = <3300000>; > > + voltage-max-design-microvolt = <4250000>; > > + }; > > Drop battery node, not needed for example. okay > > + battery@70 { > > + compatible = "st,stc3117"; > > + reg = <0x70>; > > + interrupt-parent = <&gpio0>; > > + interrupts = <31 IRQ_TYPE_LEVEL_LOW>; > > It does not look like you tested the bindings, at least after quick > look. Please run `make dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > Maybe you need to update your dtschema and yamllint. ohh yes , need to add bindings for interrupt Best Regards, Bhavin ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v5 1/2] dt-bindings: power: supply: Add STC3117 Fuel Gauge 2024-11-29 11:40 ` [PATCH v5 1/2] dt-bindings: " Bhavin Sharma 2024-11-29 11:48 ` Krzysztof Kozlowski @ 2024-11-29 12:16 ` Rob Herring (Arm) 1 sibling, 0 replies; 7+ messages in thread From: Rob Herring (Arm) @ 2024-11-29 12:16 UTC (permalink / raw) To: Bhavin Sharma Cc: Hardevsinh Palaniya, devicetree, linux-pm, linux-kernel, Conor Dooley, krzk+dt, sre On Fri, 29 Nov 2024 17:10:45 +0530, Bhavin Sharma wrote: > The STC3117 provides a simple fuel gauge via I2C. > Add a DT schema to describe how to set it up in the device tree. > > Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io> > Signed-off-by: Bhavin Sharma <bhavin.sharma@siliconsignals.io> > --- > .../bindings/power/supply/st,stc3117.yaml | 81 +++++++++++++++++++ > 1 file changed, 81 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/st,stc3117.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/st,stc3117.yaml: properties:sense-resistor:maxItems: False schema does not allow 1 hint: Scalar properties should not have array keywords from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# Error: Documentation/devicetree/bindings/power/supply/st,stc3117.example.dts:39.30-31 syntax error FATAL ERROR: Unable to parse input tree make[2]: *** [scripts/Makefile.dtbs:129: Documentation/devicetree/bindings/power/supply/st,stc3117.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1442: dt_binding_check] Error 2 make: *** [Makefile:224: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241129114200.13351-2-bhavin.sharma@siliconsignals.io The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v5 2/2] power: supply: Add STC3117 fuel gauge unit driver 2024-11-29 11:40 [PATCH v5 0/2] power: supply: Add STC3117 Fuel Gauge Bhavin Sharma 2024-11-29 11:40 ` [PATCH v5 1/2] dt-bindings: " Bhavin Sharma @ 2024-11-29 11:40 ` Bhavin Sharma 2024-11-30 17:47 ` Christophe JAILLET 1 sibling, 1 reply; 7+ messages in thread From: Bhavin Sharma @ 2024-11-29 11:40 UTC (permalink / raw) To: sre, krzk+dt Cc: Bhavin Sharma, Hardevsinh Palaniya, Rob Herring, Conor Dooley, linux-pm, devicetree, linux-kernel Adds initial support for the STC3117 fuel gauge. The driver provides functionality to monitor key parameters including: - Voltage - Current - State of Charge (SOC) - Temperature - Status Signed-off-by: Bhavin Sharma <bhavin.sharma@siliconsignals.io> Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io> --- MAINTAINERS | 8 + drivers/power/supply/Kconfig | 7 + drivers/power/supply/Makefile | 1 + drivers/power/supply/stc3117_fuel_gauge.c | 665 ++++++++++++++++++++++ 4 files changed, 681 insertions(+) create mode 100644 drivers/power/supply/stc3117_fuel_gauge.c diff --git a/MAINTAINERS b/MAINTAINERS index 82161bc70b51..1eab5179871d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -21855,6 +21855,14 @@ T: git git://linuxtv.org/media_tree.git F: Documentation/devicetree/bindings/media/i2c/st,st-mipid02.yaml F: drivers/media/i2c/st-mipid02.c +ST STC3117 FUEL GAUGE DRIVER +M: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io> +M: Bhavin Sharma <bhavin.sharma@siliconsignals.io> +L: linux-pm@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/power/supply/st,stc3117.yaml +F: drivers/power/supply/stc3117_fuel_gauge.c + ST STM32 FIREWALL M: Gatien Chevallier <gatien.chevallier@foss.st.com> S: Maintained diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig index bcfa63fb9f1e..68d8aa848f7b 100644 --- a/drivers/power/supply/Kconfig +++ b/drivers/power/supply/Kconfig @@ -908,6 +908,13 @@ config FUEL_GAUGE_SC27XX Say Y here to enable support for fuel gauge with SC27XX PMIC chips. +config FUEL_GAUGE_STC3117 + tristate "STMicroelectronics STC3117 fuel gauge driver" + depends on I2C + help + Say Y here to enable support for fuel gauge with STC3117 + chip. + config CHARGER_UCS1002 tristate "Microchip UCS1002 USB Port Power Controller" depends on I2C diff --git a/drivers/power/supply/Makefile b/drivers/power/supply/Makefile index 8dcb41545317..5b4633e5818d 100644 --- a/drivers/power/supply/Makefile +++ b/drivers/power/supply/Makefile @@ -107,6 +107,7 @@ obj-$(CONFIG_CHARGER_CROS_USBPD) += cros_usbpd-charger.o obj-$(CONFIG_CHARGER_CROS_PCHG) += cros_peripheral_charger.o obj-$(CONFIG_CHARGER_SC2731) += sc2731_charger.o obj-$(CONFIG_FUEL_GAUGE_SC27XX) += sc27xx_fuel_gauge.o +obj-$(CONFIG_FUEL_GAUGE_STC3117) += stc3117_fuel_gauge.o obj-$(CONFIG_CHARGER_UCS1002) += ucs1002_power.o obj-$(CONFIG_CHARGER_BD99954) += bd99954-charger.o obj-$(CONFIG_CHARGER_WILCO) += wilco-charger.o diff --git a/drivers/power/supply/stc3117_fuel_gauge.c b/drivers/power/supply/stc3117_fuel_gauge.c new file mode 100644 index 000000000000..b6b1b4f24ea2 --- /dev/null +++ b/drivers/power/supply/stc3117_fuel_gauge.c @@ -0,0 +-2,662 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * stc3117_fuel_gauge.c - STMicroelectronics STC3117 Fuel Gauge Driver + * + * Copyright (c) 2024 Silicon Signals Pvt Ltd. + * Author: Bhavin Sharma <bhavin.sharma@siliconsignals.io> + * Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.com> + */ + +#include <linux/i2c.h> +#include <linux/workqueue.h> +#include <linux/power_supply.h> +#include <linux/regmap.h> +#include <linux/crc8.h> + +#define STC3117_ADDR_MODE 0x00 +#define STC3117_ADDR_CTRL 0x01 +#define STC3117_ADDR_SOC_L 0x02 +#define STC3117_ADDR_SOC_H 0x03 +#define STC3117_ADDR_COUNTER_L 0x04 +#define STC3117_ADDR_COUNTER_H 0x05 +#define STC3117_ADDR_CURRENT_L 0x06 +#define STC3117_ADDR_CURRENT_H 0x07 +#define STC3117_ADDR_VOLTAGE_L 0x08 +#define STC3117_ADDR_VOLTAGE_H 0x09 +#define STC3117_ADDR_TEMPERATURE 0x0A +#define STC3117_ADDR_AVG_CURRENT_L 0X0B +#define STC3117_ADDR_AVG_CURRENT_H 0X0C +#define STC3117_ADDR_OCV_L 0X0D +#define STC3117_ADDR_OCV_H 0X0E +#define STC3117_ADDR_CC_CNF_L 0X0F +#define STC3117_ADDR_CC_CNF_H 0X10 +#define STC3117_ADDR_VM_CNF_L 0X11 +#define STC3117_ADDR_VM_CNF_H 0X12 +#define STC3117_ADDR_ALARM_soc 0X13 +#define STC3117_ADDR_ALARM_VOLTAGE 0X14 +#define STC3117_ADDR_ID 0X18 +#define STC3117_ADDR_CC_ADJ_L 0X1B +#define STC3117_ADDR_CC_ADJ_H 0X1C +#define STC3117_ADDR_VM_ADJ_L 0X1D +#define STC3117_ADDR_VM_ADJ_H 0X1E +#define STC3117_ADDR_RAM 0x20 +#define STC3117_ADDR_OCV_TABLE 0x30 +#define STC3117_ADDR_SOC_TABLE 0x30 + +/* Bit mask definition */ +#define STC3117_ID 0x16 +#define STC3117_MIXED_MODE 0x00 +#define STC3117_VMODE BIT(0) +#define STC3117_GG_RUN BIT(4) +#define STC3117_CC_MODE BIT(5) +#define STC3117_BATFAIL BIT(3) +#define STC3117_PORDET BIT(4) +#define STC3117_RAM_SIZE 16 +#define STC3117_OCV_TABLE_SIZE 16 +#define STC3117_RAM_TESTWORD 0x53A9 +#define STC3117_SOFT_RESET 0x11 +#define STC3117_NOMINAL_CAPACITY 2600 + +#define VOLTAGE_LSB_VALUE 9011 +#define CURRENT_LSB_VALUE 24084 +#define APP_CUTOFF_VOLTAGE 2500 +#define MAX_HRSOC 51200 +#define MAX_SOC 1000 +#define CHG_MIN_CURRENT 200 +#define CHG_END_CURRENT 20 +#define APP_MIN_CURRENT (-5) +#define BATTERY_FULL 95 +#define CRC8_POLYNOMIAL 0x07 +#define CRC8_INIT 0x00 + +DECLARE_CRC8_TABLE(stc3117_crc_table); + +enum stc3117_state { + STC3117_INIT, + STC3117_RUNNING, + STC3117_POWERDN, +}; + +enum stc3117_status { + BATT_LOWBATT = -2, + BATT_DISCHARG, + BATT_IDLE, + BATT_FULCHARG, + BATT_ENDCHARG, + BATT_CHARGING, +}; + +/* Default ocv curve Li-ion battery */ +static const int ocvValue[16] = { + 3400, 3582, 3669, 3676, 3699, 3737, 3757, 3774, + 3804, 3844, 3936, 3984, 4028, 4131, 4246, 4320 +}; + +static union stc3117_internal_ram { + u8 ram_bytes[STC3117_RAM_SIZE]; + struct { + u16 testword; /* 0-1 Bytes */ + u16 hrsoc; /* 2-3 Bytes */ + u16 cc_cnf; /* 4-5 Bytes */ + u16 vm_cnf; /* 6-7 Bytes */ + u8 soc; /* 8 Byte */ + u8 state; /* 9 Byte */ + u8 unused[5]; /* 10-14 Bytes */ + u8 crc; /* 15 Byte */ + } reg; +} ram_data; + +struct stc3117_data { + struct i2c_client *client; + struct regmap *regmap; + struct delayed_work update_work; + struct power_supply *battery; + + u8 soc_tab[16]; + int cc_cnf; + int vm_cnf; + int cc_adj; + int vm_adj; + int avg_current; + int avg_voltage; + int batt_current; + int voltage; + int temp; + int soc; + int ocv; + int hrsoc; + int presence; + int battery_state; +}; + +struct stc3117_battery_info { + int voltage_min; + int voltage_max; + int battery_capacity; + int sense_resistor; +} battery_info; + +static int STC3117_convert(int value, int factor) +{ + value = (value * factor) / 4096; + return value; +} + +static int stc3117_get_battery_data(struct stc3117_data *data) +{ + u8 reg_list[16]; + u8 data_adjust[4]; + int value, mode; + + regmap_bulk_read(data->regmap, STC3117_ADDR_MODE, + reg_list, sizeof(reg_list)); + + /* soc */ + value = (reg_list[3] << 8) + reg_list[2]; + data->hrsoc = value; + data->soc = (value * 10 + 256) / 512; + + /* cureent in mA*/ + value = (reg_list[7] << 8) + reg_list[6]; + data->batt_current = STC3117_convert(value, + CURRENT_LSB_VALUE / battery_info.sense_resistor); + + /* voltage in mV */ + value = (reg_list[9] << 8) + reg_list[8]; + data->voltage = STC3117_convert(value, VOLTAGE_LSB_VALUE); + + /* temp */ + data->temp = reg_list[10]; + + /* Avg batt_current in mA */ + value = (reg_list[12] << 8) + reg_list[11]; + regmap_read(data->regmap, STC3117_ADDR_MODE, &mode); + if (!(mode & STC3117_VMODE)) { + value = STC3117_convert(value, CURRENT_LSB_VALUE / 10); + value = value / 4; + } else { + value = STC3117_convert(value, 36 * STC3117_NOMINAL_CAPACITY); + } + data->avg_current = value; + + /* ocv */ + value = (reg_list[14] << 8) + reg_list[13]; + value = STC3117_convert(value, VOLTAGE_LSB_VALUE); + value = (value + 2) / 4; + data->ocv = value; + + /* CC & VM adjustment counters */ + regmap_bulk_read(data->regmap, STC3117_ADDR_CC_ADJ_L, + data_adjust, sizeof(data_adjust)); + value = (data_adjust[1] << 8) + data_adjust[0]; + data->cc_adj = value; + + value = (data_adjust[3] << 8) + data_adjust[2]; + data->vm_adj = value; + + return 0; +} + +static int stc3117_update_battery_status(struct stc3117_data *data) +{ + switch (data->battery_state) { + case BATT_CHARGING: + if (data->avg_current < CHG_MIN_CURRENT) + data->battery_state = BATT_ENDCHARG; + break; + + case BATT_ENDCHARG: + if (data->batt_current > CHG_MIN_CURRENT) + data->battery_state = BATT_CHARGING; + else if (data->avg_current < CHG_END_CURRENT) + data->battery_state = BATT_IDLE; + else if ((data->batt_current > CHG_END_CURRENT) && + (data->voltage > battery_info.voltage_max)) + data->battery_state = BATT_FULCHARG; + break; + + case BATT_FULCHARG: + if ((data->batt_current > CHG_MIN_CURRENT)) + data->battery_state = BATT_CHARGING; + else if (data->avg_current < CHG_END_CURRENT) { + if (data->avg_voltage > battery_info.voltage_max) + { + regmap_write(data->regmap, STC3117_ADDR_SOC_H, + (MAX_HRSOC >> 8 & 0xFF)); + regmap_write(data->regmap, STC3117_ADDR_SOC_L, + (MAX_HRSOC & 0xFF)); + data->soc = MAX_SOC; + } + data->battery_state = BATT_IDLE; + } + break; + + case BATT_IDLE: + if (data->batt_current > CHG_END_CURRENT) + data->battery_state = BATT_CHARGING; + else if (data->batt_current < APP_MIN_CURRENT) + data->battery_state = BATT_DISCHARG; + break; + + case BATT_DISCHARG: + if (data->batt_current > APP_MIN_CURRENT) + data->battery_state = BATT_IDLE; + else if (data->avg_voltage < battery_info.voltage_min) + data->battery_state = BATT_LOWBATT; + break; + + case BATT_LOWBATT: + if (data->avg_voltage > (battery_info.voltage_min + 50)) + data->battery_state = BATT_IDLE; + break; + + default: + data->battery_state = BATT_IDLE; + } + + return 0; +} + +static int ram_write(struct stc3117_data *data) +{ + int ret; + + ret = regmap_bulk_write(data->regmap, STC3117_ADDR_RAM, + ram_data.ram_bytes, STC3117_RAM_SIZE); + if (ret) + return ret; + + return 0; +}; + +static int ram_read(struct stc3117_data *data) +{ + int ret; + + ret = regmap_bulk_read(data->regmap, STC3117_ADDR_RAM, + ram_data.ram_bytes, STC3117_RAM_SIZE); + if (ret) + return ret; + + return 0; +}; + +static int stc3117_set_para(struct stc3117_data *data) +{ + int ret; + + ret = regmap_write(data->regmap, STC3117_ADDR_MODE, STC3117_VMODE); + + for (int i = 0; i < STC3117_OCV_TABLE_SIZE; i++) + regmap_write(data->regmap, STC3117_ADDR_OCV_TABLE + i, + ocvValue[i] * 100 / 55); + if (data->soc_tab[1] != 0) + regmap_bulk_write(data->regmap, STC3117_ADDR_SOC_TABLE, + data->soc_tab, STC3117_OCV_TABLE_SIZE); + + ret |= regmap_write(data->regmap, STC3117_ADDR_CC_CNF_H, + (ram_data.reg.cc_cnf >> 8) & 0xFF); + + ret |= regmap_write(data->regmap, STC3117_ADDR_CC_CNF_L, + ram_data.reg.cc_cnf & 0xFF); + + ret |= regmap_write(data->regmap, STC3117_ADDR_VM_CNF_H, + (ram_data.reg.vm_cnf >> 8) & 0xFF); + + ret |= regmap_write(data->regmap, STC3117_ADDR_VM_CNF_L, + ram_data.reg.vm_cnf & 0xFF); + + ret |= regmap_write(data->regmap, STC3117_ADDR_CTRL, 0x03); + + ret |= regmap_write(data->regmap, STC3117_ADDR_MODE, + STC3117_MIXED_MODE | STC3117_GG_RUN); + + return ret; +}; + +static int stc3117_init(struct stc3117_data *data) +{ + int ID, ret; + int ctrl; + int ocv_m, ocv_l; + + regmap_read(data->regmap, STC3117_ADDR_ID, &ID); + if (ID != STC3117_ID) + return -EINVAL; + + data->cc_cnf = (battery_info.battery_capacity * + battery_info.sense_resistor * 250 + 6194) / 12389; + data->vm_cnf = (battery_info.battery_capacity * 200 * 50 + 24444) / 48889; + + /* Battery has not been removed */ + data->presence = 1; + + /* Read RAM data */ + ret = ram_read(data); + if (ret) + return ret; + + if ((ram_data.reg.testword != STC3117_RAM_TESTWORD) || + (crc8(stc3117_crc_table, ram_data.ram_bytes, + STC3117_RAM_SIZE, CRC8_INIT)) != 0) + { + ram_data.reg.testword = STC3117_RAM_TESTWORD; + ram_data.reg.cc_cnf = data->cc_cnf; + ram_data.reg.vm_cnf = data->vm_cnf; + ram_data.reg.crc = crc8(stc3117_crc_table, ram_data.ram_bytes, + STC3117_RAM_SIZE - 1, CRC8_INIT); + + ret = regmap_read(data->regmap, STC3117_ADDR_OCV_H, &ocv_m); + + ret |= regmap_read(data->regmap, STC3117_ADDR_OCV_L, &ocv_l); + + ret |= stc3117_set_para(data); + + ret |= regmap_write(data->regmap, STC3117_ADDR_OCV_H, ocv_m); + + ret |= regmap_write(data->regmap, STC3117_ADDR_OCV_L, ocv_l); + if (ret) + return ret; + } else { + ret = regmap_read(data->regmap, STC3117_ADDR_CTRL, &ctrl); + if ((ctrl & STC3117_BATFAIL) != 0 || (ctrl & STC3117_PORDET) != 0) + { + ret = regmap_read(data->regmap, STC3117_ADDR_OCV_H, &ocv_m); + + ret |= regmap_read(data->regmap, STC3117_ADDR_OCV_L, &ocv_l); + + ret |= stc3117_set_para(data); + + ret |= regmap_write(data->regmap, STC3117_ADDR_OCV_H, ocv_m); + + ret |= regmap_write(data->regmap, STC3117_ADDR_OCV_L, ocv_l); + if (ret) + return ret; + } else { + ret = stc3117_set_para(data); + if (ret) + return ret; + regmap_write(data->regmap, STC3117_ADDR_SOC_H, + (ram_data.reg.hrsoc >> 8 & 0xFF)); + regmap_write(data->regmap, STC3117_ADDR_SOC_L, + (ram_data.reg.hrsoc & 0xFF)); + } + } + + ram_data.reg.state = STC3117_INIT; + ram_data.reg.crc = crc8(stc3117_crc_table, ram_data.ram_bytes, + STC3117_RAM_SIZE - 1, CRC8_INIT); + ret = ram_write(data); + if (ret) + return ret; + + data->battery_state = BATT_IDLE; + + return 0; +}; + +static int stc3117_task(struct stc3117_data *data) +{ + int ID, mode, ret; + int count_l, count_m; + int ocv_l, ocv_m; + + regmap_read(data->regmap, STC3117_ADDR_ID, &ID); + if (ID != STC3117_ID) { + data->presence = 0; + return -EINVAL; + } + + stc3117_get_battery_data(data); + + /* Read RAM data */ + ret = ram_read(data); + if (ret) + return ret; + + if ((ram_data.reg.testword != STC3117_RAM_TESTWORD) || + (crc8(stc3117_crc_table, ram_data.ram_bytes, + STC3117_RAM_SIZE, CRC8_INIT) != 0)) + { + ram_data.reg.testword = STC3117_RAM_TESTWORD; + ram_data.reg.cc_cnf = data->cc_cnf; + ram_data.reg.vm_cnf = data->vm_cnf; + ram_data.reg.crc = crc8(stc3117_crc_table, ram_data.ram_bytes, + STC3117_RAM_SIZE - 1, CRC8_INIT); + ram_data.reg.state = STC3117_INIT; + } + + /* check battery presence status */ + ret = regmap_read(data->regmap, STC3117_ADDR_CTRL, &mode); + if ((mode & STC3117_BATFAIL) != 0) + { + data->presence = 0; + ram_data.reg.testword = 0; + ram_data.reg.state = STC3117_INIT; + ret = ram_write(data); + if (ret) + return ret; + regmap_write(data->regmap, STC3117_ADDR_CTRL, STC3117_PORDET); + } + + data->presence = 1; + + ret = regmap_read(data->regmap, STC3117_ADDR_MODE, &mode); + if ((mode & STC3117_GG_RUN) == 0) + { + if (ram_data.reg.state > STC3117_INIT) { + ret = stc3117_set_para(data); + if (ret) + return ret; + + regmap_write(data->regmap, STC3117_ADDR_SOC_H, + (ram_data.reg.hrsoc >> 8 & 0xFF)); + regmap_write(data->regmap, STC3117_ADDR_SOC_L, + (ram_data.reg.hrsoc & 0xFF)); + } else { + ret = regmap_read(data->regmap, STC3117_ADDR_OCV_H, &ocv_m); + + ret |= regmap_read(data->regmap, STC3117_ADDR_OCV_L, &ocv_l); + + ret |= stc3117_set_para(data); + + ret |= regmap_write(data->regmap, STC3117_ADDR_OCV_H, ocv_m); + + ret |= regmap_write(data->regmap, STC3117_ADDR_OCV_L, ocv_l); + if (ret) + return ret; + } + ram_data.reg.state = STC3117_INIT; + } + + regmap_read(data->regmap, STC3117_ADDR_COUNTER_L, &count_l); + regmap_read(data->regmap, STC3117_ADDR_COUNTER_H, &count_m); + + count_m = (count_m << 8) + count_l; + + /* INIT state, wait for batt_current & temperature value available: */ + if (ram_data.reg.state == STC3117_INIT && count_m > 4) { + data->avg_voltage = data->voltage; + data->avg_current = data->batt_current; + ram_data.reg.state = STC3117_RUNNING; + } + + if (ram_data.reg.state != STC3117_RUNNING) + { + data->batt_current = 0; + data->temp = 250; + } else { + if (data->voltage < APP_CUTOFF_VOLTAGE) + data->soc = 0; + + if (mode & STC3117_VMODE) { + data->avg_current = 0; + data->batt_current = 0; + } else { + stc3117_update_battery_status(data); + } + } + + ram_data.reg.hrsoc = data->hrsoc; + ram_data.reg.soc = (data->soc + 5) / 10; + ram_data.reg.crc = crc8(stc3117_crc_table, ram_data.ram_bytes, + STC3117_RAM_SIZE - 1, CRC8_INIT); + + ret = ram_write(data); + if (ret) + return ret; + return 0; +}; + +static void fuel_gauge_update_work(struct work_struct *work) +{ + struct stc3117_data *data = container_of(to_delayed_work(work), + struct stc3117_data, update_work); + stc3117_task(data); + + /* Schedule the work to run again in 2 seconds */ + schedule_delayed_work(&data->update_work, msecs_to_jiffies(2000)); +} + +static int stc3117_get_property(struct power_supply *psy, + enum power_supply_property psp, union power_supply_propval *val) +{ + struct stc3117_data *data = power_supply_get_drvdata(psy); + + switch (psp) { + case POWER_SUPPLY_PROP_STATUS: + if (data->soc > BATTERY_FULL) + val->intval = POWER_SUPPLY_STATUS_FULL; + if (data->batt_current < 0) + val->intval = POWER_SUPPLY_STATUS_CHARGING; + else if (data->batt_current > 0) + val->intval = POWER_SUPPLY_STATUS_DISCHARGING; + else + val->intval = POWER_SUPPLY_STATUS_NOT_CHARGING; + break; + case POWER_SUPPLY_PROP_VOLTAGE_NOW: + val->intval = data->voltage; + break; + case POWER_SUPPLY_PROP_CURRENT_NOW: + val->intval = data->batt_current; + break; + case POWER_SUPPLY_PROP_CAPACITY: + val->intval = data->soc; + break; + case POWER_SUPPLY_PROP_TEMP: + val->intval = data->temp; + break; + case POWER_SUPPLY_PROP_PRESENT: + val->intval = data->presence; + break; + default: + return -EINVAL; + } + return 0; +} + +static enum power_supply_property stc3117_battery_props[] = { + POWER_SUPPLY_PROP_STATUS, + POWER_SUPPLY_PROP_VOLTAGE_NOW, + POWER_SUPPLY_PROP_CURRENT_NOW, + POWER_SUPPLY_PROP_CAPACITY, + POWER_SUPPLY_PROP_TEMP, + POWER_SUPPLY_PROP_PRESENT, +}; + +static const struct power_supply_desc stc3117_battery_desc = { + .name = "stc3117-battery", + .type = POWER_SUPPLY_TYPE_BATTERY, + .get_property = stc3117_get_property, + .properties = stc3117_battery_props, + .num_properties = ARRAY_SIZE(stc3117_battery_props), +}; + +static const struct regmap_config stc3117_regmap_config = { + .reg_bits = 8, + .val_bits = 8, +}; + +static int stc3117_probe(struct i2c_client *client) +{ + struct stc3117_data *data; + struct power_supply_config psy_cfg = {}; + struct power_supply_battery_info *info; + int ret; + + data = devm_kzalloc(&client->dev, sizeof(*data), GFP_KERNEL); + if (!data) + return -ENOMEM; + + data->client = client; + data->regmap = devm_regmap_init_i2c(client, &stc3117_regmap_config); + if (IS_ERR(data->regmap)) + return PTR_ERR(data->regmap); + + i2c_set_clientdata(client, data); + psy_cfg.drv_data = data; + + crc8_populate_msb(stc3117_crc_table, CRC8_POLYNOMIAL); + + data->battery = devm_power_supply_register(&client->dev, + &stc3117_battery_desc, &psy_cfg); + if (IS_ERR(data->battery)) + return dev_err_probe(&client->dev, PTR_ERR(data->battery), + "failed to register battery\n"); + + ret = device_property_read_u32(&client->dev, "sense-resistor", + &battery_info.sense_resistor); + if (ret) + return dev_err_probe(&client->dev, ret, + "failed to get sense-register\n"); + + ret = power_supply_get_battery_info(data->battery, &info); + if (ret) + return dev_err_probe(&client->dev, ret, + "failed to get battery information\n"); + + battery_info.battery_capacity = info->charge_full_design_uah * 1000; + battery_info.voltage_min = info->voltage_min_design_uv * 1000; + battery_info.voltage_max = info->voltage_min_design_uv * 1000; + + ret = stc3117_init(data); + if (ret) + return dev_err_probe(&client->dev, ret, + "failed to initialization of stc3117\n"); + + INIT_DELAYED_WORK(&data->update_work, fuel_gauge_update_work); + + schedule_delayed_work(&data->update_work, 0); + + return 0; +} + +static const struct i2c_device_id stc3117_id[] = { + {"stc3117", 0}, + {}, +}; +MODULE_DEVICE_TABLE(i2c, stc3117_id); + +static const struct of_device_id stc3117_of_match[] = { + { .compatible = "st,stc3117" }, + {}, +}; +MODULE_DEVICE_TABLE(of, stc3117_of_match); + +static struct i2c_driver stc3117_i2c_driver = { + .driver = { + .name = "stc3117_i2c_driver", + .of_match_table = stc3117_of_match, + }, + .probe = stc3117_probe, + .id_table = stc3117_id, +}; + +module_i2c_driver(stc3117_i2c_driver); + +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("Bhavin Sharma <bhavin.sharma@siliconsignals.io>"); +MODULE_AUTHOR("Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>"); +MODULE_DESCRIPTION("STC3117 Fuel Gauge Driver"); -- 2.43.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v5 2/2] power: supply: Add STC3117 fuel gauge unit driver 2024-11-29 11:40 ` [PATCH v5 2/2] power: supply: Add STC3117 fuel gauge unit driver Bhavin Sharma @ 2024-11-30 17:47 ` Christophe JAILLET 0 siblings, 0 replies; 7+ messages in thread From: Christophe JAILLET @ 2024-11-30 17:47 UTC (permalink / raw) Cc: conor+dt, devicetree, krzk+dt, linux-kernel, linux-pm, robh, sre [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset=y, Size: 5770 bytes --] My mailer refuses adesses at @siliconsignals.io. So not every one is in this reply Le 29/11/2024 à 12:40, Bhavin Sharma a écrit : > Adds initial support for the STC3117 fuel gauge. > > The driver provides functionality to monitor key parameters including: > - Voltage > - Current > - State of Charge (SOC) > - Temperature > - Status > > Signed-off-by: Bhavin Sharma <bhavin.sharma@siliconsignals.io> > Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io> > --- ... > +/* Bit mask definition */ > +#define STC3117_ID 0x16 > +#define STC3117_MIXED_MODE 0x00 > +#define STC3117_VMODE BIT(0) > +#define STC3117_GG_RUN BIT(4) > +#define STC3117_CC_MODE BIT(5) One unneeded extra tab? > +#define STC3117_BATFAIL BIT(3) > +#define STC3117_PORDET BIT(4) > +#define STC3117_RAM_SIZE 16 > +#define STC3117_OCV_TABLE_SIZE 16 > +#define STC3117_RAM_TESTWORD 0x53A9 > +#define STC3117_SOFT_RESET 0x11 > +#define STC3117_NOMINAL_CAPACITY 2600 ... > +static int stc3117_set_para(struct stc3117_data *data) > +{ > + int ret; > + > + ret = regmap_write(data->regmap, STC3117_ADDR_MODE, STC3117_VMODE); > + > + for (int i = 0; i < STC3117_OCV_TABLE_SIZE; i++) > + regmap_write(data->regmap, STC3117_ADDR_OCV_TABLE + i, > + ocvValue[i] * 100 / 55); Should there be a ret |= ? > + if (data->soc_tab[1] != 0) > + regmap_bulk_write(data->regmap, STC3117_ADDR_SOC_TABLE, > + data->soc_tab, STC3117_OCV_TABLE_SIZE); Should there be a ret |= ? If it is needed, some other places in the driver may alos need it. > + > + ret |= regmap_write(data->regmap, STC3117_ADDR_CC_CNF_H, > + (ram_data.reg.cc_cnf >> 8) & 0xFF); > + > + ret |= regmap_write(data->regmap, STC3117_ADDR_CC_CNF_L, > + ram_data.reg.cc_cnf & 0xFF); > + > + ret |= regmap_write(data->regmap, STC3117_ADDR_VM_CNF_H, > + (ram_data.reg.vm_cnf >> 8) & 0xFF); > + > + ret |= regmap_write(data->regmap, STC3117_ADDR_VM_CNF_L, > + ram_data.reg.vm_cnf & 0xFF); > + > + ret |= regmap_write(data->regmap, STC3117_ADDR_CTRL, 0x03); > + > + ret |= regmap_write(data->regmap, STC3117_ADDR_MODE, > + STC3117_MIXED_MODE | STC3117_GG_RUN); > + > + return ret; > +}; ... > +static int stc3117_get_property(struct power_supply *psy, > + enum power_supply_property psp, union power_supply_propval *val) > +{ > + struct stc3117_data *data = power_supply_get_drvdata(psy); > + > + switch (psp) { > + case POWER_SUPPLY_PROP_STATUS: > + if (data->soc > BATTERY_FULL) > + val->intval = POWER_SUPPLY_STATUS_FULL; This is dead-code. "val->intval" is over-written in ALL paths below. The logic looks broken. > + if (data->batt_current < 0) > + val->intval = POWER_SUPPLY_STATUS_CHARGING; > + else if (data->batt_current > 0) > + val->intval = POWER_SUPPLY_STATUS_DISCHARGING; > + else > + val->intval = POWER_SUPPLY_STATUS_NOT_CHARGING; > + break; > + case POWER_SUPPLY_PROP_VOLTAGE_NOW: > + val->intval = data->voltage; > + break; > + case POWER_SUPPLY_PROP_CURRENT_NOW: > + val->intval = data->batt_current; > + break; > + case POWER_SUPPLY_PROP_CAPACITY: > + val->intval = data->soc; > + break; > + case POWER_SUPPLY_PROP_TEMP: > + val->intval = data->temp; > + break; > + case POWER_SUPPLY_PROP_PRESENT: > + val->intval = data->presence; > + break; > + default: > + return -EINVAL; > + } > + return 0; > +} ... > +static int stc3117_probe(struct i2c_client *client) > +{ > + struct stc3117_data *data; > + struct power_supply_config psy_cfg = {}; > + struct power_supply_battery_info *info; > + int ret; > + > + data = devm_kzalloc(&client->dev, sizeof(*data), GFP_KERNEL); > + if (!data) > + return -ENOMEM; > + > + data->client = client; > + data->regmap = devm_regmap_init_i2c(client, &stc3117_regmap_config); > + if (IS_ERR(data->regmap)) > + return PTR_ERR(data->regmap); > + > + i2c_set_clientdata(client, data); Is it needed? (there is no i2c_get_clientdata() in the code) > + psy_cfg.drv_data = data; > + > + crc8_populate_msb(stc3117_crc_table, CRC8_POLYNOMIAL); > + > + data->battery = devm_power_supply_register(&client->dev, > + &stc3117_battery_desc, &psy_cfg);> + if (IS_ERR(data->battery)) > + return dev_err_probe(&client->dev, PTR_ERR(data->battery), > + "failed to register battery\n"); > + > + ret = device_property_read_u32(&client->dev, "sense-resistor", > + &battery_info.sense_resistor); > + if (ret) > + return dev_err_probe(&client->dev, ret, > + "failed to get sense-register\n"); Should it be "failed to get sense-resistor\n"? > + > + ret = power_supply_get_battery_info(data->battery, &info); > + if (ret) > + return dev_err_probe(&client->dev, ret, > + "failed to get battery information\n"); > + > + battery_info.battery_capacity = info->charge_full_design_uah * 1000; > + battery_info.voltage_min = info->voltage_min_design_uv * 1000; > + battery_info.voltage_max = info->voltage_min_design_uv * 1000; Should it be voltage_max_design_uv? > + > + ret = stc3117_init(data); > + if (ret) > + return dev_err_probe(&client->dev, ret, > + "failed to initialization of stc3117\n"); "failed initialization" of "failed to initialize"? > + > + INIT_DELAYED_WORK(&data->update_work, fuel_gauge_update_work); > + > + schedule_delayed_work(&data->update_work, 0); > + > + return 0; > +} > + > +static const struct i2c_device_id stc3117_id[] = { > + {"stc3117", 0}, Spaces sould be added to match stc3117_of_match below. > + {}, Unneeded ending comma after a terminator entry. > +}; > +MODULE_DEVICE_TABLE(i2c, stc3117_id); > + > +static const struct of_device_id stc3117_of_match[] = { > + { .compatible = "st,stc3117" }, > + {}, Unneeded ending comma after a terminator entry. > +}; > +MODULE_DEVICE_TABLE(of, stc3117_of_match); ... CJ ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-11-30 17:49 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-11-29 11:40 [PATCH v5 0/2] power: supply: Add STC3117 Fuel Gauge Bhavin Sharma 2024-11-29 11:40 ` [PATCH v5 1/2] dt-bindings: " Bhavin Sharma 2024-11-29 11:48 ` Krzysztof Kozlowski 2024-11-29 12:17 ` Bhavin Sharma 2024-11-29 12:16 ` Rob Herring (Arm) 2024-11-29 11:40 ` [PATCH v5 2/2] power: supply: Add STC3117 fuel gauge unit driver Bhavin Sharma 2024-11-30 17:47 ` Christophe JAILLET
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox