devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Liu Ying <victor.liu@nxp.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	Shawn Guo <shawnguo@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property
Date: Tue, 13 Dec 2022 14:04:35 +0100	[thread overview]
Message-ID: <4ea1a5c1-bedf-6c6d-3d0e-fad75fcfeff7@denx.de> (raw)
In-Reply-To: <94cc48cf-c6eb-b626-88ab-18e9dfcb5fb1@linaro.org>

On 12/13/22 08:57, Krzysztof Kozlowski wrote:
> On 12/12/2022 13:54, Rob Herring wrote:
>> On Sun, Dec 11, 2022 at 11:51 PM Marek Vasut <marex@denx.de> wrote:
>>>
>>> The power-domains property is mandatory on i.MX8M Mini, Nano, Plus
>>> and i.MX6SX, i.MX6SL. Document the property and mark it as required
>>> on the aforementioned variants of the IP, present in those SoCs.
>>>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>> ---
>>> Cc: Fabio Estevam <festevam@gmail.com>
>>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
>>> Cc: Liu Ying <victor.liu@nxp.com>
>>> Cc: Lucas Stach <l.stach@pengutronix.de>
>>> Cc: NXP Linux Team <linux-imx@nxp.com>
>>> Cc: Rob Herring <robh+dt@kernel.org>
>>> Cc: Shawn Guo <shawnguo@kernel.org>
>>> Cc: linux-arm-kernel@lists.infradead.org
>>> To: devicetree@vger.kernel.org
>>> ---
>>> V2: - Add AB from Krzysztof
>>>      - Add mx6sx power domain into the list
>>> V3: - Update commit message
>>>      - Add i.MX6SL
>>>      - Update example
>>> ---
>>>   .../devicetree/bindings/display/fsl,lcdif.yaml  | 17 +++++++++++++++++
>>>   1 file changed, 17 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>> index 876015a44a1e6..1f17be501749b 100644
>>> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>> @@ -52,6 +52,9 @@ properties:
>>>     interrupts:
>>>       maxItems: 1
>>>
>>> +  power-domains:
>>> +    maxItems: 1
>>> +
>>
>> This conflicts with adding 'power-domains' for i.MX8MP in my tree.
> 
> Yes, this is a duplicated patch.
> 
> Please either check for already submitted works in lore (dfn:) or use
> linux-next as your base...

Understood, I only used linux-next 20221208 , which was the latest 
available at that point.

If I rebase on today's next-20221213 , I see the only duplicate part is

"
+  power-domains:
+    maxItems: 1
+
"

The rest of this patch is still valid.

> Unack.

I see

      reply	other threads:[~2022-12-13 13:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-12  5:51 [PATCH v3] dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property Marek Vasut
2022-12-12  6:45 ` Liu Ying
2022-12-12 12:54 ` Rob Herring
2022-12-13  7:57   ` Krzysztof Kozlowski
2022-12-13 13:04     ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ea1a5c1-bedf-6c6d-3d0e-fad75fcfeff7@denx.de \
    --to=marex@denx.de \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=victor.liu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).