From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Maso Huang <maso.huang@mediatek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Trevor Wu <trevor.wu@mediatek.com>, Arnd Bergmann <arnd@arndb.de>,
Mars Chen <chenxiangrui@huaqin.corp-partner.google.com>,
Allen-KH Cheng <allen-kh.cheng@mediatek.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v3 3/6] ASoC: mediatek: mt7986: add platform driver
Date: Fri, 28 Jul 2023 11:38:09 +0200 [thread overview]
Message-ID: <4eb32bcc-9a1b-c477-71b1-823bd96c0450@collabora.com> (raw)
In-Reply-To: <20230728090819.18038-4-maso.huang@mediatek.com>
Il 28/07/23 11:08, Maso Huang ha scritto:
> Add mt7986 platform driver.
>
> Signed-off-by: Maso Huang <maso.huang@mediatek.com>
> ---
> sound/soc/mediatek/Kconfig | 10 +
> sound/soc/mediatek/Makefile | 1 +
> sound/soc/mediatek/mt7986/Makefile | 8 +
> sound/soc/mediatek/mt7986/mt7986-afe-pcm.c | 622 +++++++++++++++++++++
> 4 files changed, 641 insertions(+)
> create mode 100644 sound/soc/mediatek/mt7986/Makefile
> create mode 100644 sound/soc/mediatek/mt7986/mt7986-afe-pcm.c
>
..snip..
> + /* register component */
> + ret = devm_snd_soc_register_component(&pdev->dev,
> + &mt7986_afe_component,
> + NULL, 0);
> + if (ret)
> + return dev_err_probe(dev, ret, "err_platform\n");
I know I only said about using dev_err_probe(), but "err_platform" doesn't
mean anything!
Please write a human readable error message, like "Cannot register AFE component\n"
> +
> + ret = devm_snd_soc_register_component(afe->dev,
> + &mt7986_afe_pcm_dai_component,
> + afe->dai_drivers,
> + afe->num_dai_drivers);
> + if (ret)
> + return dev_err_probe(dev, ret, "err_dai_component\n");
And the same here, "Cannot register PCM DAI component\n"
After which:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2023-07-28 9:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 9:08 [PATCH v3 0/6] ASoC: mediatek: Add support for MT7986 SoC Maso Huang
2023-07-28 9:08 ` [PATCH v3 1/6] ASoC: mediatek: mt7986: add common header Maso Huang
2023-08-04 9:15 ` Alexandre Mergnat
2023-08-04 10:24 ` Maso Huang (黃加竹)
2023-07-28 9:08 ` [PATCH v3 2/6] ASoC: mediatek: mt7986: support etdm in platform driver Maso Huang
2023-08-04 9:57 ` Alexandre Mergnat
2023-08-08 7:49 ` Maso Huang (黃加竹)
2023-07-28 9:08 ` [PATCH v3 3/6] ASoC: mediatek: mt7986: add " Maso Huang
2023-07-28 9:38 ` AngeloGioacchino Del Regno [this message]
2023-07-28 10:13 ` Maso Huang (黃加竹)
2023-07-28 9:08 ` [PATCH v3 4/6] ASoC: mediatek: mt7986: add machine driver with wm8960 Maso Huang
2023-07-28 9:49 ` AngeloGioacchino Del Regno
2023-07-28 9:52 ` AngeloGioacchino Del Regno
2023-07-31 6:50 ` Maso Huang (黃加竹)
2023-07-28 9:08 ` [PATCH v3 5/6] ASoC: dt-bindings: mediatek,mt7986-wm8960: add mt7986-wm8960 document Maso Huang
2023-07-28 9:55 ` AngeloGioacchino Del Regno
2023-07-28 10:16 ` Maso Huang (黃加竹)
2023-07-31 6:42 ` Maso Huang (黃加竹)
2023-07-31 10:44 ` AngeloGioacchino Del Regno
2023-07-31 12:38 ` Maso Huang (黃加竹)
2023-07-28 12:49 ` Krzysztof Kozlowski
2023-07-31 7:31 ` Maso Huang (黃加竹)
2023-07-31 8:14 ` Krzysztof Kozlowski
2023-07-31 14:56 ` Krzysztof Kozlowski
2023-08-04 7:08 ` Maso Huang (黃加竹)
2023-07-28 9:08 ` [PATCH v3 6/6] ASoC: dt-bindings: mediatek,mt7986-afe: add audio afe document Maso Huang
2023-07-28 10:00 ` AngeloGioacchino Del Regno
2023-07-28 10:19 ` Maso Huang (黃加竹)
2023-07-28 12:51 ` Krzysztof Kozlowski
2023-07-28 13:26 ` Mark Brown
2023-08-01 8:25 ` Maso Huang (黃加竹)
2023-08-04 9:45 ` Krzysztof Kozlowski
2023-08-04 10:29 ` Maso Huang (黃加竹)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4eb32bcc-9a1b-c477-71b1-823bd96c0450@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=chenxiangrui@huaqin.corp-partner.google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maso.huang@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=trevor.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).